From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
lorenzo.bianconi83@gmail.com, denis.ciocca@st.com,
mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com
Subject: Re: [PATCH v8 3/5] iio: imu: st_lsm6dsx: add wakeup-source option
Date: Sun, 15 Sep 2019 15:42:37 +0200 [thread overview]
Message-ID: <20190915134237.GE15634@lore-desk-wlan.lan> (raw)
In-Reply-To: <20190913090708.1442057-4-sean@geanix.com>
[-- Attachment #1: Type: text/plain, Size: 2174 bytes --]
> This add ways for the SoC to wake from accelerometer wake events.
>
> In the suspend function we skip disabling the sensor if wakeup-source
> and events are activated.
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
> Changes since v4:
> * More devices supports wakeup
>
> Changes since v5:
> * None
>
> Changes since v6:
> * None
>
> Changes since v7:
> * Add check for hw->enable_event
> * Moved disable_irq_wake section so it's called
> * Removed not neeeded continue from disable_irq_wake section
>
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index 4198ba263d03..810807c52d5f 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -1858,6 +1858,9 @@ int st_lsm6dsx_probe(struct device *dev, int irq, int hw_id,
> return err;
> }
>
> + if (dev->of_node && of_property_read_bool(dev->of_node, "wakeup-source"))
> + device_init_wakeup(dev, true);
> +
> return 0;
> }
> EXPORT_SYMBOL(st_lsm6dsx_probe);
> @@ -1876,6 +1879,13 @@ static int __maybe_unused st_lsm6dsx_suspend(struct device *dev)
> if (!(hw->enable_mask & BIT(sensor->id)))
> continue;
>
> + if (device_may_wakeup(dev) && i == ST_LSM6DSX_ID_ACC &&
since you have to send v9...better to use sensor->id instead of i here
> + hw->enable_event) {
> + /* Enable wake from IRQ */
> + enable_irq_wake(hw->irq);
> + continue;
> + }
> +
> if (sensor->id == ST_LSM6DSX_ID_EXT0 ||
> sensor->id == ST_LSM6DSX_ID_EXT1 ||
> sensor->id == ST_LSM6DSX_ID_EXT2)
> @@ -1904,6 +1914,10 @@ static int __maybe_unused st_lsm6dsx_resume(struct device *dev)
> if (!hw->iio_devs[i])
> continue;
>
> + if (device_may_wakeup(dev) && i == ST_LSM6DSX_ID_ACC &&
> + hw->enable_event)
> + disable_irq_wake(hw->irq);
> +
> sensor = iio_priv(hw->iio_devs[i]);
> if (!(hw->suspend_mask & BIT(sensor->id)))
> continue;
> --
> 2.23.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-09-15 13:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 9:07 [PATCH v8 0/5] enable motion events for st_lsm6dsx Sean Nyekjaer
2019-09-13 9:07 ` [PATCH v8 1/5] iio: imu: st_lsm6dsx: move interrupt thread to core Sean Nyekjaer
2019-09-13 9:07 ` [PATCH v8 2/5] iio: imu: st_lsm6dsx: add motion events Sean Nyekjaer
2019-09-13 9:07 ` [PATCH v8 3/5] iio: imu: st_lsm6dsx: add wakeup-source option Sean Nyekjaer
2019-09-15 13:42 ` Lorenzo Bianconi [this message]
2019-09-13 9:07 ` [PATCH v8 4/5] iio: imu: st_lsm6dsx: always enter interrupt thread Sean Nyekjaer
2019-09-15 12:33 ` Jonathan Cameron
2019-09-15 12:48 ` Lorenzo Bianconi
2019-09-15 13:00 ` Jonathan Cameron
2019-09-15 13:07 ` Lorenzo Bianconi
2019-09-13 9:07 ` [PATCH v8 5/5] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Sean Nyekjaer
2019-09-15 12:30 ` Jonathan Cameron
2019-09-15 13:05 ` Lorenzo Bianconi
2019-09-15 13:18 ` Jonathan Cameron
2019-09-15 13:22 ` Sean Nyekjaer
2019-09-15 13:35 ` Jonathan Cameron
2019-09-16 9:02 ` [RFC PATCH] iio: imu: st_lsm6dsx: filter motion events in driver Sean Nyekjaer
2019-09-16 9:16 ` Lorenzo Bianconi
2019-09-16 11:29 ` Sean Nyekjaer
2019-09-16 11:55 ` Lorenzo Bianconi
2019-09-16 12:09 ` Sean Nyekjaer
2019-09-16 12:22 ` Lorenzo Bianconi
2019-09-15 13:41 ` [PATCH v8 5/5] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915134237.GE15634@lore-desk-wlan.lan \
--to=lorenzo@kernel.org \
--cc=armando.visconti@st.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=mario.tesi@st.com \
--cc=martin@geanix.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).