From: Jonathan Cameron <jic23@kernel.org> To: Lorenzo Bianconi <lorenzo@kernel.org> Cc: Sean Nyekjaer <sean@geanix.com>, linux-iio@vger.kernel.org, lorenzo.bianconi83@gmail.com, denis.ciocca@st.com, mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com Subject: Re: [PATCH v8 4/5] iio: imu: st_lsm6dsx: always enter interrupt thread Date: Sun, 15 Sep 2019 14:00:56 +0100 Message-ID: <20190915140056.296f1e23@archlinux> (raw) In-Reply-To: <20190915124840.GA15634@lore-desk-wlan.lan> On Sun, 15 Sep 2019 14:48:40 +0200 Lorenzo Bianconi <lorenzo@kernel.org> wrote: > > On Fri, 13 Sep 2019 11:07:07 +0200 > > Sean Nyekjaer <sean@geanix.com> wrote: > > > > > The interrupt source can come from multiple sources, > > > fifo and wake interrupts. > > > Enter interrupt thread to check which interrupt that has fired. > > > > > > Signed-off-by: Sean Nyekjaer <sean@geanix.com> > > > --- > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > index 810807c52d5f..80a94335175f 100644 > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > @@ -1717,9 +1717,7 @@ static struct iio_dev *st_lsm6dsx_alloc_iiodev(struct st_lsm6dsx_hw *hw, > > > > > > static irqreturn_t st_lsm6dsx_handler_irq(int irq, void *private) > > > { > > > - struct st_lsm6dsx_hw *hw = private; > > > - > > > - return hw->sip > 0 ? IRQ_WAKE_THREAD : IRQ_NONE; > > > + return IRQ_WAKE_THREAD; > > > > I missed this before. Isn't this the same as just not providing a top half at all? > > > > I.e. Pass null to request_threaded_irq where this function was. > > > > Thanks, > > > > Jonathan > > Right, for the moment we do not need it. It will be probably useful adding > buffering support for sensors that do not support hw timestamping in FIFO > (e.g. LSM9DS1). I am fine both ways, so up to you. Scrap it for now. I suspect someone will have a script out there that will fire on this and generate a patch removing it. Better to not waste people's time! Thanks, Jonathan > > Regards, > Lorenzo > > > > > > > > } > > > > > > static irqreturn_t st_lsm6dsx_handler_thread(int irq, void *private) > >
next prev parent reply index Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-13 9:07 [PATCH v8 0/5] enable motion events for st_lsm6dsx Sean Nyekjaer 2019-09-13 9:07 ` [PATCH v8 1/5] iio: imu: st_lsm6dsx: move interrupt thread to core Sean Nyekjaer 2019-09-13 9:07 ` [PATCH v8 2/5] iio: imu: st_lsm6dsx: add motion events Sean Nyekjaer 2019-09-13 9:07 ` [PATCH v8 3/5] iio: imu: st_lsm6dsx: add wakeup-source option Sean Nyekjaer 2019-09-15 13:42 ` Lorenzo Bianconi 2019-09-13 9:07 ` [PATCH v8 4/5] iio: imu: st_lsm6dsx: always enter interrupt thread Sean Nyekjaer 2019-09-15 12:33 ` Jonathan Cameron 2019-09-15 12:48 ` Lorenzo Bianconi 2019-09-15 13:00 ` Jonathan Cameron [this message] 2019-09-15 13:07 ` Lorenzo Bianconi 2019-09-13 9:07 ` [PATCH v8 5/5] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Sean Nyekjaer 2019-09-15 12:30 ` Jonathan Cameron 2019-09-15 13:05 ` Lorenzo Bianconi 2019-09-15 13:18 ` Jonathan Cameron 2019-09-15 13:22 ` Sean Nyekjaer 2019-09-15 13:35 ` Jonathan Cameron 2019-09-16 9:02 ` [RFC PATCH] iio: imu: st_lsm6dsx: filter motion events in driver Sean Nyekjaer 2019-09-16 9:16 ` Lorenzo Bianconi 2019-09-16 11:29 ` Sean Nyekjaer 2019-09-16 11:55 ` Lorenzo Bianconi 2019-09-16 12:09 ` Sean Nyekjaer 2019-09-16 12:22 ` Lorenzo Bianconi 2019-09-15 13:41 ` [PATCH v8 5/5] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Lorenzo Bianconi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190915140056.296f1e23@archlinux \ --to=jic23@kernel.org \ --cc=armando.visconti@st.com \ --cc=denis.ciocca@st.com \ --cc=linux-iio@vger.kernel.org \ --cc=lorenzo.bianconi83@gmail.com \ --cc=lorenzo@kernel.org \ --cc=mario.tesi@st.com \ --cc=martin@geanix.com \ --cc=sean@geanix.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-IIO Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \ linux-iio@vger.kernel.org public-inbox-index linux-iio Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio AGPL code for this site: git clone https://public-inbox.org/public-inbox.git