From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E72AC4CEC7 for ; Sun, 15 Sep 2019 13:18:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37539214D9 for ; Sun, 15 Sep 2019 13:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568553495; bh=MD4Q7vinG4BNREXAkS8gGoAmPC3nHNrBATZ9kblPb1o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Lou172VFnWoco+UZJasw8281xsouulEsBZ2dYrHSv3aAKwzhFCnD+mj6NLWt1S5QL wug9hpOgDOk4DR5Kpx2/rSKlJkyXnue73HxCzSz/WA76d1LsRnxUyLz7B9061m9j7F k8k4JlmyWsFupFgU5qAIHjSqWZQsoYpbBiErDIcw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726212AbfIONSO (ORCPT ); Sun, 15 Sep 2019 09:18:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:46924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725613AbfIONSO (ORCPT ); Sun, 15 Sep 2019 09:18:14 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C53A4214C6; Sun, 15 Sep 2019 13:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568553493; bh=MD4Q7vinG4BNREXAkS8gGoAmPC3nHNrBATZ9kblPb1o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LLPYwgkv8JOtKKyJG97yoONUT6aSTkIDYIyTTRdso1cPccjn2Cjw4bRQ2WVTFaWMf oPOv7jf1Rwd+yHtPwHbAlN9bU2bRTnpw6gSOVl04fgrY7FtQ+ftQo8IZ2T733HcdiX 2izUY7vQUq8Y3WKrPc+K8+ZrtfUqDnRt82tpeF3s= Date: Sun, 15 Sep 2019 14:18:08 +0100 From: Jonathan Cameron To: Lorenzo Bianconi Cc: Sean Nyekjaer , linux-iio@vger.kernel.org, lorenzo.bianconi83@gmail.com, denis.ciocca@st.com, mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com Subject: Re: [PATCH v8 5/5] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Message-ID: <20190915141808.6ca04f0f@archlinux> In-Reply-To: <20190915130508.GB15634@lore-desk-wlan.lan> References: <20190913090708.1442057-1-sean@geanix.com> <20190913090708.1442057-6-sean@geanix.com> <20190915133040.0953ef1a@archlinux> <20190915130508.GB15634@lore-desk-wlan.lan> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 15 Sep 2019 15:05:08 +0200 Lorenzo Bianconi wrote: > > On Fri, 13 Sep 2019 11:07:08 +0200 > > Sean Nyekjaer wrote: > > > > > Report iio motion events to iio subsystem > > > > > > Signed-off-by: Sean Nyekjaer > > I got to the earlier thread rather late so hadn't replied to your > > question on filtering events that haven't been enabled. > > IIUC, how is possible to filter events? it seems not currently supported in > hw, right? Filter them in software on their way to userspace. So you'll get an interrupt either way, but no need to tell userspace about event's it's not interested in. > > > > > Hence I think it's just that change outstanding > > + I want to give Lorenzo time for a final look. > > Jonathan the series seems fine to me now, there are some leftover nitpicks we can > cover with some follow-up patches. Acks/Reviewed-bys? Let's do this formally! Jonathan > > Regards, > Lorenzo > > > > > Thanks, > > > > Jonathan > > > > > --- > > > Changes since v4: > > > * Updated bitmask as pr Jonathans comments > > > > > > Changes since v5: > > > * None > > > > > > Changes since v6: > > > * None > > > > > > Changes since v7: > > > * None > > > > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 5 ++ > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 70 ++++++++++++++++++++ > > > 2 files changed, 75 insertions(+) > > > > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h > > > index 449c2798f7ed..7c50fac7b85c 100644 > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h > > > @@ -186,6 +186,11 @@ struct st_lsm6dsx_shub_settings { > > > struct st_lsm6dsx_event_settings { > > > struct st_lsm6dsx_reg enable_reg; > > > struct st_lsm6dsx_reg wakeup_reg; > > > + u8 wakeup_src_reg; > > > + u8 wakeup_src_status_mask; > > > + u8 wakeup_src_z_mask; > > > + u8 wakeup_src_y_mask; > > > + u8 wakeup_src_x_mask; > > > }; > > > > > > enum st_lsm6dsx_ext_sensor_id { > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > index 80a94335175f..66700c20920d 100644 > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c > > > @@ -48,6 +48,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -287,6 +288,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > .addr = 0x5B, > > > .mask = GENMASK(5, 0), > > > }, > > > + .wakeup_src_reg = 0x1b, > > > + .wakeup_src_status_mask = BIT(3), > > > + .wakeup_src_z_mask = BIT(0), > > > + .wakeup_src_y_mask = BIT(1), > > > + .wakeup_src_x_mask = BIT(2), > > > }, > > > }, > > > { > > > @@ -412,6 +418,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > .addr = 0x5B, > > > .mask = GENMASK(5, 0), > > > }, > > > + .wakeup_src_reg = 0x1b, > > > + .wakeup_src_status_mask = BIT(3), > > > + .wakeup_src_z_mask = BIT(0), > > > + .wakeup_src_y_mask = BIT(1), > > > + .wakeup_src_x_mask = BIT(2), > > > }, > > > }, > > > { > > > @@ -550,6 +561,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > .addr = 0x5B, > > > .mask = GENMASK(5, 0), > > > }, > > > + .wakeup_src_reg = 0x1b, > > > + .wakeup_src_status_mask = BIT(3), > > > + .wakeup_src_z_mask = BIT(0), > > > + .wakeup_src_y_mask = BIT(1), > > > + .wakeup_src_x_mask = BIT(2), > > > }, > > > }, > > > { > > > @@ -816,6 +832,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > .addr = 0x5B, > > > .mask = GENMASK(5, 0), > > > }, > > > + .wakeup_src_reg = 0x1b, > > > + .wakeup_src_status_mask = BIT(3), > > > + .wakeup_src_z_mask = BIT(0), > > > + .wakeup_src_y_mask = BIT(1), > > > + .wakeup_src_x_mask = BIT(2), > > > }, > > > }, > > > { > > > @@ -970,6 +991,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { > > > .addr = 0x5B, > > > .mask = GENMASK(5, 0), > > > }, > > > + .wakeup_src_reg = 0x1b, > > > + .wakeup_src_status_mask = BIT(3), > > > + .wakeup_src_z_mask = BIT(0), > > > + .wakeup_src_y_mask = BIT(1), > > > + .wakeup_src_x_mask = BIT(2), > > > } > > > }, > > > }; > > > @@ -1715,6 +1741,38 @@ static struct iio_dev *st_lsm6dsx_alloc_iiodev(struct st_lsm6dsx_hw *hw, > > > return iio_dev; > > > } > > > > > > +void st_lsm6dsx_report_motion_event(struct st_lsm6dsx_hw *hw, int data) > > > +{ > > > + s64 timestamp = iio_get_time_ns(hw->iio_devs[ST_LSM6DSX_ID_ACC]); > > > + > > > + if (data & hw->settings->event_settings.wakeup_src_z_mask) > > > + iio_push_event(hw->iio_devs[ST_LSM6DSX_ID_ACC], > > > + IIO_MOD_EVENT_CODE(IIO_ACCEL, > > > + 0, > > > + IIO_MOD_Z, > > > + IIO_EV_TYPE_THRESH, > > > + IIO_EV_DIR_EITHER), > > > + timestamp); > > > + > > > + if (data & hw->settings->event_settings.wakeup_src_x_mask) > > > + iio_push_event(hw->iio_devs[ST_LSM6DSX_ID_ACC], > > > + IIO_MOD_EVENT_CODE(IIO_ACCEL, > > > + 0, > > > + IIO_MOD_Y, > > > + IIO_EV_TYPE_THRESH, > > > + IIO_EV_DIR_EITHER), > > > + timestamp); > > > + > > > + if (data & hw->settings->event_settings.wakeup_src_x_mask) > > > + iio_push_event(hw->iio_devs[ST_LSM6DSX_ID_ACC], > > > + IIO_MOD_EVENT_CODE(IIO_ACCEL, > > > + 0, > > > + IIO_MOD_X, > > > + IIO_EV_TYPE_THRESH, > > > + IIO_EV_DIR_EITHER), > > > + timestamp); > > > +} > > > + > > > static irqreturn_t st_lsm6dsx_handler_irq(int irq, void *private) > > > { > > > return IRQ_WAKE_THREAD; > > > @@ -1724,6 +1782,18 @@ static irqreturn_t st_lsm6dsx_handler_thread(int irq, void *private) > > > { > > > struct st_lsm6dsx_hw *hw = private; > > > int count; > > > + int data, err; > > > + > > > + if (hw->enable_event) { > > > + err = regmap_read(hw->regmap, > > > + hw->settings->event_settings.wakeup_src_reg, > > > + &data); > > > + if (err < 0) > > > + return IRQ_NONE; > > > + > > > + if (data & hw->settings->event_settings.wakeup_src_status_mask) > > > + st_lsm6dsx_report_motion_event(hw, data); > > > + } > > > > > > mutex_lock(&hw->fifo_lock); > > > count = hw->settings->fifo_ops.read_fifo(hw); > >