From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CA0CC4360C for ; Thu, 10 Oct 2019 20:47:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8C87214E0 for ; Thu, 10 Oct 2019 20:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570740474; bh=0qtSobB54FOGf/eZgjxhfeC6u172QJwPi3EX3VybASM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=N7vxvGDahTAZXWeBkSNMPPukSUGhKtaI1rLnyrapTKD6SxgJfuvPzOrOJ4B3mmbF6 S3j62/ZOyoH47SyBM/2SCT95NjZx8gYUEjN7E3SRenV4Z9C6MjqAi4DICOIrsC77tF ARrv8Bncibcoc5jpyyv9C8kkzFGBynxDFroRaBjM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726132AbfJJUrx (ORCPT ); Thu, 10 Oct 2019 16:47:53 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:35772 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbfJJUrx (ORCPT ); Thu, 10 Oct 2019 16:47:53 -0400 Received: by mail-ot1-f66.google.com with SMTP id z6so6120820otb.2; Thu, 10 Oct 2019 13:47:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g2NGn0JHqOilhKsSqB3QO+8Vmh7wDxbT9p6+g1mCprE=; b=nJZR9HW9Dv2c46lP46u+OSwROftwwj3BufjhfxcQ8PEb8I6zyaN2nQqahcmzYvqNPZ 2ZjKFIqOULnGw0Md7VrTwx5/6GPZy8DflWJjYw4FDA1bOfOvDe/IneAaSD1Kpk2NkHqA 6VpqNcJBoT2QxhfRJp3CYJepL5PUN0b2YHCovR4kxxqaQV/tLL4PmTbnRE0pZd3jQFuZ Z27TE0zmGcDs1GJ/yKIU+Pu7RXpoK91Db8Tg6SPWJAxWqBvhuMjwI+x2UliKr++inn7U P6RzafJbGZ4MUGuPbmM50WUAOd9ks6Q64WxluqfpFYZ5b9VknCKk2xOm/mq7tvgG7lKI lEXg== X-Gm-Message-State: APjAAAXi0is+a4IOeXDdLF3IaMk3vE5wJ2je3pnhMI15HRRSKzi3HlSp v8gPTrEGYAYS7PWFxHE0HQ== X-Google-Smtp-Source: APXvYqwO+SASp9nvuTYNhH5Lei92FxE4O9+patnbNl3BtRfrzxeoEACn9HX6g2Q4lVizs+j/8ybC8A== X-Received: by 2002:a9d:6c56:: with SMTP id g22mr9306234otq.89.1570740472180; Thu, 10 Oct 2019 13:47:52 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id v7sm425440oic.9.2019.10.10.13.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 13:47:51 -0700 (PDT) Date: Thu, 10 Oct 2019 15:47:51 -0500 From: Rob Herring To: Miquel Raynal Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mark Rutland , devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH v3 8/8] dt-bindings: Add max12xx SPI ADC series as trivial devices Message-ID: <20191010204751.GA22206@bogus> References: <20191007132657.4190-1-miquel.raynal@bootlin.com> <20191007132657.4190-9-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191007132657.4190-9-miquel.raynal@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, Oct 07, 2019 at 03:26:57PM +0200, Miquel Raynal wrote: > Update the compatible list with three Maxim ADCs compatibles. > > Signed-off-by: Miquel Raynal > --- > .../bindings/iio/adc/max1027-adc.txt | 28 +++++++++++++++++++ > .../devicetree/bindings/trivial-devices.yaml | 6 ++++ > 2 files changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt Devices are supposed to be documented in one place or the other. So either make max1027-adc.txt a schema or drop it. I'm fine either way. Obviously, trivial-devices.yaml is trivial to add to, but it does leave some ambiguities. Like is an interrupt required, optional or non-existent? What about power supplies? Or what are allowed values for spi-max-frequency. Rob