From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE54ACA9EAF for ; Sun, 27 Oct 2019 16:37:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F05521850 for ; Sun, 27 Oct 2019 16:37:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572194226; bh=QrqJRLB2CvIZon4VyHcws0KFgqepB0PfXIDsLqLzeGA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=KxoGzR9lr8oXzpSuVqAGNlQU941hSd2Fv1M51XiewsFys6OGPlNxjpdUuqdUsOXdt w3+QQoO3vXcsG53jZOCPrWx7FNhRkak2tSNWJMFJg1ObLoiJu9T/VVb+p9Je+h6SvH 6FW6edeUH8+9gEGbRnrpCE9HAZxdhdT8/77M8x+U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726838AbfJ0QhG (ORCPT ); Sun, 27 Oct 2019 12:37:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:50522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726920AbfJ0QhG (ORCPT ); Sun, 27 Oct 2019 12:37:06 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2384B21726; Sun, 27 Oct 2019 16:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572194225; bh=QrqJRLB2CvIZon4VyHcws0KFgqepB0PfXIDsLqLzeGA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MwyVHYYJqUQE5K2eFkgNRIEaXG8hL/bkEBCgx+ea6n58zJtnawdB2OUZ8UhIXSal7 fSV+zkJePDgnBphZjT53Fnc6/3oFl4FJUMJ/J86dy9hTCTCPLXqZg1nNoAy9xc3OG3 0UvU/JghVwoK1Yy8CzWTtwy6zxGChNzQc6jZmiPo= Date: Sun, 27 Oct 2019 16:37:00 +0000 From: Jonathan Cameron To: Nuno =?UTF-8?B?U8Oh?= Cc: , Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler Subject: Re: [PATCH 2/2] iio: adis16480: Add debugfs_reg_access entry Message-ID: <20191027163700.16d7d3f8@archlinux> In-Reply-To: <20191025124508.166648-2-nuno.sa@analog.com> References: <20191025124508.166648-1-nuno.sa@analog.com> <20191025124508.166648-2-nuno.sa@analog.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 25 Oct 2019 14:45:08 +0200 Nuno S=C3=A1 wrote: > The driver is defining debugfs entries by calling > `adis16480_debugfs_init()`. However, those entries are attached to the > iio_dev debugfs entry which won't exist if no debugfs_reg_access > callback is provided. >=20 > Signed-off-by: Nuno S=C3=A1 As you are respinning the first one and this is probably stable material as well, please add a fixes tag for v2. Thanks, Jonathan > --- > drivers/iio/imu/adis16480.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c > index 3b53bbb11bfb..94aa1c57e605 100644 > --- a/drivers/iio/imu/adis16480.c > +++ b/drivers/iio/imu/adis16480.c > @@ -921,6 +921,7 @@ static const struct iio_info adis16480_info =3D { > .read_raw =3D &adis16480_read_raw, > .write_raw =3D &adis16480_write_raw, > .update_scan_mode =3D adis_update_scan_mode, > + .debugfs_reg_access =3D adis_debugfs_reg_access, > }; > =20 > static int adis16480_stop_device(struct iio_dev *indio_dev)