From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B49CA9EB0 for ; Sun, 3 Nov 2019 10:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38896214E0 for ; Sun, 3 Nov 2019 10:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572776730; bh=WTxM6Ibc3QKJyTK44KnaxTI2l5Cnh8TX3bpCQRrlJiY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=D7p7ggYuEZSTKf0rsaPnp0FWnGdw2+VmLE7xLgo0KDkN7eXoLI0NWsi4H/Zw5BiiP 58MjgYEDux0CQuDO558Zwi+xsjdXVbZqn597zbYfjh91sTTI28rhlpUL9oo2QsLf6L JoCVvqvfoL+sdk0GPjI0mKr4v6dChN976YeCI1X8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727377AbfKCKZ3 (ORCPT ); Sun, 3 Nov 2019 05:25:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:52096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726408AbfKCKZ3 (ORCPT ); Sun, 3 Nov 2019 05:25:29 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3093420842; Sun, 3 Nov 2019 10:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572776728; bh=WTxM6Ibc3QKJyTK44KnaxTI2l5Cnh8TX3bpCQRrlJiY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=By0JoHd+51ISddgZr38vjridT5SBZUNUxWjemOsBwYzXcHmwnnWeAK1p+wudettyx NxkcuL4Lm8qYlm8eeGSsD/pnyvTDqAh5/8cXpmXDn3f9PePNAue3GT/MIJRKypw+Wc /iU0HHVIxoxt8C8aGQnC3ClXCa9lk20JB3TQ1T0E= Date: Sun, 3 Nov 2019 10:25:24 +0000 From: Jonathan Cameron To: Alexandru Ardelean Cc: , , , , Subject: Re: [PATCH 03/10] iio: imu: adis16460: check ret val for non-zero vs less-than-zero Message-ID: <20191103102524.2b5e05cc@archlinux> In-Reply-To: <20191101093505.9408-4-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> <20191101093505.9408-4-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 1 Nov 2019 11:34:58 +0200 Alexandru Ardelean wrote: > The ADIS library functions return zero on success, and negative values for > error. Positive values aren't returned, but we only care about the success > value (which is zero). > > This change is mostly needed so that the compiler won't make any inferences > about some about values being potentially un-initialized. This only > triggers after making some functions inline, because the compiler can > better follow return paths. > > Signed-off-by: Alexandru Ardelean Applied thanks. Jonathan > --- > drivers/iio/imu/adis16460.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/imu/adis16460.c b/drivers/iio/imu/adis16460.c > index 6aed9e84abbf..b55812521537 100644 > --- a/drivers/iio/imu/adis16460.c > +++ b/drivers/iio/imu/adis16460.c > @@ -80,7 +80,7 @@ static int adis16460_show_serial_number(void *arg, u64 *val) > > ret = adis_read_reg_16(&adis16460->adis, ADIS16460_REG_SERIAL_NUM, > &serial); > - if (ret < 0) > + if (ret) > return ret; > > *val = serial; > @@ -98,7 +98,7 @@ static int adis16460_show_product_id(void *arg, u64 *val) > > ret = adis_read_reg_16(&adis16460->adis, ADIS16460_REG_PROD_ID, > &prod_id); > - if (ret < 0) > + if (ret) > return ret; > > *val = prod_id; > @@ -116,7 +116,7 @@ static int adis16460_show_flash_count(void *arg, u64 *val) > > ret = adis_read_reg_32(&adis16460->adis, ADIS16460_REG_FLASH_CNT, > &flash_count); > - if (ret < 0) > + if (ret) > return ret; > > *val = flash_count; > @@ -176,7 +176,7 @@ static int adis16460_get_freq(struct iio_dev *indio_dev, int *val, int *val2) > unsigned int freq; > > ret = adis_read_reg_16(&st->adis, ADIS16460_REG_DEC_RATE, &t); > - if (ret < 0) > + if (ret) > return ret; > > freq = 2048000 / (t + 1);