Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] iio: adc: bcm_iproc_adc: drop a stray semicolon
@ 2019-10-13 12:18 jic23
  2019-11-04 15:15 ` Ardelean, Alexandru
  0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 12:18 UTC (permalink / raw)
  To: linux-iio; +Cc: Jonathan Cameron, Raveendra Padasalagi

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Found by coccinelle / coccicheck

CHECK   drivers/iio/adc/bcm_iproc_adc.c
drivers/iio/adc/bcm_iproc_adc.c:311:3-4: Unneeded semicolon

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
---
 drivers/iio/adc/bcm_iproc_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
index 646ebdc0a8b4..5e396104ac86 100644
--- a/drivers/iio/adc/bcm_iproc_adc.c
+++ b/drivers/iio/adc/bcm_iproc_adc.c
@@ -308,7 +308,7 @@ static int iproc_adc_do_read(struct iio_dev *indio_dev,
 				"IntMask set failed. Read will likely fail.");
 			read_len = -EIO;
 			goto adc_err;
-		};
+		}
 	}
 	regmap_read(adc_priv->regmap, IPROC_INTERRUPT_MASK, &val_check);
 
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: adc: bcm_iproc_adc: drop a stray semicolon
  2019-10-13 12:18 [PATCH] iio: adc: bcm_iproc_adc: drop a stray semicolon jic23
@ 2019-11-04 15:15 ` Ardelean, Alexandru
  2019-11-09 12:17   ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2019-11-04 15:15 UTC (permalink / raw)
  To: jic23, linux-iio; +Cc: Jonathan.Cameron, raveendra.padasalagi

On Sun, 2019-10-13 at 13:18 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Found by coccinelle / coccicheck
> 
> CHECK   drivers/iio/adc/bcm_iproc_adc.c
> drivers/iio/adc/bcm_iproc_adc.c:311:3-4: Unneeded semicolon
> 

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> ---
>  drivers/iio/adc/bcm_iproc_adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/bcm_iproc_adc.c
> b/drivers/iio/adc/bcm_iproc_adc.c
> index 646ebdc0a8b4..5e396104ac86 100644
> --- a/drivers/iio/adc/bcm_iproc_adc.c
> +++ b/drivers/iio/adc/bcm_iproc_adc.c
> @@ -308,7 +308,7 @@ static int iproc_adc_do_read(struct iio_dev
> *indio_dev,
>  				"IntMask set failed. Read will likely
> fail.");
>  			read_len = -EIO;
>  			goto adc_err;
> -		};
> +		}
>  	}
>  	regmap_read(adc_priv->regmap, IPROC_INTERRUPT_MASK, &val_check);
>  

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: adc: bcm_iproc_adc: drop a stray semicolon
  2019-11-04 15:15 ` Ardelean, Alexandru
@ 2019-11-09 12:17   ` Jonathan Cameron
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-11-09 12:17 UTC (permalink / raw)
  To: Ardelean, Alexandru; +Cc: linux-iio, Jonathan.Cameron, raveendra.padasalagi

On Mon, 4 Nov 2019 15:15:30 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sun, 2019-10-13 at 13:18 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Found by coccinelle / coccicheck
> > 
> > CHECK   drivers/iio/adc/bcm_iproc_adc.c
> > drivers/iio/adc/bcm_iproc_adc.c:311:3-4: Unneeded semicolon
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied thanks.

Jonathan

> 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > ---
> >  drivers/iio/adc/bcm_iproc_adc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/bcm_iproc_adc.c
> > b/drivers/iio/adc/bcm_iproc_adc.c
> > index 646ebdc0a8b4..5e396104ac86 100644
> > --- a/drivers/iio/adc/bcm_iproc_adc.c
> > +++ b/drivers/iio/adc/bcm_iproc_adc.c
> > @@ -308,7 +308,7 @@ static int iproc_adc_do_read(struct iio_dev
> > *indio_dev,
> >  				"IntMask set failed. Read will likely
> > fail.");
> >  			read_len = -EIO;
> >  			goto adc_err;
> > -		};
> > +		}
> >  	}
> >  	regmap_read(adc_priv->regmap, IPROC_INTERRUPT_MASK, &val_check);
> >    


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 12:18 [PATCH] iio: adc: bcm_iproc_adc: drop a stray semicolon jic23
2019-11-04 15:15 ` Ardelean, Alexandru
2019-11-09 12:17   ` Jonathan Cameron

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git