From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0EDCC43331 for ; Sat, 9 Nov 2019 12:23:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8A6821848 for ; Sat, 9 Nov 2019 12:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573302223; bh=dS+Q94tAc4gH/z7Q+IFfr6eO9zTmQkHVu5Ido9mdckU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=eW5Ix1jbQ2bJw7AiimCEaarlHwLXtCPBRyfjymYef8qwIEeKAm+l+jfvgL/nFfZNm 3c3fCJezBrTYpmPGQ4lotybjQkH/6nnWs630X30ZCbmAYEeF/Oayj2UOzsdaVklbck VamrPj7dXQqSnj9ypNpq6fsPLAOYz6XjhQjXT9Sg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726149AbfKIMXn (ORCPT ); Sat, 9 Nov 2019 07:23:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:42990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbfKIMXn (ORCPT ); Sat, 9 Nov 2019 07:23:43 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7131D20659; Sat, 9 Nov 2019 12:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573302222; bh=dS+Q94tAc4gH/z7Q+IFfr6eO9zTmQkHVu5Ido9mdckU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sGk1IzDETFahHa4xn/+3g1wxsjBZX554kqtSMR83pLsa0lGMO3bDju4tQpdE6CkD+ B4LyHMcKKvvPqKAW9Y0tskuzPWklsH+SLAtApGszgSly/b0PhPuvxs0OJcNvORZwjx SDs4ACYz4YemyXJ9Zxo4uiovLLLsh1t/OX4xc0p0= Date: Sat, 9 Nov 2019 12:23:38 +0000 From: Jonathan Cameron To: "Ardelean, Alexandru" Cc: "linux-iio@vger.kernel.org" , "tmaimon77@gmail.com" , "Jonathan.Cameron@huawei.com" Subject: Re: [PATCH] iio: adc: npcm: use devm_platform_ioremap_resource Message-ID: <20191109122338.2f24fad9@archlinux> In-Reply-To: <82747a09236357a7b1a285404dcc9ae17baac963.camel@analog.com> References: <20191013154427.1853794-1-jic23@kernel.org> <82747a09236357a7b1a285404dcc9ae17baac963.camel@analog.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 4 Nov 2019 15:17:08 +0000 "Ardelean, Alexandru" wrote: > On Sun, 2019-10-13 at 16:44 +0100, jic23@kernel.org wrote: > > From: Jonathan Cameron > > > > Reduces local boilerplate code. > > Suggested by coccinelle via coccicheck. > > > > CHECK drivers/iio/adc/npcm_adc.c > > drivers/iio/adc/npcm_adc.c:200:1-11: WARNING: Use > > devm_platform_ioremap_resource for info -> regs > > > > Reviewed-by: Alexandru Ardelean Applied, Thanks, Jonathan > > > Signed-off-by: Jonathan Cameron > > Cc: Tomer Maimon > > --- > > drivers/iio/adc/npcm_adc.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/npcm_adc.c b/drivers/iio/adc/npcm_adc.c > > index 910f3585fa54..a6170a37ebe8 100644 > > --- a/drivers/iio/adc/npcm_adc.c > > +++ b/drivers/iio/adc/npcm_adc.c > > @@ -183,7 +183,6 @@ static int npcm_adc_probe(struct platform_device > > *pdev) > > int irq; > > u32 div; > > u32 reg_con; > > - struct resource *res; > > struct npcm_adc *info; > > struct iio_dev *indio_dev; > > struct device *dev = &pdev->dev; > > @@ -196,8 +195,7 @@ static int npcm_adc_probe(struct platform_device > > *pdev) > > > > info->dev = &pdev->dev; > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - info->regs = devm_ioremap_resource(&pdev->dev, res); > > + info->regs = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(info->regs)) > > return PTR_ERR(info->regs); > >