From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA122C43331 for ; Sun, 10 Nov 2019 17:12:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B44C62085B for ; Sun, 10 Nov 2019 17:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573405952; bh=/KkqecyOJYBFCx0D/yKSm7L3y/HCier7+TlwX0yrVvI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=RovJawWvhyOuribAwRCm+P2kNAneUr9s36aJocRKzLTsIGMnTYHADTH4YWNkcCXyg TuYj7kyC/1O+yvoOgp1GkFyk/rYT1k44NOzM+RaNSn96L2z4EVDLjhsZZkvw83rYX8 TOe0ZgV4dnPoCVevI/Y4Q+kJy8xYoBP7hEkbJ0mQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726651AbfKJRMc (ORCPT ); Sun, 10 Nov 2019 12:12:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:53564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726733AbfKJRMc (ORCPT ); Sun, 10 Nov 2019 12:12:32 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF11C20842; Sun, 10 Nov 2019 17:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573405951; bh=/KkqecyOJYBFCx0D/yKSm7L3y/HCier7+TlwX0yrVvI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SvdgotGvRwAnYxOLtptKKpssSMmVhvud+ObHtZ7BYFLo2jKkciYUqlomIWoXoSEZS JXfjuOzbbavz1bcnwvXnqOSyYBW/BzFQUHdwJIYo4X4ydPIE3D9laPxWMzbzdJZCSc SPnuKVR0d5gG2Jn4g7xqlbdKGyupiA0esTW0bFms= Date: Sun, 10 Nov 2019 17:12:26 +0000 From: Jonathan Cameron To: Laura Abbott Cc: Jiri Olsa , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada Subject: Re: [PATCH] tools: iio: Correctly add make dependency for iio_utils Message-ID: <20191110171226.13b68f18@archlinux> In-Reply-To: <20191027165414.3e4c3530@archlinux> References: <20191018172908.3761-1-labbott@redhat.com> <20191027165414.3e4c3530@archlinux> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 27 Oct 2019 16:54:14 +0000 Jonathan Cameron wrote: > On Fri, 18 Oct 2019 13:29:08 -0400 > Laura Abbott wrote: > > > iio tools fail to build correctly with make parallelization: > > > > $ make -s -j24 > > fixdep: error opening depfile: ./.iio_utils.o.d: No such file or directory > > make[1]: *** [/home/labbott/linux_upstream/tools/build/Makefile.build:96: iio_utils.o] Error 2 > > make: *** [Makefile:43: iio_event_monitor-in.o] Error 2 > > make: *** Waiting for unfinished jobs.... > > > > This is because iio_utils.o is used across multiple targets. > > Fix this by making iio_utils.o a proper dependency. > > > > Signed-off-by: Laura Abbott > This looks fine to me, but my Makefile foo is decidedly limited. > Anyone else want to give a view? > > It seems sensible to backport this to stable as it seems low > risk and will avoid some odd issues for distros. I've applied it to the togreg branch of iio.git for now. We can request a stable backport once it's in mainline. It might make the coming merge window if Linus suggest we are looking at an rc8. Thanks, Jonathan > > Thanks, > > Jonathan > > --- > > I realize that we don't really need the parallelization for tools > > because it's so small but when building with the distro we want to use > > the same make command and -j wherever possible. > > > > This same issue also appears in the gpio tools so if this looks like an > > okay approach I'll fix it there as well. > > --- > > tools/iio/Build | 1 + > > tools/iio/Makefile | 10 +++++++--- > > 2 files changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/tools/iio/Build b/tools/iio/Build > > index f74cbda64710..8d0f3af3723f 100644 > > --- a/tools/iio/Build > > +++ b/tools/iio/Build > > @@ -1,3 +1,4 @@ > > +iio_utils-y += iio_utils.o > > lsiio-y += lsiio.o iio_utils.o > > iio_event_monitor-y += iio_event_monitor.o iio_utils.o > > iio_generic_buffer-y += iio_generic_buffer.o iio_utils.o > > diff --git a/tools/iio/Makefile b/tools/iio/Makefile > > index e22378dba244..3de763d9ab70 100644 > > --- a/tools/iio/Makefile > > +++ b/tools/iio/Makefile > > @@ -32,20 +32,24 @@ $(OUTPUT)include/linux/iio: ../../include/uapi/linux/iio > > > > prepare: $(OUTPUT)include/linux/iio > > > > +IIO_UTILS_IN := $(OUTPUT)iio_utils-in.o > > +$(IIO_UTILS_IN): prepare FORCE > > + $(Q)$(MAKE) $(build)=iio_utils > > + > > LSIIO_IN := $(OUTPUT)lsiio-in.o > > -$(LSIIO_IN): prepare FORCE > > +$(LSIIO_IN): prepare FORCE $(OUTPUT)iio_utils-in.o > > $(Q)$(MAKE) $(build)=lsiio > > $(OUTPUT)lsiio: $(LSIIO_IN) > > $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@ > > > > IIO_EVENT_MONITOR_IN := $(OUTPUT)iio_event_monitor-in.o > > -$(IIO_EVENT_MONITOR_IN): prepare FORCE > > +$(IIO_EVENT_MONITOR_IN): prepare FORCE $(OUTPUT)iio_utils-in.o > > $(Q)$(MAKE) $(build)=iio_event_monitor > > $(OUTPUT)iio_event_monitor: $(IIO_EVENT_MONITOR_IN) > > $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@ > > > > IIO_GENERIC_BUFFER_IN := $(OUTPUT)iio_generic_buffer-in.o > > -$(IIO_GENERIC_BUFFER_IN): prepare FORCE > > +$(IIO_GENERIC_BUFFER_IN): prepare FORCE $(OUTPUT)iio_utils-in.o > > $(Q)$(MAKE) $(build)=iio_generic_buffer > > $(OUTPUT)iio_generic_buffer: $(IIO_GENERIC_BUFFER_IN) > > $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@ >