From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D093CC432C0 for ; Sun, 24 Nov 2019 22:53:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1F132075E for ; Sun, 24 Nov 2019 22:53:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726931AbfKXWw7 (ORCPT ); Sun, 24 Nov 2019 17:52:59 -0500 Received: from sender4-op-o14.zoho.com ([136.143.188.14]:17478 "EHLO sender4-op-o14.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726855AbfKXWw7 (ORCPT ); Sun, 24 Nov 2019 17:52:59 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1574635958; cv=none; d=zohomail.com; s=zohoarc; b=nkhEXIzF9+0eSVEWhcQyoV6RJb7cH7U8Gr2gkLFCjEeuJUg2huMqkHX0csaHlKyVgttBtlmDlKmWemY0aVu/zthNq2k2KSD+DscGEN05VjaeiZ11vK7T5saX6/nN7xxYjPFNNrByvVz3HcsxcsCB6lL+rDvDFh2aEdoqoFfBLCM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574635958; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=VBlCIOBlmhYT1nXzZeusUrp2ZE5E5KFbCpOclqk1oRI=; b=H9LIerKIxFLVX+a3CgdMu5BaAD8LkvS1IfTDtU6XBlJ4JhB/Ve3h8gklOB/hfWRDtUAJb9qdkBJOPSTTLVegEd5k5y/ffGTLwnlkWiUVFkDnLjLmFmxuOc7sgFNdTxiYP+cIQzzj6yyU8q8xgptetWnCe8uBeJ8shM+4enZtpTc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=dlrobertson.com; spf=pass smtp.mailfrom=dan@dlrobertson.com; dmarc=pass header.from= header.from= Received: from nessie (pool-173-73-58-202.washdc.fios.verizon.net [173.73.58.202]) by mx.zohomail.com with SMTPS id 1574635957113882.9905876044394; Sun, 24 Nov 2019 14:52:37 -0800 (PST) Date: Sun, 24 Nov 2019 22:37:34 +0000 From: Dan Robertson To: Jonathan Cameron Cc: Andy Shevchenko , linux-iio , Peter Meerwald-Stadler , devicetree , Hartmut Knaack , Rob Herring , Mark Rutland , Linux Kernel Mailing List , Randy Dunlap Subject: Re: [PATCH v4 2/2] iio: (bma400) add driver for the BMA400 Message-ID: <20191124223734.GA13261@nessie> References: <20191018031848.18538-1-dan@dlrobertson.com> <20191018031848.18538-3-dan@dlrobertson.com> <20191019024351.GB8593@nessie> <20191021162016.531e6a2e@archlinux> <20191118002504.GA29469@nessie> <20191123125135.4c7efcb0@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191123125135.4c7efcb0@archlinux> User-Agent: Mutt/1.12.2 (2019-09-21) X-ZohoMailClient: External Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, Nov 23, 2019 at 12:51:35PM +0000, Jonathan Cameron wrote: > If a function is your preferred route you could also just use it to compute > the values for the available table at startup? Yeah that makes sense. I'll add that in the next patchset version. > > The sampling ratio, frequency, etc code seems to be the most complicated part > > of the driver. Is it typically recommended to upstream a more minimal driver > > that might assume the defaults? > > Often people upstream a first version that just uses defaults, then follow > up (if they care) with later series adding the more fiddly elements. > > Sometimes those more fiddly bits never come as a particular author > never needed them. That's absolutely fine. It's a rare driver > that supports all the features on a non trivial device! Makes sense. I'll likely add some extra bits in a follow-up patchset, so I can learn a bit more. Cheers, - Dan