Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] iio: imu: st_lsm6dsx: fix checkpatch warning
@ 2019-11-29  8:46 Lorenzo Bianconi
  2019-12-01 21:00 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Bianconi @ 2019-11-29  8:46 UTC (permalink / raw)
  To: jic23; +Cc: lorenzo.bianconi, linux-iio

Fix following checkpatch warning:

CHECK: Alignment should match open parenthesis
+static int st_lsm6dsx_read_event(struct iio_dev *iio_dev,
+                                  const struct iio_chan_spec *chan,

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
index a7d40c02ce6b..990643da9f4e 100644
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
@@ -1607,12 +1607,13 @@ static int st_lsm6dsx_event_setup(struct st_lsm6dsx_hw *hw, int state)
 					     hw->irq_routing->mask, data);
 }
 
-static int st_lsm6dsx_read_event(struct iio_dev *iio_dev,
-				   const struct iio_chan_spec *chan,
-				   enum iio_event_type type,
-				   enum iio_event_direction dir,
-				   enum iio_event_info info,
-				   int *val, int *val2)
+static int
+st_lsm6dsx_read_event(struct iio_dev *iio_dev,
+		      const struct iio_chan_spec *chan,
+		      enum iio_event_type type,
+		      enum iio_event_direction dir,
+		      enum iio_event_info info,
+		      int *val, int *val2)
 {
 	struct st_lsm6dsx_sensor *sensor = iio_priv(iio_dev);
 	struct st_lsm6dsx_hw *hw = sensor->hw;
@@ -1620,8 +1621,8 @@ static int st_lsm6dsx_read_event(struct iio_dev *iio_dev,
 	if (type != IIO_EV_TYPE_THRESH)
 		return -EINVAL;
 
-	*val2 = 0;
 	*val = hw->event_threshold;
+	*val2 = 0;
 
 	return IIO_VAL_INT;
 }
-- 
2.21.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: imu: st_lsm6dsx: fix checkpatch warning
  2019-11-29  8:46 [PATCH] iio: imu: st_lsm6dsx: fix checkpatch warning Lorenzo Bianconi
@ 2019-12-01 21:00 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-12-01 21:00 UTC (permalink / raw)
  To: Lorenzo Bianconi; +Cc: lorenzo.bianconi, linux-iio

On Fri, 29 Nov 2019 10:46:44 +0200
Lorenzo Bianconi <lorenzo@kernel.org> wrote:

> Fix following checkpatch warning:
> 
> CHECK: Alignment should match open parenthesis
> +static int st_lsm6dsx_read_event(struct iio_dev *iio_dev,
> +                                  const struct iio_chan_spec *chan,
Fair enough on this tidy up, but the other bit of reorganization?
Why and why not mention it in the patch description?

Also, why the extra line break?  As far as I can see it can
be just fixed without that and still be under 80 chars.
Right now the only issue is that it's indented 2 spaces too many.

Jonathan


> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index a7d40c02ce6b..990643da9f4e 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -1607,12 +1607,13 @@ static int st_lsm6dsx_event_setup(struct st_lsm6dsx_hw *hw, int state)
>  					     hw->irq_routing->mask, data);
>  }
>  
> -static int st_lsm6dsx_read_event(struct iio_dev *iio_dev,
> -				   const struct iio_chan_spec *chan,
> -				   enum iio_event_type type,
> -				   enum iio_event_direction dir,
> -				   enum iio_event_info info,
> -				   int *val, int *val2)
> +static int
> +st_lsm6dsx_read_event(struct iio_dev *iio_dev,
> +		      const struct iio_chan_spec *chan,
> +		      enum iio_event_type type,
> +		      enum iio_event_direction dir,
> +		      enum iio_event_info info,
> +		      int *val, int *val2)
>  {
>  	struct st_lsm6dsx_sensor *sensor = iio_priv(iio_dev);
>  	struct st_lsm6dsx_hw *hw = sensor->hw;
> @@ -1620,8 +1621,8 @@ static int st_lsm6dsx_read_event(struct iio_dev *iio_dev,
>  	if (type != IIO_EV_TYPE_THRESH)
>  		return -EINVAL;
>  
> -	*val2 = 0;
>  	*val = hw->event_threshold;
> +	*val2 = 0;
>  
>  	return IIO_VAL_INT;
>  }


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29  8:46 [PATCH] iio: imu: st_lsm6dsx: fix checkpatch warning Lorenzo Bianconi
2019-12-01 21:00 ` Jonathan Cameron

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git