Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH] iio: ak8975: Convert to use GPIO descriptor
Date: Fri, 6 Dec 2019 17:43:00 +0000
Message-ID: <20191206174300.03541cf4@archlinux> (raw)
In-Reply-To: <20191202125756.GF32742@smile.fi.intel.com>

On Mon, 2 Dec 2019 14:57:56 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Mon, Dec 02, 2019 at 02:51:48PM +0200, Andy Shevchenko wrote:
> > On Mon, Dec 02, 2019 at 09:17:30AM +0100, Linus Walleij wrote:  
> > > The end-of-conversion (EOC) GPIO line is better to grab using
> > > a GPIO descriptor. We drop the pdata for this: clients using board
> > > files can use machine descriptor tables to pass this GPIO from
> > > static data.  
> 
> > >  		dev_err(&client->dev,
> > > -			"irq %d request failed, (gpio %d): %d\n",
> > > -			irq, data->eoc_gpio, rc);
> > > +			"irq %d request failed: %d\n",
> > > +			irq, rc);  
> > 
> > Now it fits one line.  
> 
> I meant including dev_err().
> 

Tidied up whilst applying.  Applied to the togreg branch of iio.git.
Pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02  8:17 Linus Walleij
2019-12-02 12:51 ` Andy Shevchenko
2019-12-02 12:57   ` Andy Shevchenko
2019-12-06 17:43     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191206174300.03541cf4@archlinux \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git