linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: imu: adis: use new `delay` structure for SPI transfer delays
Date: Sat, 7 Dec 2019 11:05:04 +0000	[thread overview]
Message-ID: <20191207110504.6db10b0a@archlinux> (raw)
In-Reply-To: <20191204080904.2557-1-alexandru.ardelean@analog.com>

On Wed, 4 Dec 2019 10:09:04 +0200
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:

> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current `delay_secs`
> with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6485 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
I don't yet have that patch in my upstream so this will have to wait until
it gets there. Give me a poke if I seem to have forgotten about it.

Thanks,

Jonathan


> ---
>  drivers/iio/imu/adis.c | 27 ++++++++++++++++++---------
>  1 file changed, 18 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index 2cd2cc2316c6..95af67470668 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -38,7 +38,8 @@ int adis_write_reg(struct adis *adis, unsigned int reg,
>  			.bits_per_word = 8,
>  			.len = 2,
>  			.cs_change = 1,
> -			.delay_usecs = adis->data->write_delay,
> +			.delay.value = adis->data->write_delay,
> +			.delay.unit = SPI_DELAY_UNIT_USECS,
>  			.cs_change_delay.value = adis->data->cs_change_delay,
>  			.cs_change_delay.unit = SPI_DELAY_UNIT_USECS,
>  		}, {
> @@ -46,7 +47,8 @@ int adis_write_reg(struct adis *adis, unsigned int reg,
>  			.bits_per_word = 8,
>  			.len = 2,
>  			.cs_change = 1,
> -			.delay_usecs = adis->data->write_delay,
> +			.delay.value = adis->data->write_delay,
> +			.delay.unit = SPI_DELAY_UNIT_USECS,
>  			.cs_change_delay.value = adis->data->cs_change_delay,
>  			.cs_change_delay.unit = SPI_DELAY_UNIT_USECS,
>  		}, {
> @@ -54,19 +56,22 @@ int adis_write_reg(struct adis *adis, unsigned int reg,
>  			.bits_per_word = 8,
>  			.len = 2,
>  			.cs_change = 1,
> -			.delay_usecs = adis->data->write_delay,
> +			.delay.value = adis->data->write_delay,
> +			.delay.unit = SPI_DELAY_UNIT_USECS,
>  			.cs_change_delay.value = adis->data->cs_change_delay,
>  			.cs_change_delay.unit = SPI_DELAY_UNIT_USECS,
>  		}, {
>  			.tx_buf = adis->tx + 6,
>  			.bits_per_word = 8,
>  			.len = 2,
> -			.delay_usecs = adis->data->write_delay,
> +			.delay.value = adis->data->write_delay,
> +			.delay.unit = SPI_DELAY_UNIT_USECS,
>  		}, {
>  			.tx_buf = adis->tx + 8,
>  			.bits_per_word = 8,
>  			.len = 2,
> -			.delay_usecs = adis->data->write_delay,
> +			.delay.value = adis->data->write_delay,
> +			.delay.unit = SPI_DELAY_UNIT_USECS,
>  		},
>  	};
>  
> @@ -138,7 +143,8 @@ int adis_read_reg(struct adis *adis, unsigned int reg,
>  			.bits_per_word = 8,
>  			.len = 2,
>  			.cs_change = 1,
> -			.delay_usecs = adis->data->write_delay,
> +			.delay.value = adis->data->write_delay,
> +			.delay.unit = SPI_DELAY_UNIT_USECS,
>  			.cs_change_delay.value = adis->data->cs_change_delay,
>  			.cs_change_delay.unit = SPI_DELAY_UNIT_USECS,
>  		}, {
> @@ -146,7 +152,8 @@ int adis_read_reg(struct adis *adis, unsigned int reg,
>  			.bits_per_word = 8,
>  			.len = 2,
>  			.cs_change = 1,
> -			.delay_usecs = adis->data->read_delay,
> +			.delay.value = adis->data->read_delay,
> +			.delay.unit = SPI_DELAY_UNIT_USECS,
>  			.cs_change_delay.value = adis->data->cs_change_delay,
>  			.cs_change_delay.unit = SPI_DELAY_UNIT_USECS,
>  		}, {
> @@ -155,14 +162,16 @@ int adis_read_reg(struct adis *adis, unsigned int reg,
>  			.bits_per_word = 8,
>  			.len = 2,
>  			.cs_change = 1,
> -			.delay_usecs = adis->data->read_delay,
> +			.delay.value = adis->data->read_delay,
> +			.delay.unit = SPI_DELAY_UNIT_USECS,
>  			.cs_change_delay.value = adis->data->cs_change_delay,
>  			.cs_change_delay.unit = SPI_DELAY_UNIT_USECS,
>  		}, {
>  			.rx_buf = adis->rx + 2,
>  			.bits_per_word = 8,
>  			.len = 2,
> -			.delay_usecs = adis->data->read_delay,
> +			.delay.value = adis->data->read_delay,
> +			.delay.unit = SPI_DELAY_UNIT_USECS,
>  		},
>  	};
>  


  reply	other threads:[~2019-12-07 11:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04  8:09 [PATCH] iio: imu: adis: use new `delay` structure for SPI transfer delays Alexandru Ardelean
2019-12-07 11:05 ` Jonathan Cameron [this message]
2019-12-10 14:07   ` Ardelean, Alexandru
2019-12-10 14:07 ` [PATCH v2] " Alexandru Ardelean
2020-01-13 22:04   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191207110504.6db10b0a@archlinux \
    --to=jic23@kernel.org \
    --cc=alexandru.ardelean@analog.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).