From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D248EC2D0CE for ; Fri, 24 Jan 2020 22:14:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4C082071A for ; Fri, 24 Jan 2020 22:14:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727264AbgAXWN7 (ORCPT ); Fri, 24 Jan 2020 17:13:59 -0500 Received: from ip-78-45-52-129.net.upcbroadband.cz ([78.45.52.129]:33208 "EHLO ixit.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727163AbgAXWN6 (ORCPT ); Fri, 24 Jan 2020 17:13:58 -0500 X-Greylist: delayed 583 seconds by postgrey-1.27 at vger.kernel.org; Fri, 24 Jan 2020 17:13:57 EST Received: from localhost.localdomain (227.146.230.94.awnet.cz [94.230.146.227]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ixit.cz (Postfix) with ESMTPSA id 2D81B251EA; Fri, 24 Jan 2020 23:04:17 +0100 (CET) From: David Heidelberg To: linux-iio@vger.kernel.org Cc: David Heidelberg Subject: [PATCH 5/7] iio: light: al3010 implement suspend support Date: Fri, 24 Jan 2020 23:03:44 +0100 Message-Id: <20200124220346.2655336-5-david@ixit.cz> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124220346.2655336-1-david@ixit.cz> References: <20200124220346.2655336-1-david@ixit.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org AL3010 is fairly simple chip, so for suspend is enough to disable and later enable it again. Signed-off-by: David Heidelberg --- drivers/iio/light/al3010.c | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index 863854415d5d..29e54e2bfc81 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -8,6 +8,9 @@ * IIO driver for AL3010 (7-bit I2C slave address 0x1C). * * TODO: interrupt support, thresholds + * When the driver will get support for interrupt handling, then interrupt + * will need to be disabled before turning sensor OFF in order to avoid + * potential races with the interrupt handling. */ #include @@ -71,13 +74,18 @@ static const struct attribute_group al3010_attribute_group = { .attrs = al3010_attributes, }; +static int al3010_set_pwr(struct i2c_client *client, bool pwr) +{ + u8 val = pwr ? AL3010_CONFIG_ENABLE : AL3010_CONFIG_DISABLE; + return i2c_smbus_write_byte_data(client, AL3010_REG_SYSTEM, val); +} + static int al3010_init(struct al3010_data *data) { int ret; - /* power on */ - ret = i2c_smbus_write_byte_data(data->client, AL3010_REG_SYSTEM, - AL3010_CONFIG_ENABLE); + ret = al3010_set_pwr(data->client, true); + if (ret < 0) return ret; @@ -185,10 +193,21 @@ static int al3010_probe(struct i2c_client *client, static int al3010_remove(struct i2c_client *client) { - return i2c_smbus_write_byte_data(client, AL3010_REG_SYSTEM, - AL3010_CONFIG_DISABLE); + return al3010_set_pwr(client, false); } +static int __maybe_unused al3010_suspend(struct device *dev) +{ + return al3010_set_pwr(to_i2c_client(dev), false); +} + +static int __maybe_unused al3010_resume(struct device *dev) +{ + return al3010_set_pwr(to_i2c_client(dev), true); +} + +SIMPLE_DEV_PM_OPS(al3010_pm_ops, al3010_suspend, al3010_resume); + static const struct i2c_device_id al3010_id[] = { {"al3010", 0}, {} @@ -205,6 +224,7 @@ static struct i2c_driver al3010_driver = { .driver = { .name = AL3010_DRV_NAME, .of_match_table = al3010_of_match, + .pm = &al3010_pm_ops, }, .probe = al3010_probe, .remove = al3010_remove, -- 2.25.0