Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Mircea Caprioru <mircea.caprioru@analog.com>
Cc: <Michael.Hennerich@analog.com>, <alexandru.ardelean@analog.com>,
	<lars@metafoo.de>, <gregkh@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH V4] iio: adc: ad7124: Add direct reg access
Date: Fri, 14 Feb 2020 14:47:55 +0000
Message-ID: <20200214144755.617e1aba@archlinux> (raw)
In-Reply-To: <20200211084453.16866-1-mircea.caprioru@analog.com>

On Tue, 11 Feb 2020 10:44:53 +0200
Mircea Caprioru <mircea.caprioru@analog.com> wrote:

> This patch adds the posibility do read and write registers from userspace
> using the kernel debug direct register access option.
> 
> Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
> Changelog V4:
> - verify limit againg ARRAY_SIZE(ad7124_reg_size)
> 
>  drivers/iio/adc/ad7124.c | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index f0206d819fda..a3c0647a5391 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -98,6 +98,14 @@ static const unsigned int ad7124_gain[8] = {
>  	1, 2, 4, 8, 16, 32, 64, 128
>  };
>  
> +static const unsigned int ad7124_reg_size[] = {
> +	1, 2, 3, 3, 2, 1, 3, 3, 1, 2, 2, 2, 2,
> +	2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
> +	2, 2, 2, 2, 2, 2, 2, 3, 3, 3, 3, 3, 3,
> +	3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3,
> +	3, 3, 3, 3, 3
> +};
> +
>  static const int ad7124_master_clk_freq_hz[3] = {
>  	[AD7124_LOW_POWER] = 76800,
>  	[AD7124_MID_POWER] = 153600,
> @@ -427,6 +435,27 @@ static int ad7124_write_raw(struct iio_dev *indio_dev,
>  	}
>  }
>  
> +static int ad7124_reg_access(struct iio_dev *indio_dev,
> +			     unsigned int reg,
> +			     unsigned int writeval,
> +			     unsigned int *readval)
> +{
> +	struct ad7124_state *st = iio_priv(indio_dev);
> +	int ret;
> +
> +	if (reg >= ARRAY_SIZE(ad7124_reg_size))
> +		return -EINVAL;
> +
> +	if (readval)
> +		ret = ad_sd_read_reg(&st->sd, reg, ad7124_reg_size[reg],
> +				     readval);
> +	else
> +		ret = ad_sd_write_reg(&st->sd, reg, ad7124_reg_size[reg],
> +				      writeval);
> +
> +	return ret;
> +}
> +
>  static IIO_CONST_ATTR(in_voltage_scale_available,
>  	"0.000001164 0.000002328 0.000004656 0.000009313 0.000018626 0.000037252 0.000074505 0.000149011 0.000298023");
>  
> @@ -442,6 +471,7 @@ static const struct attribute_group ad7124_attrs_group = {
>  static const struct iio_info ad7124_info = {
>  	.read_raw = ad7124_read_raw,
>  	.write_raw = ad7124_write_raw,
> +	.debugfs_reg_access = &ad7124_reg_access,
>  	.validate_trigger = ad_sd_validate_trigger,
>  	.attrs = &ad7124_attrs_group,
>  };


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11  8:44 Mircea Caprioru
2020-02-14 14:47 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214144755.617e1aba@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mircea.caprioru@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git