* [PATCH] dt-bindings: iio: adc: max1363 etc i2c ADC binding conversion
@ 2020-02-08 17:23 jic23
2020-02-19 22:10 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2020-02-08 17:23 UTC (permalink / raw)
To: linux-iio; +Cc: Rob Herring, Mark Rutland, devicetree, Jonathan Cameron
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Split the binding in two to reflect the threshold monitor capabilities
and hence interrupts vs the more straight forward parts that
don't have this facility.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
.../devicetree/bindings/iio/adc/max1363.txt | 63 ---------------
.../bindings/iio/adc/maxim,max1238.yaml | 76 +++++++++++++++++++
.../bindings/iio/adc/maxim,max1363.yaml | 50 ++++++++++++
3 files changed, 126 insertions(+), 63 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/max1363.txt b/Documentation/devicetree/bindings/iio/adc/max1363.txt
deleted file mode 100644
index 94a9011dd860..000000000000
--- a/Documentation/devicetree/bindings/iio/adc/max1363.txt
+++ /dev/null
@@ -1,63 +0,0 @@
-* Maxim 1x3x/136x/116xx Analog to Digital Converter (ADC)
-
-The node for this driver must be a child node of a I2C controller, hence
-all mandatory properties for your controller must be specified. See directory:
-
- Documentation/devicetree/bindings/i2c
-
-for more details.
-
-Required properties:
- - compatible: Should be one of
- "maxim,max1361"
- "maxim,max1362"
- "maxim,max1363"
- "maxim,max1364"
- "maxim,max1036"
- "maxim,max1037"
- "maxim,max1038"
- "maxim,max1039"
- "maxim,max1136"
- "maxim,max1137"
- "maxim,max1138"
- "maxim,max1139"
- "maxim,max1236"
- "maxim,max1237"
- "maxim,max1238"
- "maxim,max1239"
- "maxim,max11600"
- "maxim,max11601"
- "maxim,max11602"
- "maxim,max11603"
- "maxim,max11604"
- "maxim,max11605"
- "maxim,max11606"
- "maxim,max11607"
- "maxim,max11608"
- "maxim,max11609"
- "maxim,max11610"
- "maxim,max11611"
- "maxim,max11612"
- "maxim,max11613"
- "maxim,max11614"
- "maxim,max11615"
- "maxim,max11616"
- "maxim,max11617"
- "maxim,max11644"
- "maxim,max11645"
- "maxim,max11646"
- "maxim,max11647"
- - reg: Should contain the ADC I2C address
-
-Optional properties:
- - vcc-supply: phandle to the regulator that provides power to the ADC.
- - vref-supply: phandle to the regulator for ADC reference voltage.
- - interrupts: IRQ line for the ADC. If not used the driver will use
- polling.
-
-Example:
-adc: max11644@36 {
- compatible = "maxim,max11644";
- reg = <0x36>;
- vref-supply = <&adc_vref>;
-};
diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
new file mode 100644
index 000000000000..a0ebb4680140
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1238.yaml
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/maxim,max1238.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX1238 and similar ADCs
+
+maintainers:
+ - Jonathan Cameron <jic23@kernel.org>
+
+description: |
+ Family of simple ADCs with i2c inteface and internal references.
+
+properties:
+ compatible:
+ enum:
+ - maxim,max1036
+ - maxim,max1037
+ - maxim,max1038
+ - maxim,max1039
+ - maxim,max1136
+ - maxim,max1137
+ - maxim,max1138
+ - maxim,max1139
+ - maxim,max1236
+ - maxim,max1237
+ - maxim,max1238
+ - maxim,max1239
+ - maxim,max11600
+ - maxim,max11601
+ - maxim,max11602
+ - maxim,max11603
+ - maxim,max11604
+ - maxim,max11605
+ - maxim,max11606
+ - maxim,max11607
+ - maxim,max11608
+ - maxim,max11609
+ - maxim,max11610
+ - maxim,max11611
+ - maxim,max11612
+ - maxim,max11613
+ - maxim,max11614
+ - maxim,max11615
+ - maxim,max11616
+ - maxim,max11617
+ - maxim,max11644
+ - maxim,max11645
+ - maxim,max11646
+ - maxim,max11647
+
+ reg:
+ maxItems: 1
+
+ vcc-supply: true
+ vref-supply:
+ description: Optional external reference. If not supplied, internal
+ reference will be used.
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ adc@36 {
+ compatible = "maxim,max1238";
+ reg = <0x36>;
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1363.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1363.yaml
new file mode 100644
index 000000000000..01706b4ccb1a
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1363.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/maxim,max1363.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX1363 and similar ADCs
+
+maintainers:
+ - Jonathan Cameron <jic23@kernel.org>
+
+description: |
+ Family of ADCs with i2c inteface, internal references and threshold
+ monitoring.
+
+properties:
+ compatible:
+ enum:
+ - maxim,max1361,
+ - maxim,max1362
+ - maxim,max1363
+ - maxim,max1364
+
+ reg:
+ maxItems: 1
+
+ vcc-supply: true
+ vref-supply:
+ description: Optional external reference. If not supplied, internal
+ reference will be used.
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ adc@36 {
+ compatible = "maxim,max1363";
+ reg = <0x36>;
+ };
+ };
+...
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: max1363 etc i2c ADC binding conversion
2020-02-08 17:23 [PATCH] dt-bindings: iio: adc: max1363 etc i2c ADC binding conversion jic23
@ 2020-02-19 22:10 ` Rob Herring
2020-02-21 10:04 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2020-02-19 22:10 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Mark Rutland, devicetree, Jonathan Cameron
On Sat, Feb 08, 2020 at 05:23:12PM +0000, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Split the binding in two to reflect the threshold monitor capabilities
> and hence interrupts vs the more straight forward parts that
> don't have this facility.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> .../devicetree/bindings/iio/adc/max1363.txt | 63 ---------------
> .../bindings/iio/adc/maxim,max1238.yaml | 76 +++++++++++++++++++
> .../bindings/iio/adc/maxim,max1363.yaml | 50 ++++++++++++
> 3 files changed, 126 insertions(+), 63 deletions(-)
> +properties:
> + compatible:
> + enum:
> + - maxim,max1361,
Dangling comma.
Otherwise,
Reviewed-by: Rob Herring <robh@kernel.org>
> + - maxim,max1362
> + - maxim,max1363
> + - maxim,max1364
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: max1363 etc i2c ADC binding conversion
2020-02-19 22:10 ` Rob Herring
@ 2020-02-21 10:04 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2020-02-21 10:04 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-iio, Mark Rutland, devicetree, Jonathan Cameron
On Wed, 19 Feb 2020 16:10:05 -0600
Rob Herring <robh@kernel.org> wrote:
> On Sat, Feb 08, 2020 at 05:23:12PM +0000, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Split the binding in two to reflect the threshold monitor capabilities
> > and hence interrupts vs the more straight forward parts that
> > don't have this facility.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> > .../devicetree/bindings/iio/adc/max1363.txt | 63 ---------------
> > .../bindings/iio/adc/maxim,max1238.yaml | 76 +++++++++++++++++++
> > .../bindings/iio/adc/maxim,max1363.yaml | 50 ++++++++++++
> > 3 files changed, 126 insertions(+), 63 deletions(-)
>
> > +properties:
> > + compatible:
> > + enum:
> > + - maxim,max1361,
>
> Dangling comma.
>
> Otherwise,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Fixed up and applied. Thanks Rob
Jonathan
>
> > + - maxim,max1362
> > + - maxim,max1363
> > + - maxim,max1364
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-21 10:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-08 17:23 [PATCH] dt-bindings: iio: adc: max1363 etc i2c ADC binding conversion jic23
2020-02-19 22:10 ` Rob Herring
2020-02-21 10:04 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).