From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED8DC10DCE for ; Sun, 15 Mar 2020 10:06:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66B38206E9 for ; Sun, 15 Mar 2020 10:06:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584266795; bh=vLy7KSZmz7PdWZGTh9eRpmvzVkl2ZG0ksatGvfcrcxI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=X2P8JyDht+qROx5ZriIpfnmAupHtXOWxCEmyrphU0gMCplO+2bLEjoSa2WIbzh0j9 enSdDA2cn1J9C0TB9lDGhN6RTmXl/MFk652oPC2AS6sC8FKIVQIWhR28utlIMDsrd3 5mzlzuxnYsNJz7hiUW3xmRp6Ou+MsYnc86/3Rirw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728148AbgCOKGf (ORCPT ); Sun, 15 Mar 2020 06:06:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:46804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728141AbgCOKGe (ORCPT ); Sun, 15 Mar 2020 06:06:34 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45B9920575; Sun, 15 Mar 2020 10:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584266793; bh=vLy7KSZmz7PdWZGTh9eRpmvzVkl2ZG0ksatGvfcrcxI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vNFqH71kTdb15r8JTMWA4odNeqOrrhYhY4h/unG0YGuLnsllflNVbsAD3BMnHHsp0 NvXXl5VRLHDsVii2TO7vDu4ZsTrC75gu3dfmxMaIg2KZAJMoPFqBZSUYGAMlMzIOiA VVioG9chbszGO4J0EYOwSJGqt8vxGdZBB1CBt2SI= Date: Sun, 15 Mar 2020 10:06:28 +0000 From: Jonathan Cameron To: BOUGH CHEN Cc: "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-iio@vger.kernel.org" Subject: Re: [PATCH] iio: adc: Add imx8qxp adc driver support Message-ID: <20200315100628.2f9e824c@archlinux> In-Reply-To: References: <1581413555-31743-1-git-send-email-haibo.chen@nxp.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 10 Mar 2020 01:59:57 +0000 BOUGH CHEN wrote: > Ping... I'm guessing you didn't get the reply for some reason: https://patchwork.kernel.org/patch/11375113/ >=20 >=20 > > -----Original Message----- > > From: haibo.chen@nxp.com > > Sent: 2020=E5=B9=B42=E6=9C=8811=E6=97=A5 17:33 > > To: jic23@kernel.org; knaack.h@gmx.de; lars@metafoo.de; > > pmeerw@pmeerw.net; shawnguo@kernel.org; s.hauer@pengutronix.de; > > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx > > ; linux-iio@vger.kernel.org > > Cc: BOUGH CHEN > > Subject: [PATCH] iio: adc: Add imx8qxp adc driver support > >=20 > > From: Haibo Chen > >=20 > > i.MX8QXP B0 and i.MX8QM has the same ADC IP, so add the adc driver to > > support it. > >=20 > > Signed-off-by: Haibo Chen > > --- > > drivers/iio/adc/Kconfig | 10 + > > drivers/iio/adc/Makefile | 1 + > > drivers/iio/adc/imx8qxp_adc.c | 723 > > ++++++++++++++++++++++++++++++++++ > > 3 files changed, 734 insertions(+) > > create mode 100644 drivers/iio/adc/imx8qxp_adc.c > >=20 > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index > > 82e33082958c..10329fe5d8d4 100644 > > --- a/drivers/iio/adc/Kconfig > > +++ b/drivers/iio/adc/Kconfig > > @@ -480,6 +480,16 @@ config IMX7D_ADC > > This driver can also be built as a module. If so, the module will be > > called imx7d_adc. > >=20 > > +config IMX8QXP_ADC > > + tristate "IMX8QXP ADC driver" > > + depends on ARCH_MXC || COMPILE_TEST > > + depends on HAS_IOMEM > > + help > > + Say yes here to build support for IMX8QXP ADC. > > + > > + This driver can also be built as a module. If so, the module will be > > + called imx8qxp_adc. > > + > > config LP8788_ADC > > tristate "LP8788 ADC driver" > > depends on MFD_LP8788 > > diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile index > > 919228900df9..480f76b628ca 100644 > > --- a/drivers/iio/adc/Makefile > > +++ b/drivers/iio/adc/Makefile > > @@ -43,6 +43,7 @@ obj-$(CONFIG_FSL_MX25_ADC) +=3D fsl-imx25-gcq.o > > obj-$(CONFIG_HI8435) +=3D hi8435.o > > obj-$(CONFIG_HX711) +=3D hx711.o > > obj-$(CONFIG_IMX7D_ADC) +=3D imx7d_adc.o > > +obj-$(CONFIG_IMX8QXP_ADC) +=3D imx8qxp_adc.o > > obj-$(CONFIG_INA2XX_ADC) +=3D ina2xx-adc.o > > obj-$(CONFIG_INGENIC_ADC) +=3D ingenic-adc.o > > obj-$(CONFIG_INTEL_MRFLD_ADC) +=3D intel_mrfld_adc.o diff --git > > a/drivers/iio/adc/imx8qxp_adc.c b/drivers/iio/adc/imx8qxp_adc.c new file > > mode 100644 index 000000000000..a6a9c42d08cd > > --- /dev/null > > +++ b/drivers/iio/adc/imx8qxp_adc.c > > @@ -0,0 +1,723 @@ > > +/* > > + * NXP i.MX8QXP ADC driver > > + * > > + * Copyright (C) 2018 NXP > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by > > + * the Free Software Foundation; either version 2 of the License, or > > + * (at your option) any later version. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > + > > +/* ADC register */ > > +#define IMX8QXP_REG_ADC_VERID 0x00 > > +#define IMX8QXP_REG_ADC_PARAM 0x04 > > +#define IMX8QXP_REG_ADC_CTRL 0x10 > > +#define IMX8QXP_REG_ADC_STAT 0x14 > > +#define IMX8QXP_REG_ADC_IE 0x18 > > +#define IMX8QXP_REG_ADC_DE 0x1c > > +#define IMX8QXP_REG_ADC_CFG 0x20 > > +#define IMX8QXP_REG_ADC_PAUSE 0x24 > > +#define IMX8QXP_REG_ADC_FCTRL 0x30 > > +#define IMX8QXP_REG_ADC_SWTRIG 0x34 > > +#define IMX8QXP_REG_ADC_TCTRL0 0xc0 > > +#define IMX8QXP_REG_ADC_TCTRL1 0xc4 > > +#define IMX8QXP_REG_ADC_TCTRL2 0xc8 > > +#define IMX8QXP_REG_ADC_TCTRL3 0xcc > > +#define IMX8QXP_REG_ADC_TCTRL4 0xd0 > > +#define IMX8QXP_REG_ADC_TCTRL5 0xd4 > > +#define IMX8QXP_REG_ADC_TCTRL6 0xd8 > > +#define IMX8QXP_REG_ADC_TCTRL7 0xdc > > +#define IMX8QXP_REG_ADC_CMDL1 0x100 > > +#define IMX8QXP_REG_ADC_CMDH1 0x104 > > +#define IMX8QXP_REG_ADC_CMDL2 0x108 > > +#define IMX8QXP_REG_ADC_CMDH2 0x10c > > +#define IMX8QXP_REG_ADC_CMDL3 0x110 > > +#define IMX8QXP_REG_ADC_CMDH3 0x114 > > +#define IMX8QXP_REG_ADC_CMDL4 0x118 > > +#define IMX8QXP_REG_ADC_CMDH4 0x11c > > +#define IMX8QXP_REG_ADC_CMDL5 0x120 > > +#define IMX8QXP_REG_ADC_CMDH5 0x124 > > +#define IMX8QXP_REG_ADC_CMDL6 0x128 > > +#define IMX8QXP_REG_ADC_CMDH6 0x12c > > +#define IMX8QXP_REG_ADC_CMDL7 0x130 > > +#define IMX8QXP_REG_ADC_CMDH7 0x134 > > +#define IMX8QXP_REG_ADC_CMDL8 0x138 > > +#define IMX8QXP_REG_ADC_CMDH8 0x13c > > +#define IMX8QXP_REG_ADC_CV1 0x200 > > +#define IMX8QXP_REG_ADC_CV2 0x204 > > +#define IMX8QXP_REG_ADC_CV3 0x208 > > +#define IMX8QXP_REG_ADC_CV4 0x20c > > +#define IMX8QXP_REG_ADC_RESFIFO 0x300 > > +#define IMX8QXP_REG_ADC_TST 0xffc > > + > > +/* ADC IE bit shift */ > > +#define IMX8QXP_REG_ADC_IE_FOFIE_SHIFT (1) > > +#define IMX8QXP_REG_ADC_IE_FWMIE_SHIFT (0) > > +/* ADC CTRL bit shift*/ > > +#define IMX8QXP_REG_ADC_CTRL_FIFO_RESET_SHIFT (8) > > +#define IMX8QXP_REG_ADC_CTRL_SOFTWARE_RESET_SHIFT (1) > > +#define IMX8QXP_REG_ADC_CTRL_ADC_ENABLE (0) > > +/* ADC TCTRL bit shift*/ > > +#define IMX8QXP_REG_ADC_TCTRL_TCMD_SHIFT (24) > > +#define IMX8QXP_REG_ADC_TCTRL_TDLY_SHIFT (16) > > +#define IMX8QXP_REG_ADC_TCTRL_TPRI_SHIFT (8) > > +#define IMX8QXP_REG_ADC_TCTRL_HTEN_SHIFT (0) > > +/* ADC CMDL bit shift*/ > > +#define IMX8QXP_REG_ADC_CMDL_CSCALE_SHIFT (8) > > +#define IMX8QXP_REG_ADC_CMDL_MODE_SHIFT (7) > > +#define IMX8QXP_REG_ADC_CMDL_DIFF_SHIFT (6) > > +#define IMX8QXP_REG_ADC_CMDL_ABSEL_SHIFT (5) > > +#define IMX8QXP_REG_ADC_CMDL_ADCH_SHIFT (0) > > +/* ADC CMDH bit shift*/ > > +#define IMX8QXP_REG_ADC_CMDH_NEXT_SHIFT (24) > > +#define IMX8QXP_REG_ADC_CMDH_LOOP_SHIFT (16) > > +#define IMX8QXP_REG_ADC_CMDH_AVGS_SHIFT (12) > > +#define IMX8QXP_REG_ADC_CMDH_STS_SHIFT (8) > > +#define IMX8QXP_REG_ADC_CMDH_LWI_SHIFT (7) > > +#define IMX8QXP_REG_ADC_CMDH_CMPEN_SHIFT (0) > > +/* ADC CFG bit shift*/ > > +#define IMX8QXP_REG_ADC_CFG_PWREN_SHIFT (28) > > +#define IMX8QXP_REG_ADC_CFG_PUDLY_SHIFT (16) > > +#define IMX8QXP_REG_ADC_CFG_REFSEL_SHIFT (6) > > +#define IMX8QXP_REG_ADC_CFG_PWRSEL_SHIFT (4) > > +#define IMX8QXP_REG_ADC_CFG_TPRICTRL_SHIFT (0) > > +/* ADC FCTRL bit shift*/ > > +#define IMX8QXP_ADC_FCTRL_FWMARK_SHIFT (16) > > +#define IMX8QXP_ADC_FCTRL_FWMARK_MASK (0x1f << 16) > > +#define IMX8QXP_ADC_FCTRL_FCOUNT_MASK (0x1f) > > +/* ADC STAT bit shift*/ > > +#define IMX8QXP_REG_ADC_STAT_CMDACT_SHIFT (24) > > +#define IMX8QXP_REG_ADC_STAT_TRGACT_SHIFT (16) > > +#define IMX8QXP_REG_ADC_STAT_FOF_SHIFT (1) > > +#define IMX8QXP_REG_ADC_STAT_RDY_SHIFT (0) > > + > > +/* ADC CMD PARAMETER*/ > > +#define IMX8QXP_REG_ADC_CMDL_CNANNEL_SCALE_DOWN (0) > > +#define IMX8QXP_REG_ADC_CMDL_CHANNEL_SCALE_FULL (0x3f) > > +#define IMX8QXP_REG_ADC_CMDL_SEL_A_A_B_CHANNEL (0) > > +#define IMX8QXP_REG_ADC_CMDL_SEL_B_B_A_CHANNEL (1) > > +#define IMX8QXP_REG_ADC_CMDL_STANDARD_RESOLUTION (0) > > +#define IMX8QXP_REG_ADC_CMDL_HIGH_RESOLUTION (1) > > +#define IMX8QXP_REG_ADC_CMDL_MODE_SINGLE (0) > > +#define IMX8QXP_REG_ADC_CMDL_MODE_DIFF (1) > > + > > +#define IMX8QXP_REG_ADC_CMDH_LWI_INCREMENT_ENABLE (1) > > +#define IMX8QXP_REG_ADC_CMDH_LWI_INCREMENT_DISABLE (0) > > +#define IMX8QXP_REG_ADC_CMDH_CMPEN_DISABLE (0) > > +#define IMX8QXP_REG_ADC_CMDH_CMPEN_ENABLE_TRUE (2) > > +#define IMX8QXP_REG_ADC_CMDH_CMPEN_ENABLE_UNTILE_TRUE (0x3) > > + > > +/* ADC PAUSE PARAMETER*/ > > +#define IMX8QXP_REG_ADC_PAUSE_ENABLE (0x80000000) > > +/* ADC TRIGGER PARAMETER*/ > > +#define IMX8QXP_REG_ADC_TCTRL_TPRI_PRIORITY_HIGH (0) > > +#define IMX8QXP_REG_ADC_TCTRL_TPRI_PRIORITY_LOW (1) > > + > > +#define IMX8QXP_REG_ADC_TCTRL_HTEN_HARDWARE_TIRGGER_DISABLE > > (0) > > +#define IMX8QXP_REG_ADC_TCTRC_HTEN_HARDWARE_TIRGGER_ENABLE > > (1) > > + > > +#define MAX_CMD (8) > > +#define MAX_TRIG (8) > > + > > +#define IMX8QXP_ADC_TIMEOUT msecs_to_jiffies(100) > > + > > +struct imx8qxp_adc_trigger_ctrl { > > + u32 tcmd; > > + u32 tdly; > > + u32 tpri; > > + u32 hten; > > +}; > > + > > +struct imx8qxp_adc_cmd_l { > > + u32 scale; > > + u32 mode; > > + u32 diff; > > + u32 absel; > > + u32 adch; > > +}; > > + > > +struct imx8qxp_adc_cmd_h { > > + u32 next; > > + u32 loop; > > + u32 avgs; > > + u32 sts; > > + u32 lwi; > > + u32 cmpen; > > +}; > > + > > +struct imx8qxp_adc_cfg { > > + u32 pwren; > > + u32 pudly; > > + u32 refsel; > > + u32 pwrsel; > > + u32 tprictrl; > > +}; > > + > > +struct imx8qxp_adc { > > + struct device *dev; > > + void __iomem *regs; > > + struct clk *clk; > > + struct clk *ipg_clk; > > + > > + u32 vref_uv; > > + u32 value; > > + u32 channel_id; > > + u32 trigger_id; > > + u32 cmd_id; > > + > > + struct regulator *vref; > > + struct imx8qxp_adc_cmd_l adc_cmd_l[MAX_CMD + 1]; > > + struct imx8qxp_adc_cmd_h adc_cmd_h[MAX_CMD + 1]; > > + struct imx8qxp_adc_trigger_ctrl adc_trigger_ctrl[MAX_TRIG + 1]; > > + struct imx8qxp_adc_cfg adc_cfg; > > + struct completion completion; > > +}; > > + > > +#define IMX8QXP_ADC_CHAN(_idx) { \ > > + .type =3D IIO_VOLTAGE, \ > > + .indexed =3D 1, \ > > + .channel =3D (_idx), \ > > + .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW), \ > > + .info_mask_shared_by_type =3D BIT(IIO_CHAN_INFO_SCALE) | \ > > + BIT(IIO_CHAN_INFO_SAMP_FREQ), \ > > +} > > + > > +static const struct iio_chan_spec imx8qxp_adc_iio_channels[] =3D { > > + IMX8QXP_ADC_CHAN(0), > > + IMX8QXP_ADC_CHAN(1), > > + IMX8QXP_ADC_CHAN(2), > > + IMX8QXP_ADC_CHAN(3), > > + IMX8QXP_ADC_CHAN(4), > > + IMX8QXP_ADC_CHAN(5), > > + IMX8QXP_ADC_CHAN(6), > > + IMX8QXP_ADC_CHAN(7), > > +}; > > + > > +static void imx8qxp_adc_feature_prepare(struct imx8qxp_adc *adc) { > > + u32 i; > > + > > + adc->trigger_id =3D 0; > > + adc->cmd_id =3D 0; > > + adc->channel_id =3D 0; > > + > > + for (i =3D 0; i < MAX_CMD + 1; i++) { > > + adc->adc_cmd_l[i].scale =3D 1; > > + adc->adc_cmd_l[i].mode =3D 0; > > + adc->adc_cmd_l[i].diff =3D 0; > > + adc->adc_cmd_l[i].absel =3D 0; > > + adc->adc_cmd_l[i].adch =3D 0; > > + adc->adc_cmd_h[i].next =3D 0; > > + adc->adc_cmd_h[i].loop =3D 0; > > + adc->adc_cmd_h[i].avgs =3D 0; > > + adc->adc_cmd_h[i].sts =3D 0; > > + adc->adc_cmd_h[i].lwi =3D 0; > > + adc->adc_cmd_h[i].cmpen =3D 0; > > + } > > + > > + for (i =3D 0; i < MAX_TRIG; i++) { > > + adc->adc_trigger_ctrl[i].tcmd =3D 0; > > + adc->adc_trigger_ctrl[i].tdly =3D 0; > > + adc->adc_trigger_ctrl[i].tpri =3D 0; > > + adc->adc_trigger_ctrl[i].hten =3D 0; > > + } > > + > > + adc->adc_cfg.pwren =3D 0; > > + adc->adc_cfg.pudly =3D 0; > > + adc->adc_cfg.refsel =3D 0; > > + adc->adc_cfg.pwrsel =3D 0; > > + adc->adc_cfg.tprictrl =3D 0; > > +} > > + > > +static void imx8qxp_adc_reset(struct imx8qxp_adc *adc) { > > + u32 ctrl; > > + > > + /*software reset, need to clear the set bit*/ > > + ctrl =3D readl(adc->regs + IMX8QXP_REG_ADC_CTRL); > > + ctrl |=3D 1 << IMX8QXP_REG_ADC_CTRL_SOFTWARE_RESET_SHIFT; > > + writel(ctrl, adc->regs + IMX8QXP_REG_ADC_CTRL); > > + udelay(10); > > + ctrl &=3D ~(1 << IMX8QXP_REG_ADC_CTRL_SOFTWARE_RESET_SHIFT); > > + writel(ctrl, adc->regs + IMX8QXP_REG_ADC_CTRL); > > + > > + /* reset the fifo */ > > + ctrl |=3D 1 << IMX8QXP_REG_ADC_CTRL_FIFO_RESET_SHIFT; > > + writel(ctrl, adc->regs + IMX8QXP_REG_ADC_CTRL); } > > + > > +static void imx8qxp_adc_reg_config(struct imx8qxp_adc *adc) { > > + u32 adc_cfg, adc_tctrl, adc_cmdl, adc_cmdh; > > + u32 t_id, c_id; > > + > > + adc_cfg =3D adc->adc_cfg.pwren << > > IMX8QXP_REG_ADC_CFG_PWREN_SHIFT > > + | adc->adc_cfg.pudly << > > IMX8QXP_REG_ADC_CFG_PUDLY_SHIFT > > + | adc->adc_cfg.refsel << > > IMX8QXP_REG_ADC_CFG_REFSEL_SHIFT > > + | adc->adc_cfg.pwrsel << > > IMX8QXP_REG_ADC_CFG_PWRSEL_SHIFT > > + | adc->adc_cfg.tprictrl << > > IMX8QXP_REG_ADC_CFG_TPRICTRL_SHIFT; > > + writel(adc_cfg, adc->regs + IMX8QXP_REG_ADC_CFG); > > + > > + t_id =3D adc->trigger_id; > > + adc_tctrl =3D adc->adc_trigger_ctrl[t_id].tcmd << > > IMX8QXP_REG_ADC_TCTRL_TCMD_SHIFT > > + | adc->adc_trigger_ctrl[t_id].tdly << > > IMX8QXP_REG_ADC_TCTRL_TDLY_SHIFT > > + | adc->adc_trigger_ctrl[t_id].tpri << > > IMX8QXP_REG_ADC_TCTRL_TPRI_SHIFT > > + | adc->adc_trigger_ctrl[t_id].hten << > > IMX8QXP_REG_ADC_TCTRL_HTEN_SHIFT; > > + writel(adc_tctrl, adc->regs + IMX8QXP_REG_ADC_TCTRL0 + t_id * 4); > > + > > + c_id =3D adc->cmd_id - 1; > > + adc_cmdl =3D adc->adc_cmd_l[c_id].scale << > > IMX8QXP_REG_ADC_CMDL_CSCALE_SHIFT > > + | adc->adc_cmd_l[c_id].mode << > > IMX8QXP_REG_ADC_CMDL_MODE_SHIFT > > + | adc->adc_cmd_l[c_id].diff << > > IMX8QXP_REG_ADC_CMDL_DIFF_SHIFT > > + | adc->adc_cmd_l[c_id].absel << > > IMX8QXP_REG_ADC_CMDL_ABSEL_SHIFT > > + | adc->adc_cmd_l[c_id].adch << > > IMX8QXP_REG_ADC_CMDL_ADCH_SHIFT; > > + writel(adc_cmdl, adc->regs + IMX8QXP_REG_ADC_CMDL1 + c_id * 8); > > + > > + adc_cmdh =3D adc->adc_cmd_h[c_id].next << > > IMX8QXP_REG_ADC_CMDH_NEXT_SHIFT > > + | adc->adc_cmd_h[c_id].loop << > > IMX8QXP_REG_ADC_CMDH_LOOP_SHIFT > > + | adc->adc_cmd_h[c_id].avgs << > > IMX8QXP_REG_ADC_CMDH_AVGS_SHIFT > > + | adc->adc_cmd_h[c_id].sts << > > IMX8QXP_REG_ADC_CMDH_STS_SHIFT > > + | adc->adc_cmd_h[c_id].lwi << > > IMX8QXP_REG_ADC_CMDH_LWI_SHIFT > > + | adc->adc_cmd_h[c_id].cmpen << > > IMX8QXP_REG_ADC_CMDH_CMPEN_SHIFT; > > + writel(adc_cmdh, adc->regs + IMX8QXP_REG_ADC_CMDH1 + c_id * 8); } > > + > > +static void imx8qxp_adc_mode_config(struct imx8qxp_adc *adc) { > > + u32 cmd_id, trigger_id, channel_id; > > + > > + channel_id =3D adc->channel_id; > > + cmd_id =3D adc->cmd_id - 1; > > + trigger_id =3D adc->trigger_id; > > + > > + /* config the cmd */ > > + adc->adc_cmd_l[cmd_id].scale =3D > > IMX8QXP_REG_ADC_CMDL_CHANNEL_SCALE_FULL; > > + adc->adc_cmd_l[cmd_id].mode =3D > > IMX8QXP_REG_ADC_CMDL_STANDARD_RESOLUTION; > > + adc->adc_cmd_l[cmd_id].diff =3D > > IMX8QXP_REG_ADC_CMDL_MODE_SINGLE; > > + adc->adc_cmd_l[cmd_id].absel =3D > > IMX8QXP_REG_ADC_CMDL_SEL_A_A_B_CHANNEL; > > + adc->adc_cmd_l[cmd_id].adch =3D channel_id; > > + > > + adc->adc_cmd_h[cmd_id].next =3D 0; > > + adc->adc_cmd_h[cmd_id].loop =3D 0; > > + adc->adc_cmd_h[cmd_id].avgs =3D 7; // 128 times conversion > > + adc->adc_cmd_h[cmd_id].sts =3D 0; > > + adc->adc_cmd_h[cmd_id].lwi =3D > > IMX8QXP_REG_ADC_CMDH_LWI_INCREMENT_DISABLE; > > + adc->adc_cmd_h[cmd_id].cmpen =3D > > IMX8QXP_REG_ADC_CMDH_CMPEN_DISABLE; > > + > > + /* config the trigger control */ > > + adc->adc_trigger_ctrl[trigger_id].tcmd =3D adc->cmd_id; //point to > > cmd1 > > + adc->adc_trigger_ctrl[trigger_id].tdly =3D 0; > > + adc->adc_trigger_ctrl[trigger_id].tpri =3D > > IMX8QXP_REG_ADC_TCTRL_TPRI_PRIORITY_HIGH; > > + adc->adc_trigger_ctrl[trigger_id].hten =3D > > +IMX8QXP_REG_ADC_TCTRL_HTEN_HARDWARE_TIRGGER_DISABLE; > > + > > + /* ADC configuration */ > > + adc->adc_cfg.pwren =3D 1; > > + adc->adc_cfg.pudly =3D 0x80; > > + adc->adc_cfg.refsel =3D 0; > > + adc->adc_cfg.pwrsel =3D 3; > > + adc->adc_cfg.tprictrl =3D 0; > > + > > + imx8qxp_adc_reg_config(adc); > > +} > > + > > +static void imx8qxp_adc_fifo_config(struct imx8qxp_adc *adc) { > > + u32 fifo_ctrl, interrupt_en; > > + > > + fifo_ctrl =3D readl(adc->regs + IMX8QXP_REG_ADC_FCTRL); > > + fifo_ctrl &=3D ~IMX8QXP_ADC_FCTRL_FWMARK_MASK; > > + /* set the watermark level to 1 */ > > + fifo_ctrl |=3D 0 << IMX8QXP_ADC_FCTRL_FWMARK_SHIFT; > > + writel(fifo_ctrl, adc->regs + IMX8QXP_REG_ADC_FCTRL); > > + > > + /* FIFO Watermark Interrupt Enable */ > > + interrupt_en =3D readl(adc->regs + IMX8QXP_REG_ADC_IE); > > + interrupt_en |=3D 1 << IMX8QXP_REG_ADC_IE_FWMIE_SHIFT; > > + writel(interrupt_en, adc->regs + IMX8QXP_REG_ADC_IE); } > > + > > +static void imx8qxp_adc_disable(struct imx8qxp_adc *adc) { > > + u32 ctrl; > > + > > + ctrl =3D readl(adc->regs + IMX8QXP_REG_ADC_CTRL); > > + ctrl &=3D ~(1 << IMX8QXP_REG_ADC_CTRL_ADC_ENABLE); > > + writel(ctrl, adc->regs + IMX8QXP_REG_ADC_CTRL); } > > + > > +static void imx8qxp_adc_enable(struct imx8qxp_adc *adc) { > > + u32 ctrl; > > + > > + ctrl =3D readl(adc->regs + IMX8QXP_REG_ADC_CTRL); > > + ctrl |=3D 1 << IMX8QXP_REG_ADC_CTRL_ADC_ENABLE; > > + writel(ctrl, adc->regs + IMX8QXP_REG_ADC_CTRL); > > + > > +} > > + > > +static void imx8qxp_adc_start_trigger(struct imx8qxp_adc *adc) { > > + writel(1 << adc->trigger_id, adc->regs + > > IMX8QXP_REG_ADC_SWTRIG); } > > + > > +static u32 imx8qxp_adc_get_sample_rate(struct imx8qxp_adc *adc) { > > + > > + u32 input_clk; > > + > > + input_clk =3D clk_get_rate(adc->clk); > > + > > + return input_clk / 3; > > +} > > + > > +static int imx8qxp_adc_read_raw(struct iio_dev *indio_dev, > > + struct iio_chan_spec const *chan, > > + int *val, > > + int *val2, > > + long mask) > > +{ > > + > > + struct imx8qxp_adc *adc =3D iio_priv(indio_dev); > > + > > + u32 channel; > > + long ret; > > + > > + switch (mask) { > > + case IIO_CHAN_INFO_RAW: > > + pm_runtime_get_sync(adc->dev); > > + > > + mutex_lock(&indio_dev->mlock); > > + reinit_completion(&adc->completion); > > + > > + channel =3D chan->channel & 0x07; > > + adc->channel_id =3D channel; > > + adc->cmd_id =3D 1; > > + adc->trigger_id =3D 0; > > + imx8qxp_adc_mode_config(adc); > > + > > + imx8qxp_adc_fifo_config(adc); > > + > > + imx8qxp_adc_enable(adc); > > + > > + imx8qxp_adc_start_trigger(adc); > > + > > + ret =3D wait_for_completion_interruptible_timeout > > + (&adc->completion, IMX8QXP_ADC_TIMEOUT); > > + > > + pm_runtime_mark_last_busy(adc->dev); > > + pm_runtime_put_sync_autosuspend(adc->dev); > > + > > + if (ret =3D=3D 0) { > > + mutex_unlock(&indio_dev->mlock); > > + return -ETIMEDOUT; > > + } > > + if (ret < 0) { > > + mutex_unlock(&indio_dev->mlock); > > + return ret; > > + } > > + > > + *val =3D adc->value; > > + mutex_unlock(&indio_dev->mlock); > > + return IIO_VAL_INT; > > + > > + case IIO_CHAN_INFO_SCALE: > > + adc->vref_uv =3D regulator_get_voltage(adc->vref); > > + *val =3D adc->vref_uv / 1000; > > + *val2 =3D 12; > > + return IIO_VAL_FRACTIONAL_LOG2; > > + > > + case IIO_CHAN_INFO_SAMP_FREQ: > > + *val =3D imx8qxp_adc_get_sample_rate(adc); > > + return IIO_VAL_INT; > > + > > + default: > > + return -EINVAL; > > + } > > +} > > + > > +static int imx8qxp_adc_read_data(struct imx8qxp_adc *adc) { > > + u32 value; > > + > > + value =3D readl(adc->regs + IMX8QXP_REG_ADC_RESFIFO); > > + value &=3D 0xffff; > > + return (value >> 3); > > +} > > + > > +static irqreturn_t imx8qxp_adc_isr(int irq, void *dev_id) { > > + struct imx8qxp_adc *adc =3D (struct imx8qxp_adc *)dev_id; > > + > > + u32 fifo_count; > > + > > + fifo_count =3D readl(adc->regs + IMX8QXP_REG_ADC_FCTRL) > > + & IMX8QXP_ADC_FCTRL_FCOUNT_MASK; > > + > > + if (fifo_count) { > > + adc->value =3D imx8qxp_adc_read_data(adc); > > + complete(&adc->completion); > > + } > > + > > + return IRQ_HANDLED; > > +} > > + > > +static int imx8qxp_adc_reg_access(struct iio_dev *indio_dev, > > + unsigned int reg, unsigned int writeval, > > + unsigned int *readval) > > +{ > > + struct imx8qxp_adc *adc =3D iio_priv(indio_dev); > > + > > + if (!readval || reg % 4 || reg > IMX8QXP_REG_ADC_TST) > > + return -EINVAL; > > + > > + pm_runtime_get_sync(adc->dev); > > + > > + *readval =3D readl(adc->regs + reg); > > + > > + pm_runtime_mark_last_busy(adc->dev); > > + pm_runtime_put_sync_autosuspend(adc->dev); > > + > > + return 0; > > +} > > + > > +static const struct iio_info imx8qxp_adc_iio_info =3D { > > + .read_raw =3D &imx8qxp_adc_read_raw, > > + .debugfs_reg_access =3D &imx8qxp_adc_reg_access, }; > > + > > +static const struct of_device_id imx8qxp_adc_match[] =3D { > > + { .compatible =3D "fsl,imx8qxp-adc", }, > > + { /* sentinel */ } > > +}; > > +MODULE_DEVICE_TABLE(of, imx8qxp_adc_match); > > + > > +static int imx8qxp_adc_probe(struct platform_device *pdev) { > > + struct imx8qxp_adc *adc; > > + struct iio_dev *indio_dev; > > + struct resource *mem; > > + int irq; > > + int ret; > > + > > + indio_dev =3D devm_iio_device_alloc(&pdev->dev, sizeof(*adc)); > > + if (!indio_dev) { > > + dev_err(&pdev->dev, "Failed allocating iio device\n"); > > + return -ENOMEM; > > + } > > + > > + adc =3D iio_priv(indio_dev); > > + adc->dev =3D &pdev->dev; > > + > > + mem =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + adc->regs =3D devm_ioremap_resource(&pdev->dev, mem); > > + if (IS_ERR(adc->regs)) { > > + ret =3D PTR_ERR(adc->regs); > > + dev_err(&pdev->dev, > > + "Failed to remap adc memory, err =3D %d\n", ret); > > + return ret; > > + } > > + > > + irq =3D platform_get_irq(pdev, 0); > > + if (irq < 0) { > > + dev_err(&pdev->dev, "No irq resource?\n"); > > + return irq; > > + } > > + > > + adc->clk =3D devm_clk_get(&pdev->dev, "per"); > > + if (IS_ERR(adc->clk)) { > > + ret =3D PTR_ERR(adc->clk); > > + dev_err(&pdev->dev, "Failed getting clock, err =3D %d\n", ret); > > + return ret; > > + } > > + > > + adc->ipg_clk =3D devm_clk_get(&pdev->dev, "ipg"); > > + if (IS_ERR(adc->ipg_clk)) { > > + ret =3D PTR_ERR(adc->ipg_clk); > > + dev_err(&pdev->dev, "Failed getting clock, err =3D %d\n", ret); > > + return ret; > > + } > > + > > + adc->vref =3D devm_regulator_get(&pdev->dev, "vref"); > > + if (IS_ERR(adc->vref)) { > > + ret =3D PTR_ERR(adc->vref); > > + dev_err(&pdev->dev, > > + "Failed getting reference voltage, err =3D %d\n", ret); > > + return ret; > > + } > > + > > + ret =3D regulator_enable(adc->vref); > > + if (ret) { > > + dev_err(&pdev->dev, > > + "Can't enable adc reference top voltage, err =3D %d\n", > > + ret); > > + return ret; > > + } > > + > > + platform_set_drvdata(pdev, indio_dev); > > + > > + init_completion(&adc->completion); > > + > > + indio_dev->name =3D dev_name(&pdev->dev); > > + indio_dev->dev.parent =3D &pdev->dev; > > + indio_dev->info =3D &imx8qxp_adc_iio_info; > > + indio_dev->modes =3D INDIO_DIRECT_MODE; > > + indio_dev->channels =3D imx8qxp_adc_iio_channels; > > + indio_dev->num_channels =3D ARRAY_SIZE(imx8qxp_adc_iio_channels); > > + > > + ret =3D clk_prepare_enable(adc->clk); > > + if (ret) { > > + dev_err(&pdev->dev, > > + "Could not prepare or enable the clock.\n"); > > + goto error_adc_clk_enable; > > + } > > + > > + ret =3D clk_prepare_enable(adc->ipg_clk); > > + if (ret) { > > + dev_err(&pdev->dev, > > + "Could not prepare or enable the clock.\n"); > > + goto error_adc_ipg_clk_enable; > > + } > > + > > + ret =3D devm_request_irq(adc->dev, irq, > > + imx8qxp_adc_isr, 0, > > + dev_name(&pdev->dev), adc); > > + if (ret < 0) { > > + dev_err(&pdev->dev, "Failed requesting irq, irq =3D %d\n", irq); > > + goto error_iio_device_register; > > + } > > + > > + imx8qxp_adc_feature_prepare(adc); > > + imx8qxp_adc_reset(adc); > > + > > + ret =3D iio_device_register(indio_dev); > > + if (ret) { > > + imx8qxp_adc_disable(adc); > > + dev_err(&pdev->dev, "Couldn't register the device.\n"); > > + goto error_iio_device_register; > > + } > > + > > + pm_runtime_set_active(&pdev->dev); > > + pm_runtime_set_autosuspend_delay(&pdev->dev, 50); > > + pm_runtime_use_autosuspend(&pdev->dev); > > + pm_runtime_enable(&pdev->dev); > > + > > + return 0; > > + > > +error_iio_device_register: > > + clk_disable_unprepare(adc->ipg_clk); > > +error_adc_ipg_clk_enable: > > + clk_disable_unprepare(adc->clk); > > +error_adc_clk_enable: > > + regulator_disable(adc->vref); > > + > > + return ret; > > +} > > + > > +static int imx8qxp_adc_remove(struct platform_device *pdev) { > > + struct iio_dev *indio_dev =3D platform_get_drvdata(pdev); > > + struct imx8qxp_adc *adc =3D iio_priv(indio_dev); > > + > > + pm_runtime_get_sync(&pdev->dev); > > + > > + iio_device_unregister(indio_dev); > > + > > + imx8qxp_adc_disable(adc); > > + > > + clk_disable_unprepare(adc->clk); > > + clk_disable_unprepare(adc->ipg_clk); > > + regulator_disable(adc->vref); > > + > > + pm_runtime_disable(&pdev->dev); > > + pm_runtime_put_noidle(&pdev->dev); > > + > > + > > + return 0; > > +} > > + > > +static int imx8qxp_adc_runtime_suspend(struct device *dev) { > > + struct iio_dev *indio_dev =3D dev_get_drvdata(dev); > > + struct imx8qxp_adc *adc =3D iio_priv(indio_dev); > > + > > + imx8qxp_adc_disable(adc); > > + > > + clk_disable_unprepare(adc->clk); > > + clk_disable_unprepare(adc->ipg_clk); > > + regulator_disable(adc->vref); > > + > > + return 0; > > +} > > + > > +static int imx8qxp_adc_runtime_resume(struct device *dev) { > > + struct iio_dev *indio_dev =3D dev_get_drvdata(dev); > > + struct imx8qxp_adc *adc =3D iio_priv(indio_dev); > > + int ret; > > + > > + ret =3D regulator_enable(adc->vref); > > + if (ret) { > > + dev_err(adc->dev, > > + "Can't enable adc reference top voltage, err =3D %d\n", > > + ret); > > + return ret; > > + } > > + > > + ret =3D clk_prepare_enable(adc->clk); > > + if (ret) { > > + dev_err(adc->dev, > > + "Could not prepare or enable clock.\n"); > > + regulator_disable(adc->vref); > > + return ret; > > + } > > + > > + ret =3D clk_prepare_enable(adc->ipg_clk); > > + if (ret) { > > + dev_err(adc->dev, > > + "Could not prepare or enable clock.\n"); > > + clk_disable_unprepare(adc->clk); > > + regulator_disable(adc->vref); > > + return ret; > > + } > > + imx8qxp_adc_reset(adc); > > + > > + return 0; > > +} > > + > > +static const struct dev_pm_ops imx8qxp_adc_pm_ops =3D { > > + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > > pm_runtime_force_resume) > > + SET_RUNTIME_PM_OPS(imx8qxp_adc_runtime_suspend, > > +imx8qxp_adc_runtime_resume, NULL) }; > > + > > +static struct platform_driver imx8qxp_adc_driver =3D { > > + .probe =3D imx8qxp_adc_probe, > > + .remove =3D imx8qxp_adc_remove, > > + .driver =3D { > > + .name =3D "imx8qxp_adc", > > + .of_match_table =3D imx8qxp_adc_match, > > + .pm =3D &imx8qxp_adc_pm_ops, > > + }, > > +}; > > + > > +module_platform_driver(imx8qxp_adc_driver); > > + > > +MODULE_AUTHOR("Haibo Chen "); > > +MODULE_DESCRIPTION("NXP IMX8QXP ADC driver"); > > MODULE_LICENSE("GPL v2"); > > -- > > 2.17.1 =20 >=20