From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A446C43331 for ; Tue, 24 Mar 2020 14:16:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18AA920788 for ; Tue, 24 Mar 2020 14:16:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=metafoo.de header.i=@metafoo.de header.b="RkSaO/7R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727219AbgCXOQx (ORCPT ); Tue, 24 Mar 2020 10:16:53 -0400 Received: from www381.your-server.de ([78.46.137.84]:40612 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726988AbgCXOQx (ORCPT ); Tue, 24 Mar 2020 10:16:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metafoo.de; s=default2002; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wTBFHS+Jk4fBHV3cIsPOdwS4G9d6edQADozpLSR69aE=; b=RkSaO/7R3AU1lyqqPZpmwTX4NQ q3jYq2AcZgsprolrFJv8+nzP2B0atPvfpvtxL39jO4HAYDhEFiJwIOUucnxiqPDG9eF/dvkszDTnW c0oBNBokjuubvgo/8WanXda2H9KvRevjR6PqojS2xmJO3IuyA/HDO7Pl59zxJqiy/FKw+iHKkY89K +XUPmLg+D3GfaxPJPdNO14gyPX4zpti0LkNx5KwTzzQcqIZYIN6VdmgQPlmF9DVT8xx5T2IzOBsc1 EPi1go7gdke+K207dMh/hvl8M/MwzBnKyheX10t7Z0o1gmab2KDZzN4/VVdi9RilvjP18EI3bo2wl S8hG7/Gg==; Received: from sslproxy06.your-server.de ([78.46.172.3]) by www381.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jGkMM-0005Nd-Oo; Tue, 24 Mar 2020 15:16:50 +0100 Received: from [82.135.78.113] (helo=lars-desktop.fritz.box) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jGkMM-000Uv9-Fp; Tue, 24 Mar 2020 15:16:50 +0100 From: Lars-Peter Clausen To: Jonathan Cameron Cc: Hartmut Knaack , Peter Meerwald-Stadler , Alexandru Ardelean , linux-iio@vger.kernel.org, Lars-Peter Clausen Subject: [PATCH] iio: dma-buffer: Cleanup buffer.h/buffer_impl.h includes Date: Tue, 24 Mar 2020 15:16:24 +0100 Message-Id: <20200324141624.30597-1-lars@metafoo.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Sender: lars@metafoo.de X-Virus-Scanned: Clear (ClamAV 0.102.2/25760/Mon Mar 23 14:12:45 2020) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The IIO DMA buffer is a DMA buffer implementation. As such it should include buffer_impl.h rather than buffer.h. The include to buffer.h in buffer-dma.h should be buffer_impl.h so it has access to the struct iio_buffer definition. The code currently only works because all places that use buffer-dma.h include buffer_impl.h before it. The include to buffer.h in industrialio-buffer-dma.c and industrialio-buffer-dmaengine.c can be removed since those files don't reference any of buffer consumer functions. Signed-off-by: Lars-Peter Clausen --- drivers/iio/buffer/industrialio-buffer-dma.c | 1 - drivers/iio/buffer/industrialio-buffer-dmaengine.c | 1 - include/linux/iio/buffer-dma.h | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/buffer/industrialio-buffer-dma.c b/drivers/iio/buffer/industrialio-buffer-dma.c index a74bd9c0587c..d348af8b9705 100644 --- a/drivers/iio/buffer/industrialio-buffer-dma.c +++ b/drivers/iio/buffer/industrialio-buffer-dma.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c index b129693af0fd..8b60dff527c8 100644 --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c @@ -14,7 +14,6 @@ #include #include -#include #include #include #include diff --git a/include/linux/iio/buffer-dma.h b/include/linux/iio/buffer-dma.h index 016d8a068353..ff15c61bf319 100644 --- a/include/linux/iio/buffer-dma.h +++ b/include/linux/iio/buffer-dma.h @@ -11,7 +11,7 @@ #include #include #include -#include +#include struct iio_dma_buffer_queue; struct iio_dma_buffer_ops; -- 2.20.1