From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E1DAC2D0E5 for ; Fri, 27 Mar 2020 13:17:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E33AB2082E for ; Fri, 27 Mar 2020 13:17:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726742AbgC0NRg (ORCPT ); Fri, 27 Mar 2020 09:17:36 -0400 Received: from mga02.intel.com ([134.134.136.20]:21831 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbgC0NRg (ORCPT ); Fri, 27 Mar 2020 09:17:36 -0400 IronPort-SDR: L3FMgNOVANyHEQQiPzXQhFrbkzFIQCjoWtIX2Qg8y4aH782rDqh01j72yvoIvk+LM+Ikdyrff1 kDfLyNJUXXXQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2020 06:17:33 -0700 IronPort-SDR: foPMD2FQZikaok3kV3miyDyHBAn9vtjKjrQOARBpQeXz1M1HoYXgX+pifcg3RUnnUJWKPYwPWZ kXueVak/Ae3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,312,1580803200"; d="scan'208";a="394373114" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004.jf.intel.com with ESMTP; 27 Mar 2020 06:17:31 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jHore-00DQJZ-2a; Fri, 27 Mar 2020 15:17:34 +0200 Date: Fri, 27 Mar 2020 15:17:34 +0200 From: Andy Shevchenko To: saravanan sekar Cc: Lee Jones , Rob Herring , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Sebastian Reichel , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM Subject: Re: [PATCH v4 2/5] mfd: mp2629: Add support for mps battery charger Message-ID: <20200327131734.GV1922688@smile.fi.intel.com> References: <20200322224626.13160-1-sravanhome@gmail.com> <20200322224626.13160-3-sravanhome@gmail.com> <20200327075541.GF603801@dell> <20200327102221.GA3383@dell> <20200327112523.GC3383@dell> <45f68c40-8e50-e0a2-a89a-b5a164d6b75c@gmail.com> <0f344b03-ce5e-4a31-5268-6db4266b352e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f344b03-ce5e-4a31-5268-6db4266b352e@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, Mar 27, 2020 at 02:03:30PM +0100, saravanan sekar wrote: > On 27/03/20 1:56 pm, Andy Shevchenko wrote: > > On Fri, Mar 27, 2020 at 2:41 PM saravanan sekar wrote: > > > On 27/03/20 12:25 pm, Lee Jones wrote: > > > > On Fri, 27 Mar 2020, saravanan sekar wrote: > > > > > On 27/03/20 11:22 am, Lee Jones wrote: > > > > So Andy has reviewed, but you still don't have him on Cc? > > > Sorry one of his hint made me removed him in CC unknowingly. > > > > > > "For the future, hint: > > > scripts/get_maintainer.pl --git --git-min-percent=67 ..." > > > > > Perhaps I have to elaborate. The above hint for the initial submit. > > Then the rule of thumb: Include reviewers into Cc (to the patches they > > have reviewed), because you can't know their intention and maybe they > > want to follow a development. > Thanks for more details. Between Lee has not recommended "forward > declarations", the review comment > you gave on my V1 patch (more info on previous email). Hope you agree with > the same. I think so. -- With Best Regards, Andy Shevchenko