From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC9DFC43331 for ; Fri, 27 Mar 2020 13:19:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A8C02082E for ; Fri, 27 Mar 2020 13:19:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbgC0NTD (ORCPT ); Fri, 27 Mar 2020 09:19:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:32691 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbgC0NTD (ORCPT ); Fri, 27 Mar 2020 09:19:03 -0400 IronPort-SDR: +K1pps45I3Zs/hCWkcqgX9M/NYKvB7izMsqlgluKb1J52nu8QDOOxr7JtIL4EiktRGY/jSOgx3 47frldgMQIng== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2020 06:19:02 -0700 IronPort-SDR: M0nlyFD0lihw3AO/+x8zICyCg/YldWDhWgfuj3Yx4tKTfwpwoROZ9YIsN4Iepai0BKGoonu4o3 IAuKPuodU7uQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,312,1580803200"; d="scan'208";a="241297355" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 27 Mar 2020 06:18:59 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jHot3-00DQKX-Vc; Fri, 27 Mar 2020 15:19:01 +0200 Date: Fri, 27 Mar 2020 15:19:01 +0200 From: Andy Shevchenko To: Rohit Sarkar Cc: linux-iio@vger.kernel.org, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jean-Baptiste Maneyrol , Linus Walleij , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: add debugfs register r/w interface Message-ID: <20200327131901.GW1922688@smile.fi.intel.com> References: <5e7dfb41.1c69fb81.cc4bb.042f@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e7dfb41.1c69fb81.cc4bb.042f@mx.google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, Mar 27, 2020 at 06:40:23PM +0530, Rohit Sarkar wrote: > The debugfs interface provides direct access to read and write device > registers if debugfs is enabled. > > Signed-off-by: Rohit Sarkar > --- > Changelog v1->v2 > * grab a lock to protect driver state > * add a comma at the end of structure member initialisation > > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > index 7cb9ff3d3e94..381a3fb09858 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > @@ -1248,12 +1248,31 @@ static const struct attribute_group inv_attribute_group = { > .attrs = inv_attributes > }; > > +static int inv_mpu6050_reg_access(struct iio_dev *indio_dev, > + unsigned int reg, > + unsigned int writeval, > + unsigned int *readval) > +{ > + struct inv_mpu6050_state *st = iio_priv(indio_dev); > + int ret = 0; Assignment is redundant, but I think maintainers may update this when applying. > + > + mutex_lock(&st->lock); > + if (readval) > + ret = regmap_read(st->map, reg, readval); > + else > + ret = regmap_write(st->map, reg, writeval); > + mutex_unlock(&st->lock); > + > + return ret; > +} > + > static const struct iio_info mpu_info = { > .read_raw = &inv_mpu6050_read_raw, > .write_raw = &inv_mpu6050_write_raw, > .write_raw_get_fmt = &inv_write_raw_get_fmt, > .attrs = &inv_attribute_group, > .validate_trigger = inv_mpu6050_validate_trigger, > + .debugfs_reg_access = &inv_mpu6050_reg_access, > }; > > /** > -- > 2.23.0.385.gbc12974a89 > -- With Best Regards, Andy Shevchenko