From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06806C43331 for ; Sat, 28 Mar 2020 16:24:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C631B2073B for ; Sat, 28 Mar 2020 16:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585412644; bh=cGPFCWRhs+dkS5xrifkv5mmzxqlyxEbQE7DmU9y27mg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=DKw8QOhOMj7on2/gi4dMoV9xijEmzDr1J+n84xD1kCJp8QXZdkkPpeQFfd8Hw37CH /gWCsrCGOwzJkAyWuUyxD4P/iUPvqqEo/IzKiSqxiDVj60FAgpz+uZXzxx54If+ixC O2m77wq/hTTj0JjXeeZv3/V69lbgfXYaSQ+Lol0U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725988AbgC1QYE (ORCPT ); Sat, 28 Mar 2020 12:24:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:50900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbgC1QYE (ORCPT ); Sat, 28 Mar 2020 12:24:04 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39AA920716; Sat, 28 Mar 2020 16:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585412643; bh=cGPFCWRhs+dkS5xrifkv5mmzxqlyxEbQE7DmU9y27mg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yVNEQvtGHbmYQmNSqyTlOQx5adTzfPIfp3B5Qk/w5qt3W4KolL9yfHcPg1fkT4yd3 1fISU1bdef8ctfJALrCPpgxudydNp1o5v7Oj750qx6FfOSIGZ1FRDC8fbqpQNow8b/ ST7y7GV6sT4o3spLeNipawEEyzrWhDCGyK2SCYfs= Date: Sat, 28 Mar 2020 16:23:59 +0000 From: Jonathan Cameron To: Daniel Campello Cc: LKML , LKML , Hartmut Knaack , Lars-Peter Clausen , Mark Rutland , Peter Meerwald-Stadler , Rob Herring , linux-iio@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: iio: Add bindings for sx9310 sensor Message-ID: <20200328162359.7e1fc2bd@archlinux> In-Reply-To: <20200323124310.1.I6ed779cd21abf3e70f21c1562bbda81f590976ab@changeid> References: <20200323124310.1.I6ed779cd21abf3e70f21c1562bbda81f590976ab@changeid> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 23 Mar 2020 12:45:14 -0600 Daniel Campello wrote: > Adds device tree bandings for sx9310 sensor. > > Signed-off-by: Daniel Campello Perhaps worth explicitly listing the power supply in the binding, particularly as it potentially has 2 different ones. We can then rely on stub regulators in the case where they are always on. Otherwise, looks good to me. Thanks, Jonathan > --- > > .../iio/proximity/semtech,sx9310.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml > > diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml > new file mode 100644 > index 00000000000000..da3424abe37e9d > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/proximity/semtech,sx9310.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Semtech's SX9310 capacitive proximity sensor > + > +maintainers: > + - Daniel Campello > + > +description: | > + Semtech's SX9310/SX9311 capacitive proximity/button solution. > + > + Specifications about the devices can be found at: > + https://www.semtech.com/products/smart-sensing/sar-sensors/sx9310 > + > +properties: > + compatible: > + enum: > + - semtech,sx9310 > + - semtech,sx9311 > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: > + The sole interrupt generated by the device used to announce the > + preceding reading request has finished and that data is > + available or that a close/far proximity event has happened. > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + proximity@28 { > + compatible = "semtech,sx9310"; > + reg = <0x28>; > + interrupt-parent = <&pio>; > + interrupts = <5 IRQ_TYPE_LEVEL_LOW 5>; > + }; > + }; > -- > 2.25.1.696.g5e7596f4ac-goog >