Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Rob Herring <robh@kernel.org>, Tomas Novotny <tomas@novotny.cz>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	"Angus Ainslie (Purism)" <angus@akkea.ca>,
	Marco Felsch <m.felsch@pengutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Nishant Malpani <nish.malpani25@gmail.com>
Subject: Re: [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add near-level
Date: Sun, 5 Apr 2020 10:29:44 +0100
Message-ID: <20200405102944.41589d98@archlinux> (raw)
In-Reply-To: <20200404174521.GA24709@bogon.m.sigxcpu.org>

On Sat, 4 Apr 2020 19:45:21 +0200
Guido Günther <agx@sigxcpu.org> wrote:

> Hi,
> On Sat, Apr 04, 2020 at 04:01:27PM +0100, Jonathan Cameron wrote:
> > On Tue, 31 Mar 2020 15:45:17 -0600
> > Rob Herring <robh@kernel.org> wrote:
> >   
> > > On Sun, Mar 29, 2020 at 10:25:26AM +0100, Jonathan Cameron wrote:  
> > > > On Wed, 25 Mar 2020 12:09:06 +0100
> > > > Guido Günther <agx@sigxcpu.org> wrote:
> > > >     
> > > > > This value indicates when userspace should consider an object
> > > > > near to the sensor/device.
> > > > > 
> > > > > Signed-off-by: Guido Günther <agx@sigxcpu.org>    
> > > > 
> > > > I'm fine with this.  Note for Rob or other DT people.
> > > > 
> > > > This is a new generic binding hence no vendor prefix.    
> > > 
> > > Then document in a common place.  
> > 
> > Ok. 
> > 
> > I guess we need to create a proximity specific binding file.
> > 
> > Documentation/devicetree/bindings/iio/proximity.yaml
> > 
> > Guido, could you do a v4 adding such a file.  For now I think
> > this is pretty much all that is proximity specific.  
> 
> I did a Documentation/devicetree/bindings/iio/common.yaml:
> 
> https://source.puri.sm/guido.gunther/linux-imx8/commit/8b91f0b7fa76ca4b2f3cdc251411829f71f8d810
> 
> so we can add new properties there and move iio-bindings.txt over.
> 
> Does that work as well? If so I'll send out a v4.

I can't find any real precedence for naming of such files.
So I guess this is still evolving. Send it out and we'll see what Rob thinks.

Jonathan


> Cheers,
>  -- Guido
> 
> 
> > 
> > At somepoint we should convert the subsystem wide iio-bindings.txt
> > but not today!
> > 
> > Thanks,
> > 
> > Jonathan
> >   
> > >   
> > > > 
> > > > I will ideally want review of both the dt patches though
> > > > before applying.  As we've missed the merge window anyway
> > > > there is no particular rush.
> > > > 
> > > > Thanks,
> > > > 
> > > > Jonathan
> > > >     
> > > > > ---
> > > > >  .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml    | 8 ++++++++
> > > > >  1 file changed, 8 insertions(+)
> > > > > 
> > > > > diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > > > index 21ef2eb7a205..ac9e3bb6a505 100644
> > > > > --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > > > +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> > > > > @@ -25,6 +25,13 @@ properties:
> > > > >    reg:
> > > > >      maxItems: 1
> > > > >  
> > > > > +  near-level:    
> > > 
> > > Perhaps proximity-near-level instead.  
> > 
> > Makes sense.
> >   
> > >   
> > > > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > > > +    description:
> > > > > +      Raw proximity values equal or above this level should be
> > > > > +      considered 'near' to the device (an object is near to the
> > > > > +      sensor).
> > > > > +
> > > > >  required:
> > > > >    - compatible
> > > > >    - reg
> > > > > @@ -40,6 +47,7 @@ examples:
> > > > >        light-sensor@51 {
> > > > >                compatible = "vishay,vcnl4200";
> > > > >                reg = <0x51>;
> > > > > +              near-level = <220>;
> > > > >        };
> > > > >    };
> > > > >  ...    
> > > >     
> >   


  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 11:09 [PATCH v3 0/4] iio: vcnl4000: Export near level property for proximity sensor Guido Günther
2020-03-25 11:09 ` [PATCH v3 1/4] dt-bindings: iio: vcnl4000: convert bindings to YAML format Guido Günther
2020-03-31 21:43   ` Rob Herring
2020-03-25 11:09 ` [PATCH v3 2/4] dt-bindings: iio: light: vcnl4000: Add near-level Guido Günther
2020-03-29  9:25   ` Jonathan Cameron
2020-03-31 21:45     ` Rob Herring
2020-04-04 15:01       ` Jonathan Cameron
2020-04-04 17:45         ` Guido Günther
2020-04-05  9:29           ` Jonathan Cameron [this message]
2020-03-25 11:09 ` [PATCH v3 3/4] iio: vcnl4000: Export near level property for proximity sensor Guido Günther
2020-03-25 11:09 ` [PATCH v3 4/4] Documentation: ABI: document IIO in_proximity_near_level file Guido Günther
2020-03-29  9:27   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200405102944.41589d98@archlinux \
    --to=jic23@kernel.org \
    --cc=agx@sigxcpu.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=angus@akkea.ca \
    --cc=devicetree@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=nish.malpani25@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tomas@novotny.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git