From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499CAC2BB54 for ; Tue, 7 Apr 2020 20:21:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DF3820748 for ; Tue, 7 Apr 2020 20:21:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbgDGUV6 (ORCPT ); Tue, 7 Apr 2020 16:21:58 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:33623 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbgDGUV5 (ORCPT ); Tue, 7 Apr 2020 16:21:57 -0400 X-Originating-IP: 78.193.40.249 Received: from kb-xps (unknown [78.193.40.249]) (Authenticated sender: kamel.bouhara@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id AD90920005; Tue, 7 Apr 2020 20:21:51 +0000 (UTC) Date: Tue, 7 Apr 2020 22:21:50 +0200 From: Kamel Bouhara To: William Breathitt Gray Cc: Rob Herring , Mark Rutland , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 1/3] ARM: at91: add atmel tcb capabilities Message-ID: <20200407202150.GD1489441@kb-xps> References: <20200406155320.1291701-1-kamel.bouhara@bootlin.com> <20200406155320.1291701-2-kamel.bouhara@bootlin.com> <20200407165335.GF5578@icarus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200407165335.GF5578@icarus> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Apr 07, 2020 at 12:53:35PM -0400, William Breathitt Gray wrote: > On Mon, Apr 06, 2020 at 05:53:18PM +0200, Kamel Bouhara wrote: > > Some atmel socs have extra tcb capabilities that allow using a generic > > clock source or enabling a quadrature decoder. > > > > Signed-off-by: Kamel Bouhara > > --- > > include/soc/at91/atmel_tcb.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/soc/at91/atmel_tcb.h b/include/soc/at91/atmel_tcb.h > > index fbf5474f4484..6b9c9bec982e 100644 > > --- a/include/soc/at91/atmel_tcb.h > > +++ b/include/soc/at91/atmel_tcb.h > > @@ -39,7 +39,8 @@ struct clk; > > */ > > struct atmel_tcb_config { > > size_t counter_width; > > - unsigned int has_gclk:1; > > Hi Kamel, > Hi William, > I'm having trouble applying this patch, so I think we have different > bases. Specifically, I'm not sure where this has_gclk member was > introduced. It doesn't look like it's in the testing branch of the IIO > tree yet. > > What branch did you base your patches on? You're right, this line should not be here. I'll fix it for v2. Thanks, Kamel > > Thanks, > > William Breathitt Gray > > > + bool has_gclk; > > + bool has_qdec; > > }; > > > > /** > > -- > > 2.25.0 > > -- Kamel Bouhara, Bootlin Embedded Linux and kernel engineering https://bootlin.com