From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57C7C2BA2B for ; Sun, 12 Apr 2020 11:55:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F1522072D for ; Sun, 12 Apr 2020 11:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586692515; bh=T7ow75b0ZoEqCiy/VmthNZ+rK0XXz/yyjCJeWfN2rhs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=no38exkT8wCHCqZQ0M/m/HzS8hR/9hwUXjBrPUY55m1Gys+ozTM4ezhkJneCOGT5b OvdgJWKgNLNIWPqbPY9KOEpgnismkk0yczwDXOigaipDKK5ZoTzbRU9xYGJtGcLFHJ BCik108ls3ce3sCXqiCCAb16+VoPxJ9JEghzVCnI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726658AbgDLLzO (ORCPT ); Sun, 12 Apr 2020 07:55:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:60804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726043AbgDLLzO (ORCPT ); Sun, 12 Apr 2020 07:55:14 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C1DD20709; Sun, 12 Apr 2020 11:55:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586692513; bh=T7ow75b0ZoEqCiy/VmthNZ+rK0XXz/yyjCJeWfN2rhs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GsGQ3xeQat/zHz4njwZ/2qVXTsIBA3yidfYrjtl1p/0DVfCTbM0szmGz/2rariYXD nGV/ZHlZbiK04qSFfDDwgA38yUGBWA9mSFqWiXZO0sDFTU2Dv9zmttiWE5juudiqSo qTFsgEs43CKhPurZfMzFhmIP59xHKNPq/LNhZukQ= Date: Sun, 12 Apr 2020 12:55:10 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: , Subject: Re: [PATCH 1/8] iio: core: drop devm_iio_device_unregister() API call Message-ID: <20200412125510.55304d4c@archlinux> In-Reply-To: <20200227135227.12433-1-alexandru.ardelean@analog.com> References: <20200227135227.12433-1-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 27 Feb 2020 15:52:20 +0200 Alexandru Ardelean wrote: > It's unused so far, so it can't be removed. Also makes sense to remove it > to discourage weird uses of this call during review. > > Signed-off-by: Alexandru Ardelean Time to pick these up I think. They've sat here a while and no one has commented + I can't think of any disadvantages. Hence, Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with them. Thanks, Jonathan > --- > .../driver-api/driver-model/devres.rst | 1 - > drivers/iio/industrialio-core.c | 17 ----------------- > include/linux/iio/iio.h | 4 ---- > 3 files changed, 22 deletions(-) > > diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst > index 46c13780994c..0580c64ebdfd 100644 > --- a/Documentation/driver-api/driver-model/devres.rst > +++ b/Documentation/driver-api/driver-model/devres.rst > @@ -286,7 +286,6 @@ IIO > devm_iio_device_alloc() > devm_iio_device_free() > devm_iio_device_register() > - devm_iio_device_unregister() > devm_iio_kfifo_allocate() > devm_iio_kfifo_free() > devm_iio_triggered_buffer_setup() > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c > index 0b14666dff09..e4011f8431f9 100644 > --- a/drivers/iio/industrialio-core.c > +++ b/drivers/iio/industrialio-core.c > @@ -1823,23 +1823,6 @@ int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev, > } > EXPORT_SYMBOL_GPL(__devm_iio_device_register); > > -/** > - * devm_iio_device_unregister - Resource-managed iio_device_unregister() > - * @dev: Device this iio_dev belongs to > - * @indio_dev: the iio_dev associated with the device > - * > - * Unregister iio_dev registered with devm_iio_device_register(). > - */ > -void devm_iio_device_unregister(struct device *dev, struct iio_dev *indio_dev) > -{ > - int rc; > - > - rc = devres_release(dev, devm_iio_device_unreg, > - devm_iio_device_match, indio_dev); > - WARN_ON(rc); > -} > -EXPORT_SYMBOL_GPL(devm_iio_device_unregister); > - > /** > * iio_device_claim_direct_mode - Keep device in direct mode > * @indio_dev: the iio_dev associated with the device > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h > index 862ce0019eba..0eb9e8d7ec68 100644 > --- a/include/linux/iio/iio.h > +++ b/include/linux/iio/iio.h > @@ -591,9 +591,6 @@ void iio_device_unregister(struct iio_dev *indio_dev); > * calls iio_device_register() internally. Refer to that function for more > * information. > * > - * If an iio_dev registered with this function needs to be unregistered > - * separately, devm_iio_device_unregister() must be used. > - * > * RETURNS: > * 0 on success, negative error number on failure. > */ > @@ -601,7 +598,6 @@ void iio_device_unregister(struct iio_dev *indio_dev); > __devm_iio_device_register((dev), (indio_dev), THIS_MODULE); > int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev, > struct module *this_mod); > -void devm_iio_device_unregister(struct device *dev, struct iio_dev *indio_dev); > int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp); > int iio_device_claim_direct_mode(struct iio_dev *indio_dev); > void iio_device_release_direct_mode(struct iio_dev *indio_dev);