Re: [PATCH v5 0/6] Support ADIS16475 and similar IMUs

From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexandru Ardelean <alexandru.Ardelean@analog.com>,
	Michael Hennerich <Michael.Hennerich@analog.com>
Subject: Re: [PATCH v5 0/6] Support ADIS16475 and similar IMUs
Date: Mon, 13 Apr 2020 17:27:22 +0100	[thread overview]
Message-ID: <20200413172722.1cb5f55e@archlinux> (raw)
In-Reply-To: <20200413082445.17324-1-nuno.sa@analog.com>

On Mon, 13 Apr 2020 10:24:39 +0200
Nuno Sá <nuno.sa@analog.com> wrote:

> This series adds support for the adis16475 and similar IMUs. This driver
> will be the first user of some changes on the adis library. Hence, the
> first three patches are related to the library:
>  * Add anaged device functions for registering triggers with the library;
>  * Updates the way `irq_mask` is passed to `request_irq()`;
>  * It adds an update_bits() like API.
> 
> A new patch was introduced (iio: adis: Add burst_max_len variable) in
> order to make burst32 configuration at runtime.

Series looks good to me, but I'd like to allow a bit of time for DT
review + anyone else who wants to take another look.

Thanks,

Jonathan

> 
> Nuno Sá (6):
>   iio: imu: adis: Add Managed device functions
>   iio: imu: adis: Add irq mask variable
>   iio: adis: Add adis_update_bits() APIs
>   iio: adis: Support different burst sizes
>   iio: imu: Add support for adis16475
>   dt-bindings: iio: Add adis16475 documentation
> 
>  .../bindings/iio/imu/adi,adis16475.yaml       |  137 ++
>  MAINTAINERS                                   |    8 +
>  drivers/iio/imu/Kconfig                       |   13 +
>  drivers/iio/imu/Makefile                      |    1 +
>  drivers/iio/imu/adis.c                        |   25 +
>  drivers/iio/imu/adis16400.c                   |    2 +-
>  drivers/iio/imu/adis16475.c                   | 1336 +++++++++++++++++
>  drivers/iio/imu/adis_buffer.c                 |   58 +-
>  drivers/iio/imu/adis_trigger.c                |   72 +-
>  include/linux/iio/imu/adis.h                  |   87 +-
>  10 files changed, 1728 insertions(+), 11 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
>  create mode 100644 drivers/iio/imu/adis16475.c
> 