From: Jonathan Cameron <jic23@kernel.org>
To: Ivan Mikhaylov <i.mikhaylov@yadro.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v14 0/2] iio: proximity: driver for vcnl3020
Date: Sat, 16 May 2020 17:41:31 +0100 [thread overview]
Message-ID: <20200516174119.4b8d0137@archlinux> (raw)
In-Reply-To: <20200510184537.10335-1-i.mikhaylov@yadro.com>
On Sun, 10 May 2020 21:45:35 +0300
Ivan Mikhaylov <i.mikhaylov@yadro.com> wrote:
> Add proximity sensor driver for Vishay vcnl3020. Only on-demand
> measurement is supported for now.
Hi Ivan,
Great and thanks for your persistence on this driver!
All looks good to me.
I will give time or a dt-bindings review as so far only
Rob's bot as commented. The look fine to me but as Rob
can certify I'm not very good at reviewing those things!
Thanks,
Jonathan
>
> Changes from v13:
> 1. description change for LED current.
>
> Changes from v12:
> 1. forgot to change path inside yaml.
>
> Changes from v11:
> 1. minor changes to yaml.
>
> Changes from v10:
> 1. add vcnl3020_property struct for optional properties.
>
> Changes from v9:
> 1. minor changes.
> 2. pass microamps from dts, not register value.
>
> Changes from v8:
> 1. add vcnl3020 prefix into get_and_apply_property function.
> 2. add bsd license into yaml.
> 3. vishay,led-current-milliamp -> vishay,led-current-microamp.
> 4. add default value into vishay,led-current-microamp and change
> register values into microamps.
>
> Changes from v7:
> 1. forgot to add Reviewed-by tag.
>
> Changes from v6:
> 1. minor changes
> 1.1 remove VCNL_DRV_NAME
> 1.2 add braces in get_and_apply_property
>
> Changes from v5:
> 1. add get_and_apply_property function for optional parameters.
> 2. minor changes.
>
> Changes from v4:
> 1. add vdd-supply,vddio-supply,interrupts properties into yaml.
> 2. led-current -> vishay,led-current-milliamp in yaml.
> 3. add possible values enum list.
> 4. add bulk_read for result hi/lo registers.
> 5. add description of vcnl3020_data structure.
> 6. vcnl3020 id table is removed.
> 7. make "vishay,led-current-milliamp" optional in yaml and code.
>
> Changes from v3:
> 1. minor changes.
> 2. add i2c block to fix dts section in yaml.
>
> Changes from v2:
> 1. using regmap_read_poll_timeout instead of do-while in measurement
> function.
> 2. change struct i2client* in vcnl3020_data to struct dev*
> 3. enable REGMAP_I2C in Kconfig
>
> Changes from v1:
> 1. using regmap interface instead of i2c_smbus_* calls.
> 2. switch from probe to probe_new.
> 3. s32/int32_t -> int
>
> Ivan Mikhaylov (2):
> dt-bindings: proximity: provide vcnl3020 device tree binding document
> iio: proximity: Add driver support for vcnl3020 proximity sensor
>
> .../iio/proximity/vishay,vcnl3020.yaml | 62 +++++
> drivers/iio/proximity/Kconfig | 11 +
> drivers/iio/proximity/Makefile | 1 +
> drivers/iio/proximity/vcnl3020.c | 258 ++++++++++++++++++
> 4 files changed, 332 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> create mode 100644 drivers/iio/proximity/vcnl3020.c
>
prev parent reply other threads:[~2020-05-16 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 18:45 [PATCH v14 0/2] iio: proximity: driver for vcnl3020 Ivan Mikhaylov
2020-05-10 18:45 ` [PATCH v14 1/2] dt-bindings: proximity: provide vcnl3020 device tree binding document Ivan Mikhaylov
2020-05-18 20:41 ` Rob Herring
2020-05-21 18:11 ` Jonathan Cameron
2020-05-10 18:45 ` [PATCH v14 2/2] iio: proximity: Add driver support for vcnl3020 proximity sensor Ivan Mikhaylov
2020-05-21 18:14 ` Jonathan Cameron
2020-05-16 16:41 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516174119.4b8d0137@archlinux \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=i.mikhaylov@yadro.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).