From: Jonathan Albrieux <jonathan.albrieux@gmail.com>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Jilayne Lovejoy <opensource@jilayne.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Steve Winslow <swinslow@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jonathan Cameron <jic23@kernel.org>,
Allison Randal <allison@lohutok.net>
Subject: Re: [PATCH v3 4/4] iio: magnetometer: ak8975: Add gpio reset support
Date: Tue, 19 May 2020 16:10:37 +0200 [thread overview]
Message-ID: <20200519141037.GD30573@ict14-OptiPlex-980> (raw)
In-Reply-To: <20200519132512.GC4623@gerhold.net>
On Tue, May 19, 2020 at 03:25:12PM +0200, Stephan Gerhold wrote:
> On Tue, May 19, 2020 at 02:43:54PM +0200, Jonathan Albrieux wrote:
> > According to AK09911 datasheet, if reset gpio is provided then
> > deassert reset on ak8975_power_on() and assert reset on ak8975_power_off().
> >
> > Without reset's deassertion during ak8975_power_on(), driver's probe fails
> > on ak8975_who_i_am while() checking for device identity for AK09911 chip.
> >
> > AK09911 has an active low reset gpio to handle register's reset.
> > AK09911 datasheed says that, if not used, reset pin should be connected
>
> Another minor typo: datasheed -> datasheet
>
> In any case, FWIW:
> Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
>
> > to VID. This patch emulates this situation.
> >
> > Signed-off-by: Jonathan Albrieux <jonathan.albrieux@gmail.com>
> > ---
> > drivers/iio/magnetometer/ak8975.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> > index fd368455cd7b..a23422aad97d 100644
> > --- a/drivers/iio/magnetometer/ak8975.c
> > +++ b/drivers/iio/magnetometer/ak8975.c
> > @@ -358,6 +358,7 @@ struct ak8975_data {
> > u8 asa[3];
> > long raw_to_gauss[3];
> > struct gpio_desc *eoc_gpiod;
> > + struct gpio_desc *reset_gpiod;
> > int eoc_irq;
> > wait_queue_head_t data_ready_queue;
> > unsigned long flags;
> > @@ -384,6 +385,9 @@ static int ak8975_power_on(const struct ak8975_data *data)
> > "Failed to enable specified Vid supply\n");
> > return ret;
> > }
> > +
> > + gpiod_set_value_cansleep(data->reset_gpiod, 0);
> > +
> > /*
> > * According to the datasheet the power supply rise time is 200us
> > * and the minimum wait time before mode setting is 100us, in
> > @@ -396,6 +400,8 @@ static int ak8975_power_on(const struct ak8975_data *data)
> > /* Disable attached power regulator if any. */
> > static void ak8975_power_off(const struct ak8975_data *data)
> > {
> > + gpiod_set_value_cansleep(data->reset_gpiod, 1);
> > +
> > regulator_disable(data->vid);
> > regulator_disable(data->vdd);
> > }
> > @@ -839,6 +845,7 @@ static int ak8975_probe(struct i2c_client *client,
> > struct ak8975_data *data;
> > struct iio_dev *indio_dev;
> > struct gpio_desc *eoc_gpiod;
> > + struct gpio_desc *reset_gpiod;
> > const void *match;
> > unsigned int i;
> > int err;
> > @@ -856,6 +863,16 @@ static int ak8975_probe(struct i2c_client *client,
> > if (eoc_gpiod)
> > gpiod_set_consumer_name(eoc_gpiod, "ak_8975");
> >
> > + /*
> > + * According to AK09911 datasheet, if reset GPIO is provided then
> > + * deassert reset on ak8975_power_on() and assert reset on
> > + * ak8975_power_off().
> > + */
> > + reset_gpiod = devm_gpiod_get_optional(&client->dev,
> > + "reset", GPIOD_OUT_HIGH);
> > + if (IS_ERR(reset_gpiod))
> > + return PTR_ERR(reset_gpiod);
> > +
> > /* Register with IIO */
> > indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
> > if (indio_dev == NULL)
> > @@ -866,6 +883,7 @@ static int ak8975_probe(struct i2c_client *client,
> >
> > data->client = client;
> > data->eoc_gpiod = eoc_gpiod;
> > + data->reset_gpiod = reset_gpiod;
> > data->eoc_irq = 0;
> >
> > err = iio_read_mount_matrix(&client->dev, "mount-matrix", &data->orientation);
> > --
> > 2.17.1
Thank you, will fix that typo too,
Best regards,
Jonathan Albrieux
prev parent reply other threads:[~2020-05-19 14:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 12:43 [PATCH v3 0/4] iio: magnetometer: ak8975: Add gpio reset support Jonathan Albrieux
2020-05-19 12:43 ` [PATCH v3 1/4] dt-bindings: iio: magnetometer: ak8975: convert txt format to yaml Jonathan Albrieux
2020-05-19 13:22 ` Stephan Gerhold
2020-05-19 14:03 ` Jonathan Albrieux
2020-05-19 16:01 ` Andy Shevchenko
2020-05-19 16:44 ` Jonathan Albrieux
2020-05-19 17:37 ` Jonathan Cameron
2020-05-20 6:56 ` Jonathan Albrieux
2020-05-19 12:43 ` [PATCH v3 2/4] dt-bindings: iio: magnetometer: ak8975: add gpio reset support Jonathan Albrieux
2020-05-19 13:23 ` Stephan Gerhold
2020-05-19 14:09 ` Jonathan Albrieux
2020-05-19 12:43 ` [PATCH v3 3/4] iio: magnetometer: ak8975: Fix typo, uniform measurement unit style Jonathan Albrieux
2020-05-19 12:55 ` Andy Shevchenko
2020-05-19 12:43 ` [PATCH v3 4/4] iio: magnetometer: ak8975: Add gpio reset support Jonathan Albrieux
2020-05-19 12:57 ` Andy Shevchenko
2020-05-19 13:03 ` Jonathan Albrieux
2020-05-19 13:25 ` Stephan Gerhold
2020-05-19 14:10 ` Jonathan Albrieux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519141037.GD30573@ict14-OptiPlex-980 \
--to=jonathan.albrieux@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=allison@lohutok.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=kstewart@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource@jilayne.com \
--cc=pmeerw@pmeerw.net \
--cc=stephan@gerhold.net \
--cc=swinslow@gmail.com \
--cc=tglx@linutronix.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).