From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80B32C433E0 for ; Tue, 19 May 2020 17:52:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61FC5207E8 for ; Tue, 19 May 2020 17:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729423AbgESRw2 (ORCPT ); Tue, 19 May 2020 13:52:28 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2226 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729001AbgESRw2 (ORCPT ); Tue, 19 May 2020 13:52:28 -0400 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 5D9B76180D7930E2DFAC; Tue, 19 May 2020 18:52:27 +0100 (IST) Received: from localhost (10.47.86.149) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1913.5; Tue, 19 May 2020 18:52:26 +0100 Date: Tue, 19 May 2020 18:51:59 +0100 From: Jonathan Cameron To: Jonathan Albrieux CC: , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Hartmut Knaack , Lars-Peter Clausen , "open list:IIO SUBSYSTEM AND DRIVERS" , "Peter Meerwald-Stadler" , Jonathan Cameron , Rob Herring Subject: Re: [PATCH v2 2/4] dt-bindings: iio: imu: bmi160: add regulators and mount-matrix Message-ID: <20200519185159.00001bd1@Huawei.com> In-Reply-To: <20200519075111.6356-3-jonathan.albrieux@gmail.com> References: <20200519075111.6356-1-jonathan.albrieux@gmail.com> <20200519075111.6356-3-jonathan.albrieux@gmail.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.86.149] X-ClientProxiedBy: lhreml705-chm.china.huawei.com (10.201.108.54) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 19 May 2020 09:50:58 +0200 Jonathan Albrieux wrote: > Add vdd-supply and vddio-supply support. > Add mount-matrix support. > > Signed-off-by: Jonathan Albrieux A few minor comments inline. > --- > .../devicetree/bindings/iio/imu/bmi160.yaml | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/imu/bmi160.yaml b/Documentation/devicetree/bindings/iio/imu/bmi160.yaml > index 6b464ce5ed0b..5b13af7a209f 100644 > --- a/Documentation/devicetree/bindings/iio/imu/bmi160.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/bmi160.yaml > @@ -46,6 +46,21 @@ properties: > set if the specified interrupt pin should be configured as > open drain. If not set, defaults to push-pull. > > + vdd-supply: > + maxItems: 1 > + description: | > + an optional regulator that needs to be on to provide VDD power to > + the sensor. They aren't optional. Whether we specify them or rely on stub regulators being provided because they aren't controllable is the optional bit. That's clearly defined by them not being in the required list below. So say something li.e description: | provide VDD power to the sensor. > + > + vddio-supply: > + maxItems: 1 > + description: | > + an optional regulator that needs to be on to provide the VDD IO power to > + the sensor. > + > + mount-matrix: > + description: an optional 3x3 mounting rotation matrix > + > required: > - compatible > - reg > @@ -61,9 +76,15 @@ examples: > bmi160@68 { > compatible = "bosch,bmi160"; > reg = <0x68>; > + vdd-supply = <&pm8916_l17>; > + vddio-supply = <&pm8916_l6>; > interrupt-parent = <&gpio4>; > interrupts = <12 1>; > interrupt-names = "INT1"; > + mount-matrix = "0", "1", "0", > + "-1", "0", "0", > + "0", "0", "1"; > + }; > }; > - | > // Example for SPI