From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<amit.kucheria@verdurent.com>
Subject: Re: [PATCH] iio: light: tsl2563: pass iio device as i2c_client private data
Date: Sun, 24 May 2020 15:39:47 +0100 [thread overview]
Message-ID: <20200524153947.5d39dc20@archlinux> (raw)
In-Reply-To: <20200522070801.28480-1-alexandru.ardelean@analog.com>
On Fri, 22 May 2020 10:08:01 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> We may want to get rid of the iio_priv_to_dev() helper. That's a bit
> uncertain at this point. The reason is that we will hide some of the
> members of the iio_dev structure (to prevent drivers from accessing them
> directly), and that will also mean hiding the implementation of the
> iio_priv_to_dev() helper inside the IIO core.
>
> Hiding the implementation of iio_priv_to_dev() implies that some fast-paths
> may not be fast anymore, so a general idea is to try to get rid of the
> iio_priv_to_dev() altogether.
>
> For this driver, it implies passing the IIO device on the i2c client
> private data. The implementation of iio_priv() will not be affected by the
> rework/hiding of iio_priv_to_dev().
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied. Thanks,
J
> ---
> drivers/iio/light/tsl2563.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
> index 27a5c28aac7f..2987a7a79a97 100644
> --- a/drivers/iio/light/tsl2563.c
> +++ b/drivers/iio/light/tsl2563.c
> @@ -713,7 +713,7 @@ static int tsl2563_probe(struct i2c_client *client,
>
> chip = iio_priv(indio_dev);
>
> - i2c_set_clientdata(client, chip);
> + i2c_set_clientdata(client, indio_dev);
> chip->client = client;
>
> err = tsl2563_detect(chip);
> @@ -797,8 +797,8 @@ static int tsl2563_probe(struct i2c_client *client,
>
> static int tsl2563_remove(struct i2c_client *client)
> {
> - struct tsl2563_chip *chip = i2c_get_clientdata(client);
> - struct iio_dev *indio_dev = iio_priv_to_dev(chip);
> + struct iio_dev *indio_dev = i2c_get_clientdata(client);
> + struct tsl2563_chip *chip = iio_priv(indio_dev);
>
> iio_device_unregister(indio_dev);
> if (!chip->int_enabled)
> @@ -816,7 +816,8 @@ static int tsl2563_remove(struct i2c_client *client)
> #ifdef CONFIG_PM_SLEEP
> static int tsl2563_suspend(struct device *dev)
> {
> - struct tsl2563_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
> + struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
> + struct tsl2563_chip *chip = iio_priv(indio_dev);
> int ret;
>
> mutex_lock(&chip->lock);
> @@ -834,7 +835,8 @@ static int tsl2563_suspend(struct device *dev)
>
> static int tsl2563_resume(struct device *dev)
> {
> - struct tsl2563_chip *chip = i2c_get_clientdata(to_i2c_client(dev));
> + struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
> + struct tsl2563_chip *chip = iio_priv(indio_dev);
> int ret;
>
> mutex_lock(&chip->lock);
prev parent reply other threads:[~2020-05-24 14:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 7:08 [PATCH] iio: light: tsl2563: pass iio device as i2c_client private data Alexandru Ardelean
2020-05-24 14:39 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524153947.5d39dc20@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=amit.kucheria@verdurent.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).