From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C48DC433E0 for ; Sun, 31 May 2020 13:48:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44C502076B for ; Sun, 31 May 2020 13:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590932880; bh=DH8ycjhUV5ikfmryVloe1Fw9MRgpGEyedmhdrEq9BTE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=dPsIR6CrqxAKWHccohRU6AQ6QPbYUOpat+YYuz14C7EhBAhVv3u2ghzg/Z9F5mIdk RRQJqcHupOYf/Znt42CHejHNLI3pciXyrmUp4nLPdg4Pdhh+0pzT+TPQ2eCxruHJDO 2nWBti9Vd1uZV5WXu28OAUHxOyOPrdBsg45g6i+o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728118AbgEaNr7 (ORCPT ); Sun, 31 May 2020 09:47:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:49772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbgEaNr7 (ORCPT ); Sun, 31 May 2020 09:47:59 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EDECE206F1; Sun, 31 May 2020 13:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590932879; bh=DH8ycjhUV5ikfmryVloe1Fw9MRgpGEyedmhdrEq9BTE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CGDrJsrnqa0vPPYTJsDsfFyXprppb7WGtUpI5D0fDz7Esl3caqtprjnUMU2JpMXz5 TmLwVjgPeEMvFu7UqFpDX1YzxWQiWcI6fGvXtaF5/lBEcURk/MkibnVMrevaW+Z14P 3DTc4VdeKqoITgpqgYJFTDkE+zE6+/WllohFsUHA= Date: Sun, 31 May 2020 14:47:55 +0100 From: Jonathan Cameron To: Rikard Falkeborn Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] iio: light: stk3310: Constify regmap_config Message-ID: <20200531144755.1874867c@archlinux> In-Reply-To: <20200526210223.1672-6-rikard.falkeborn@gmail.com> References: <20200526210223.1672-1-rikard.falkeborn@gmail.com> <20200526210223.1672-6-rikard.falkeborn@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 26 May 2020 23:02:22 +0200 Rikard Falkeborn wrote: > stk3310_regmap_config is not modified and can be made const to allow the > compiler to put it in read-only memory. > > Before: > text data bss dec hex filename > 16027 5424 128 21579 544b drivers/iio/light/stk3310.o > > After: > text data bss dec hex filename > 16347 5104 128 21579 544b drivers/iio/light/stk3310.o > > Signed-off-by: Rikard Falkeborn Applied. thanks, Jonathan > --- > drivers/iio/light/stk3310.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c > index 185c24a75ae6..9d1e503bc958 100644 > --- a/drivers/iio/light/stk3310.c > +++ b/drivers/iio/light/stk3310.c > @@ -487,7 +487,7 @@ static bool stk3310_is_volatile_reg(struct device *dev, unsigned int reg) > } > } > > -static struct regmap_config stk3310_regmap_config = { > +static const struct regmap_config stk3310_regmap_config = { > .name = STK3310_REGMAP_NAME, > .reg_bits = 8, > .val_bits = 8,