From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7299C433E0 for ; Sun, 31 May 2020 15:40:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75DAE20679 for ; Sun, 31 May 2020 15:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590939627; bh=ZihwhZLxsqzhnXkpIKIJp7j0qhmfl7QS0mKBa+pmKOg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=r7aizxA4t6ojM97UMRGI+hECx4u+wAhKuERSOcHE0LchJg5WJh0sUQRkkSGGwXGkx CQvJjo4tINe6IXdb6VBTy8qvyKBDmK835X4Z5SPD8vQnr9wqE6hZPh5bC7jwaX5Qhe IaRBNQlyxlb+OL6kj13EO18NyQLz9dhj2UBWpXng= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727013AbgEaPk0 (ORCPT ); Sun, 31 May 2020 11:40:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:54344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726081AbgEaPk0 (ORCPT ); Sun, 31 May 2020 11:40:26 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB41620659; Sun, 31 May 2020 15:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590939626; bh=ZihwhZLxsqzhnXkpIKIJp7j0qhmfl7QS0mKBa+pmKOg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tp1Sv1rUKr6NrKiTwxlXF4s0pdEoq4kByy9NBdZGnj+otXZHgL3vPTm3kV/UlDZcy IR70NT10/iVsHYN4bHayiWg2mM/gVhkFaHgFv23m99x35bH7xvtwmDNpiWgetRj8lO EKkSDV4lAJJImd26X+G1XZaAVuYfJvZc8FKw6Yfo= Date: Sun, 31 May 2020 16:40:20 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: , , , , , , , , , , , Lars-Peter Clausen Subject: Re: [PATCH v2 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable() Message-ID: <20200531164020.765822dc@archlinux> In-Reply-To: <20200525113855.178821-3-alexandru.ardelean@analog.com> References: <20200525113855.178821-1-alexandru.ardelean@analog.com> <20200525113855.178821-3-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 25 May 2020 14:38:55 +0300 Alexandru Ardelean wrote: > From: Lars-Peter Clausen > > This patch should be squashed into the first one, as the first one is > breaking the build (intentionally) to make the IIO core files easier to > review. > > Signed-off-by: Lars-Peter Clausen > Signed-off-by: Alexandru Ardelean > --- Friend poke. Version log? Other than the wistful comment below (which I'm not expecting you to do anything about btw!) whole series looks good to me. These are obviously no functional changes (I think) so it's only really patch 2 that could do with more eyes and acks. Far as I can tell that case is fine as well because of the protections on being in the right mode, but more eyes on that would be great. So assuming that's fine, what commit message do you want me to use for the fused single patch? Thanks, Jonathan > static const struct iio_trigger_ops atlas_interrupt_trigger_ops = { > diff --git a/drivers/iio/dummy/iio_simple_dummy_buffer.c b/drivers/iio/dummy/iio_simple_dummy_buffer.c > index 17606eca42b4..8e13c53d4360 100644 > --- a/drivers/iio/dummy/iio_simple_dummy_buffer.c > +++ b/drivers/iio/dummy/iio_simple_dummy_buffer.c > @@ -99,20 +99,6 @@ static irqreturn_t iio_simple_dummy_trigger_h(int irq, void *p) > } > > static const struct iio_buffer_setup_ops iio_simple_dummy_buffer_setup_ops = { > - /* > - * iio_triggered_buffer_postenable: > - * Generic function that simply attaches the pollfunc to the trigger. > - * Replace this to mess with hardware state before we attach the > - * trigger. > - */ > - .postenable = &iio_triggered_buffer_postenable, > - /* > - * iio_triggered_buffer_predisable: > - * Generic function that simple detaches the pollfunc from the trigger. > - * Replace this to put hardware state back again after the trigger is > - * detached but before userspace knows we have disabled the ring. > - */ > - .predisable = &iio_triggered_buffer_predisable, > }; > Hmm. Guess we should probably 'invent' a reason to illustrate the bufer ops in the dummy example. Anyone feeling creative?