From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 633E2C433E0 for ; Sat, 6 Jun 2020 16:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F4DE2077D for ; Sat, 6 Jun 2020 16:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591459919; bh=5nTYU96E9V/b22ZpW8mYRNyFiqDSTfluQthuqiDTznk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Wo5a3rc2U7NSexpdBMdOOhiM5x6jt8f4J615/YgsAi3LoRYK5PC4v84f02m5PHzfo P2AoLReNKzgFhJTy3rqAf7ni4gRRlIN/9KSeO+e0RaaDoeAoMjG6LXxK0B1qGdU86p 22HBh4hiNXnZmgJXsZjQloelzVRv/DUXrJmqQWps= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728785AbgFFQL6 (ORCPT ); Sat, 6 Jun 2020 12:11:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:53788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728732AbgFFQL6 (ORCPT ); Sat, 6 Jun 2020 12:11:58 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47F9A20772; Sat, 6 Jun 2020 16:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591459918; bh=5nTYU96E9V/b22ZpW8mYRNyFiqDSTfluQthuqiDTznk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mjquTdMZ4SN7cL0+zUmV6S27yeiiIJEfWCMBlCI9zf1q5UMT46JdIXwpBWMkcdIRd PeVbY2KJVRoJnDLKIROq1sIFKk0xuPvAfC+61ybn8KtLCchKQSzuq5RtZEQ/iIXwby pBgHrqXf4PwLkIca6LbIwPUDkxlnpMdoQNnkJTFQ= Date: Sat, 6 Jun 2020 17:11:53 +0100 From: Jonathan Cameron To: Navid Emamdoost Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Alexandru Ardelean , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, emamd001@umn.edu, wu000273@umn.edu, kjlu@umn.edu, smccaman@umn.edu Subject: Re: [PATCH] io: pressure: zpa2326: handle pm_runtime_get_sync failure Message-ID: <20200606171153.6824a326@archlinux> In-Reply-To: <20200605024445.35672-1-navid.emamdoost@gmail.com> References: <20200605024445.35672-1-navid.emamdoost@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 4 Jun 2020 21:44:44 -0500 Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost Hi Navid, This looks to be a fix, be it for a case that we are hopefully unlikely to ever hit. Please could you add an appropriate Fixes tag so we can work out how far to backport it? Patch looks good to me so if you just reply with a suitable tag I can add it whilst applying. Thanks, Jonathan > --- > drivers/iio/pressure/zpa2326.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c > index 99dfe33ee402..245f2e2d412b 100644 > --- a/drivers/iio/pressure/zpa2326.c > +++ b/drivers/iio/pressure/zpa2326.c > @@ -664,8 +664,10 @@ static int zpa2326_resume(const struct iio_dev *indio_dev) > int err; > > err = pm_runtime_get_sync(indio_dev->dev.parent); > - if (err < 0) > + if (err < 0) { > + pm_runtime_put(indio_dev->dev.parent); > return err; > + } > > if (err > 0) { > /*