From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE9FC433DF for ; Sat, 27 Jun 2020 14:53:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9753520E65 for ; Sat, 27 Jun 2020 14:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593269590; bh=L9OdzSsuNvSwO2OVpk6/T18wHhjvkFd5+zWtVH21nSY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=D6QZIiPUVw4sFmbb83GpC6GLcjcBucogIcwwbZLJpfZC8XWn+0JCzrP2HLTVuSLUb rdv1i5eencLsarv/Yrich1Wr2PQ3LKpRvl7qofBxg+h3W4grhyZBHHUSx3rMB31sJ4 XGk1DP+07nMYrZWSN4j6wqxxmf7kd/PsucGLbj4M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725932AbgF0OxK (ORCPT ); Sat, 27 Jun 2020 10:53:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:47028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbgF0OxJ (ORCPT ); Sat, 27 Jun 2020 10:53:09 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 55C24208B6; Sat, 27 Jun 2020 14:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593269589; bh=L9OdzSsuNvSwO2OVpk6/T18wHhjvkFd5+zWtVH21nSY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FHTruxQut8DGKpuKE4/Z6oi1cMUXVfngUrVcHZvOkHyZdvURsBSi7txrqI387QLQb SJPKslw8F+4pZpXCIZhW4MJPblfrNA3ZLpd1kpRsHbkaikxdSCARm0xdhTx+IafsJf zU7MP5bm5VqBGcvrthX03U+bS5UV8r+kLKVDKPvM= Date: Sat, 27 Jun 2020 15:53:04 +0100 From: Jonathan Cameron To: Markus Elfring Cc: Jonathan Cameron , Linus Walleij , Dinghao Liu , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Hartmut Knaack , Kangjie Lu , Lars-Peter Clausen , Peter Meerwald-Stadler Subject: Re: [PATCH v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error in ak8974_probe() Message-ID: <20200627155304.54ade781@archlinux> In-Reply-To: <68225325-ba51-7aab-6fef-6f234f4068d1@web.de> References: <68225325-ba51-7aab-6fef-6f234f4068d1@web.de> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 25 Jun 2020 14:34:44 +0200 Markus Elfring wrote: > https://lkml.org/lkml/2020/6/14/117 > https://lore.kernel.org/patchwork/comment/1452516/ > https://lore.kernel.org/linux-iio/20200614131116.143bcf92@archlinux/ > > > There was a lot of fuzz in this one due to other changes to the driver. > > I 'think' it went it cleanly though. > > Is it interesting anyhow that you committed a change description > which contained typos (on 2020-06-14 13:08:47 +0100)? > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/drivers/iio/magnetometer/ak8974.c?h=fixes-togreg&id=0187294d227dfc42889e1da8f8ce1e44fc25f147 > > How were the chances that my patch review comments would be taken > better into account? > https://lore.kernel.org/linux-iio/dd84c12f-277d-27e7-3727-4592e530e4ed@web.de/ > https://lkml.org/lkml/2020/5/31/152 I'm not sure why, but your reply did not have a reply-to field in the header as such my email client did not present it alongside the patch. Hence I missed it when applying. Agreed it would have been nicer to have fixed those typos. However, they don't affect comprehensibility of the message so I'm not that worried about having them in the log. Jonathan > > Regards, > Markus