From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 001B9C433E0 for ; Sat, 4 Jul 2020 16:44:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CED1120724 for ; Sat, 4 Jul 2020 16:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593881081; bh=PD/era8ubRD5t4ZyWfrIxlTj0WmdtlNAqXaLyEnwNdU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=waS7is88NQYpRI8W6k1ljGcWOf657dlU0iQhvEUx0hsyU8VhHqO8o4/dTJOq08EPN 6G+EI3uw9KuGBo/ZjarX1dcckVpY39hXvBqsg389mrDDGyqqcinbb9M4r9CbJFlrjp FkrvnXrBifwB/SaG6hBrTjEqKRtBD081SKjDy1ow= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbgGDQol (ORCPT ); Sat, 4 Jul 2020 12:44:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:59986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726632AbgGDQol (ORCPT ); Sat, 4 Jul 2020 12:44:41 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C6F7820723; Sat, 4 Jul 2020 16:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593881080; bh=PD/era8ubRD5t4ZyWfrIxlTj0WmdtlNAqXaLyEnwNdU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=B1e7yQ+3R8MjxuUCh4FcCKMVIADBZgPx1PLDaK97FtLhxbMSsSBBFIjP/t7KmwofW mUoehtF7J0joSdfRLgo0lW6GNT8X6QkhmBIMgkVjNAe4QMKybSMNXwGhEX7FzPtUmR WNFKQSd+IIydz9H81+ulVBCR6uNCGK/mavG6KaSk= Date: Sat, 4 Jul 2020 17:44:37 +0100 From: Jonathan Cameron To: Enric Balletbo i Serra Cc: Gwendal Grignou , bleung@chromium.org, lars@metafoo.de, linux-iio@vger.kernel.org Subject: Re: [PATCH v2] iio: cros_ec: Use default frequencies when EC returns invalid information Message-ID: <20200704174437.11794ac9@archlinux> In-Reply-To: References: <20200630153730.3302889-1-gwendal@chromium.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 30 Jun 2020 17:50:24 +0200 Enric Balletbo i Serra wrote: > Hi Gwendal, > > On 30/6/20 17:37, Gwendal Grignou wrote: > > Minimal and maximal frequencies supported by a sensor is queried. > > On some older machines, these frequencies are not returned properly and > > the EC returns 0 instead. > > When returned maximal frequency is 0, ignore the information and use > > default frequencies instead. > > > > Signed-off-by: Gwendal Grignou > > Reviewed-by: Enric Balletbo i Serra Fix or tidy up? I.e. does this want to go into stable? Thanks, Jonathan > > > --- > > Changes since v1: > > - improve visibility by using new 100 character line length limit. > > > > .../cros_ec_sensors/cros_ec_sensors_core.c | 16 +++++++++++----- > > 1 file changed, 11 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > > index 36e3f20891f05..b30fd6b56773f 100644 > > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > > @@ -289,7 +289,7 @@ int cros_ec_sensors_core_init(struct platform_device *pdev, > > struct cros_ec_sensorhub *sensor_hub = dev_get_drvdata(dev->parent); > > struct cros_ec_dev *ec = sensor_hub->ec; > > struct cros_ec_sensor_platform *sensor_platform = dev_get_platdata(dev); > > - u32 ver_mask; > > + u32 ver_mask, temp; > > int frequencies[ARRAY_SIZE(state->frequencies) / 2] = { 0 }; > > int ret, i; > > > > @@ -345,10 +345,16 @@ int cros_ec_sensors_core_init(struct platform_device *pdev, > > &frequencies[2], > > &state->fifo_max_event_count); > > } else { > > - frequencies[1] = state->resp->info_3.min_frequency; > > - frequencies[2] = state->resp->info_3.max_frequency; > > - state->fifo_max_event_count = > > - state->resp->info_3.fifo_max_event_count; > > + if (state->resp->info_3.max_frequency == 0) { > > + get_default_min_max_freq(state->resp->info.type, > > + &frequencies[1], > > + &frequencies[2], > > + &temp); > > + } else { > > + frequencies[1] = state->resp->info_3.min_frequency; > > + frequencies[2] = state->resp->info_3.max_frequency; > > + } > > + state->fifo_max_event_count = state->resp->info_3.fifo_max_event_count; > > } > > for (i = 0; i < ARRAY_SIZE(frequencies); i++) { > > state->frequencies[2 * i] = frequencies[i] / 1000; > >