* [PATCH v2 1/3] ltc2471: add of_match_table for existing devices
2020-07-16 9:46 iio:adc:ltc2371: add support for ltc2361/ltc2363 Darius Berghe
@ 2020-07-16 9:46 ` Darius Berghe
2020-07-16 9:46 ` [PATCH v2 2/3] ltc2471: ltc2461/ltc2463 compatible strings Darius Berghe
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Darius Berghe @ 2020-07-16 9:46 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic23
OF style match table was missing, this commit adds it.
Signed-off-by: Darius Berghe <darius.berghe@analog.com>
---
drivers/iio/adc/ltc2471.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/iio/adc/ltc2471.c b/drivers/iio/adc/ltc2471.c
index b88102b751cf..e1c4e966524d 100644
--- a/drivers/iio/adc/ltc2471.c
+++ b/drivers/iio/adc/ltc2471.c
@@ -14,6 +14,7 @@
#include <linux/module.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
+#include <linux/mod_devicetable.h>
enum ltc2471_chips {
ltc2471,
@@ -144,9 +145,17 @@ static const struct i2c_device_id ltc2471_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, ltc2471_i2c_id);
+static const struct of_device_id ltc2471_of_match[] = {
+ { .compatible = "adi,ltc2471" },
+ { .compatible = "adi,ltc2473" },
+ {}
+};
+MODULE_DEVICE_TABLE(of, ltc2471_of_match);
+
static struct i2c_driver ltc2471_i2c_driver = {
.driver = {
.name = "ltc2471",
+ .of_match_table = ltc2471_of_match
},
.probe = ltc2471_i2c_probe,
.id_table = ltc2471_i2c_id,
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/3] ltc2471: ltc2461/ltc2463 compatible strings
2020-07-16 9:46 iio:adc:ltc2371: add support for ltc2361/ltc2363 Darius Berghe
2020-07-16 9:46 ` [PATCH v2 1/3] ltc2471: add of_match_table for existing devices Darius Berghe
@ 2020-07-16 9:46 ` Darius Berghe
2020-07-16 9:46 ` [PATCH v2 3/3] ltc2471 driver yaml Darius Berghe
2020-07-20 10:36 ` iio:adc:ltc2371: add support for ltc2361/ltc2363 Jonathan Cameron
3 siblings, 0 replies; 6+ messages in thread
From: Darius Berghe @ 2020-07-16 9:46 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic23
Add compatible strings for these devices in the existing ltc2471
driver.
Signed-off-by: Darius Berghe <darius.berghe@analog.com>
---
drivers/iio/adc/ltc2471.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/ltc2471.c b/drivers/iio/adc/ltc2471.c
index e1c4e966524d..8c57203b1fe4 100644
--- a/drivers/iio/adc/ltc2471.c
+++ b/drivers/iio/adc/ltc2471.c
@@ -1,5 +1,7 @@
/*
- * Driver for Linear Technology LTC2471 and LTC2473 voltage monitors
+ * Driver for Linear Technology LTC2461, LTC2463, LTC2471 and LTC2473 voltage
+ * monitors.
+ * The LTC2463 is identical to the 2461, but reports a differential signal.
* The LTC2473 is identical to the 2471, but reports a differential signal.
*
* Copyright (C) 2017 Topic Embedded Products
@@ -17,8 +19,10 @@
#include <linux/mod_devicetable.h>
enum ltc2471_chips {
+ ltc2461,
+ ltc2463,
ltc2471,
- ltc2473,
+ ltc2473
};
struct ltc2471_data {
@@ -122,7 +126,7 @@ static int ltc2471_i2c_probe(struct i2c_client *client,
indio_dev->name = id->name;
indio_dev->info = <c2471_info;
indio_dev->modes = INDIO_DIRECT_MODE;
- if (id->driver_data == ltc2473)
+ if (id->driver_data == ltc2473 || id->driver_data == ltc2463)
indio_dev->channels = ltc2473_channel;
else
indio_dev->channels = ltc2471_channel;
@@ -139,6 +143,8 @@ static int ltc2471_i2c_probe(struct i2c_client *client,
}
static const struct i2c_device_id ltc2471_i2c_id[] = {
+ { "ltc2461", ltc2461 },
+ { "ltc2463", ltc2463 },
{ "ltc2471", ltc2471 },
{ "ltc2473", ltc2473 },
{}
@@ -146,6 +152,8 @@ static const struct i2c_device_id ltc2471_i2c_id[] = {
MODULE_DEVICE_TABLE(i2c, ltc2471_i2c_id);
static const struct of_device_id ltc2471_of_match[] = {
+ { .compatible = "adi,ltc2461" },
+ { .compatible = "adi,ltc2463" },
{ .compatible = "adi,ltc2471" },
{ .compatible = "adi,ltc2473" },
{}
@@ -163,6 +171,6 @@ static struct i2c_driver ltc2471_i2c_driver = {
module_i2c_driver(ltc2471_i2c_driver);
-MODULE_DESCRIPTION("LTC2471/LTC2473 ADC driver");
+MODULE_DESCRIPTION("LTC2461/LTC2463/LTC2471/LTC2473 ADC driver");
MODULE_AUTHOR("Topic Embedded Products");
MODULE_LICENSE("GPL v2");
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 3/3] ltc2471 driver yaml
2020-07-16 9:46 iio:adc:ltc2371: add support for ltc2361/ltc2363 Darius Berghe
2020-07-16 9:46 ` [PATCH v2 1/3] ltc2471: add of_match_table for existing devices Darius Berghe
2020-07-16 9:46 ` [PATCH v2 2/3] ltc2471: ltc2461/ltc2463 compatible strings Darius Berghe
@ 2020-07-16 9:46 ` Darius Berghe
2020-07-20 10:36 ` iio:adc:ltc2371: add support for ltc2361/ltc2363 Jonathan Cameron
3 siblings, 0 replies; 6+ messages in thread
From: Darius Berghe @ 2020-07-16 9:46 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic23
Add dt binding documentation for ltc2471 driver. This covers all supported
devices.
Signed-off-by: Darius Berghe <darius.berghe@analog.com>
---
.../bindings/iio/adc/adi,ltc2471.yaml | 49 +++++++++++++++++++
1 file changed, 49 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ltc2471.yaml
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ltc2471.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ltc2471.yaml
new file mode 100644
index 000000000000..d5b35a1fa651
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ltc2471.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright 2020 Analog Devices Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bindings/iio/adc/adi,ltc2471.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices LTC2471 16-bit I2C Sigma-Delta ADC
+
+maintainers:
+ - Mike Looijmans <mike.looijmans@topic.nl>
+
+description: |
+ Analog Devices LTC2461 (single-ended) and LTC2463 (differential) 16-bit
+ I2C Sigma-Delta ADC with 60sps output rate.
+ https://www.analog.com/media/en/technical-documentation/data-sheets/24613fa.pdf
+
+ Analog Devices LTC2471 (single-ended) and LTC2473 (differential) 16-bit
+ I2C Sigma-Delta ADC with selectable 208/833sps output rate.
+ https://www.analog.com/media/en/technical-documentation/data-sheets/24713fb.pdf
+
+properties:
+ compatible:
+ enum:
+ - adi,ltc2461
+ - adi,ltc2463
+ - adi,ltc2471
+ - adi,ltc2473
+
+ reg:
+ maxItems: 1
+
+ avcc-supply:
+ description:
+ Phandle to the Avcc power supply (2.7V - 5.5V)
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ i2c0 {
+ adc@14 {
+ compatible = "adi,ltc2461";
+ reg = <0x14>;
+ };
+ };
+
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: iio:adc:ltc2371: add support for ltc2361/ltc2363
2020-07-16 9:46 iio:adc:ltc2371: add support for ltc2361/ltc2363 Darius Berghe
` (2 preceding siblings ...)
2020-07-16 9:46 ` [PATCH v2 3/3] ltc2471 driver yaml Darius Berghe
@ 2020-07-20 10:36 ` Jonathan Cameron
3 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2020-07-20 10:36 UTC (permalink / raw)
To: Darius Berghe; +Cc: linux-iio, linux-kernel
On Thu, 16 Jul 2020 12:46:08 +0300
Darius Berghe <darius.berghe@analog.com> wrote:
> Changelog v1->v2:
> - document power supply in yaml
> - reorder enums in alphabetical order
> - add missing include
> - drop the of_match_ptr protection
>
> Darius Berghe (3):
> ltc2471: add of_match_table for existing devices
> ltc2471: ltc2461/ltc2463 compatible strings
> ltc2471 driver yaml
All looks fine to me, but please resend with dt list and maintainer
cc'd as patch 3 needs a DT review.
Thanks,
Jonathan
>
> .../bindings/iio/adc/adi,ltc2471.yaml | 49 +++++++++++++++++++
> drivers/iio/adc/ltc2471.c | 25 ++++++++--
> 2 files changed, 70 insertions(+), 4 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ltc2471.yaml
>
^ permalink raw reply [flat|nested] 6+ messages in thread