From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2659DC433F1 for ; Fri, 24 Jul 2020 21:33:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 019F6206F6 for ; Fri, 24 Jul 2020 21:33:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bueanFjG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726763AbgGXVdp (ORCPT ); Fri, 24 Jul 2020 17:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbgGXVde (ORCPT ); Fri, 24 Jul 2020 17:33:34 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02173C0619E5 for ; Fri, 24 Jul 2020 14:33:34 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id m16so5292879pls.5 for ; Fri, 24 Jul 2020 14:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Or2hRyZ+DJD2fMv0vkFvtUzR/cluRUiM0su+3Iw/kY=; b=bueanFjGE8P6y0aX0kwLr2tZV2YD96YtUUUTOZYK/ammPsZ0QoUt0HZCNi1ZOtnfN2 9gedv4E86CKFfdSifS9RuWJ7hPiVHPmSsGQsOJZNE3NneGyBG/L2woCwcQHCZRlJDtTg dBEkIFoYCBcSRPmhMMzNwfYN7pVeD8XIqlPi8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Or2hRyZ+DJD2fMv0vkFvtUzR/cluRUiM0su+3Iw/kY=; b=mr6Y/kJ2PSPXJj7BQKfbVAclJXXL/odSzXLsYLKLAtVkbGACptiC0d8uv/r0iq0mgE D9ajqNWiwgfllpJbQ8WtE0YYqM2Ym3AtQFYNNl1l5wAoS6VgEl/5KxjU49CpyjrmXNBR EG5uau1J7VFeU7NbPhE8wEHcomDTQr2fw2X7D6ayIKBgL1rSu4faapVSePLNHy2unQp3 suTMOq1EzY4ZIKdzyx42CQUuT+74ODLOnm0PMvUZGhL9etmX+dU4mnVUtpNCb1XkoLhd HA3QsAEN5TNYuoeNpJSUeSiyubjhlUp2HA47gDfCwjb3bRfDmQkOApPMkj/BVqXs12Ac O+tA== X-Gm-Message-State: AOAM531B5mAvp5jweeuaofppeHg3mLorPfu7aY0SnOQOTujSmeBKpBW9 ySmAc8zfSRBEVvJSlq1LhXgYBQ== X-Google-Smtp-Source: ABdhPJyHNEX4/GvHCS4/49Y3LcVSQrJYa3M5O+TtF5sMRlADwPsO/3YJw0/2WqHVUucWSfwuDbYpgA== X-Received: by 2002:a17:90a:62c1:: with SMTP id k1mr7522698pjs.107.1595626413574; Fri, 24 Jul 2020 14:33:33 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id z6sm7312919pfn.173.2020.07.24.14.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 14:33:33 -0700 (PDT) From: Stephen Boyd To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Gwendal Grignou , Daniel Campello , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Douglas Anderson Subject: [PATCH v2 2/5] iio: sx9310: Add newlines to printks Date: Fri, 24 Jul 2020 14:33:26 -0700 Message-Id: <20200724213329.899216-3-swboyd@chromium.org> X-Mailer: git-send-email 2.28.0.rc0.142.g3c755180ce-goog In-Reply-To: <20200724213329.899216-1-swboyd@chromium.org> References: <20200724213329.899216-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Printks in the kernel have newlines at the end. Add them to the few printks in this driver. Cc: Gwendal Grignou Reviewed-by: Daniel Campello Cc: Hartmut Knaack Cc: Lars-Peter Clausen Cc: Peter Meerwald-Stadler Reviewed-by: Douglas Anderson Fixes: 72ad02b15d63 ("iio: Add SEMTECH SX9310/9311 sensor driver") Signed-off-by: Stephen Boyd --- drivers/iio/proximity/sx9310.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c index d161f3061e35..84c3c9ae80dc 100644 --- a/drivers/iio/proximity/sx9310.c +++ b/drivers/iio/proximity/sx9310.c @@ -824,7 +824,7 @@ static int sx9310_init_compensation(struct iio_dev *indio_dev) if (i < 0) { dev_err(&data->client->dev, - "initial compensation timed out: 0x%02x", val); + "initial compensation timed out: 0x%02x\n", val); ret = -ETIMEDOUT; } @@ -871,14 +871,14 @@ static int sx9310_set_indio_dev_name(struct device *dev, /* id will be NULL when enumerated via ACPI */ if (id) { if (id->driver_data != whoami) - dev_err(dev, "WHOAMI does not match i2c_device_id: %s", + dev_err(dev, "WHOAMI does not match i2c_device_id: %s\n", id->name); } else if (ACPI_HANDLE(dev)) { acpi_id = acpi_match_device(dev->driver->acpi_match_table, dev); if (!acpi_id) return -ENODEV; if (acpi_id->driver_data != whoami) - dev_err(dev, "WHOAMI does not match acpi_device_id: %s", + dev_err(dev, "WHOAMI does not match acpi_device_id: %s\n", acpi_id->id); } else return -ENODEV; @@ -891,7 +891,7 @@ static int sx9310_set_indio_dev_name(struct device *dev, indio_dev->name = "sx9311"; break; default: - dev_err(dev, "unexpected WHOAMI response: %u", whoami); + dev_err(dev, "unexpected WHOAMI response: %u\n", whoami); return -ENODEV; } @@ -920,7 +920,7 @@ static int sx9310_probe(struct i2c_client *client, ret = regmap_read(data->regmap, SX9310_REG_WHOAMI, &data->whoami); if (ret < 0) { - dev_err(&client->dev, "error in reading WHOAMI register: %d", + dev_err(&client->dev, "error in reading WHOAMI register: %d\n", ret); return ret; } -- Sent by a computer, using git, on the internet