* [PATCH] iio: adxl372: change indentation for of_table
@ 2020-07-20 13:48 Alexandru Ardelean
2020-07-21 18:36 ` Andy Shevchenko
2020-07-22 7:25 ` [PATCH v2] iio: adxl372_spi: " Alexandru Ardelean
0 siblings, 2 replies; 4+ messages in thread
From: Alexandru Ardelean @ 2020-07-20 13:48 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic23, Alexandru Ardelean
The change is mostly stylistic. The table should be indented with tabs
instead of spaces.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/iio/accel/adxl372_spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/accel/adxl372_spi.c b/drivers/iio/accel/adxl372_spi.c
index 3ef7e3a4804e..7741890674c1 100644
--- a/drivers/iio/accel/adxl372_spi.c
+++ b/drivers/iio/accel/adxl372_spi.c
@@ -40,8 +40,8 @@ static const struct spi_device_id adxl372_spi_id[] = {
MODULE_DEVICE_TABLE(spi, adxl372_spi_id);
static const struct of_device_id adxl372_of_match[] = {
- { .compatible = "adi,adxl372" },
- { },
+ { .compatible = "adi,adxl372" },
+ { },
};
MODULE_DEVICE_TABLE(of, adxl372_of_match);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adxl372: change indentation for of_table
2020-07-20 13:48 [PATCH] iio: adxl372: change indentation for of_table Alexandru Ardelean
@ 2020-07-21 18:36 ` Andy Shevchenko
2020-07-22 7:25 ` [PATCH v2] iio: adxl372_spi: " Alexandru Ardelean
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2020-07-21 18:36 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-iio, Linux Kernel Mailing List, Jonathan Cameron
On Mon, Jul 20, 2020 at 4:49 PM Alexandru Ardelean
<alexandru.ardelean@analog.com> wrote:
>
> The change is mostly stylistic. The table should be indented with tabs
> instead of spaces.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
> drivers/iio/accel/adxl372_spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/adxl372_spi.c b/drivers/iio/accel/adxl372_spi.c
> index 3ef7e3a4804e..7741890674c1 100644
> --- a/drivers/iio/accel/adxl372_spi.c
> +++ b/drivers/iio/accel/adxl372_spi.c
> @@ -40,8 +40,8 @@ static const struct spi_device_id adxl372_spi_id[] = {
> MODULE_DEVICE_TABLE(spi, adxl372_spi_id);
>
> static const struct of_device_id adxl372_of_match[] = {
> - { .compatible = "adi,adxl372" },
> - { },
> + { .compatible = "adi,adxl372" },
> + { },
Please, drop useless and even bad in very rare cases comma at the
terminator line.
> };
> MODULE_DEVICE_TABLE(of, adxl372_of_match);
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] iio: adxl372_spi: change indentation for of_table
2020-07-20 13:48 [PATCH] iio: adxl372: change indentation for of_table Alexandru Ardelean
2020-07-21 18:36 ` Andy Shevchenko
@ 2020-07-22 7:25 ` Alexandru Ardelean
2020-07-26 12:30 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: Alexandru Ardelean @ 2020-07-22 7:25 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic23, Alexandru Ardelean
The change is mostly stylistic. The table should be indented with tabs
instead of spaces.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
Changelog v1 -> v2:
* remove trailing comma at null terminator
drivers/iio/accel/adxl372_spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/accel/adxl372_spi.c b/drivers/iio/accel/adxl372_spi.c
index 3ef7e3a4804e..1f1352fee99a 100644
--- a/drivers/iio/accel/adxl372_spi.c
+++ b/drivers/iio/accel/adxl372_spi.c
@@ -40,8 +40,8 @@ static const struct spi_device_id adxl372_spi_id[] = {
MODULE_DEVICE_TABLE(spi, adxl372_spi_id);
static const struct of_device_id adxl372_of_match[] = {
- { .compatible = "adi,adxl372" },
- { },
+ { .compatible = "adi,adxl372" },
+ { }
};
MODULE_DEVICE_TABLE(of, adxl372_of_match);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] iio: adxl372_spi: change indentation for of_table
2020-07-22 7:25 ` [PATCH v2] iio: adxl372_spi: " Alexandru Ardelean
@ 2020-07-26 12:30 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2020-07-26 12:30 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-iio, linux-kernel
On Wed, 22 Jul 2020 10:25:46 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> The change is mostly stylistic. The table should be indented with tabs
> instead of spaces.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied
> ---
>
> Changelog v1 -> v2:
> * remove trailing comma at null terminator
>
> drivers/iio/accel/adxl372_spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/adxl372_spi.c b/drivers/iio/accel/adxl372_spi.c
> index 3ef7e3a4804e..1f1352fee99a 100644
> --- a/drivers/iio/accel/adxl372_spi.c
> +++ b/drivers/iio/accel/adxl372_spi.c
> @@ -40,8 +40,8 @@ static const struct spi_device_id adxl372_spi_id[] = {
> MODULE_DEVICE_TABLE(spi, adxl372_spi_id);
>
> static const struct of_device_id adxl372_of_match[] = {
> - { .compatible = "adi,adxl372" },
> - { },
> + { .compatible = "adi,adxl372" },
> + { }
> };
> MODULE_DEVICE_TABLE(of, adxl372_of_match);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-26 12:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 13:48 [PATCH] iio: adxl372: change indentation for of_table Alexandru Ardelean
2020-07-21 18:36 ` Andy Shevchenko
2020-07-22 7:25 ` [PATCH v2] iio: adxl372_spi: " Alexandru Ardelean
2020-07-26 12:30 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).