From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76825C433E4 for ; Tue, 28 Jul 2020 14:58:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 616C420786 for ; Tue, 28 Jul 2020 14:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730564AbgG1O6o (ORCPT ); Tue, 28 Jul 2020 10:58:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730521AbgG1O6n (ORCPT ); Tue, 28 Jul 2020 10:58:43 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1087C0619D2 for ; Tue, 28 Jul 2020 07:58:43 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0R3s-0008Kw-CQ; Tue, 28 Jul 2020 16:58:36 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1k0R3p-0005II-Qu; Tue, 28 Jul 2020 16:58:33 +0200 Date: Tue, 28 Jul 2020 16:58:33 +0200 From: Marco Felsch To: Andy Shevchenko Cc: Sandeep Singh , Jiri Kosina , Benjamin Tissoires , Linux Kernel Mailing List , linux-input , Srinivas Pandruvada , Jonathan Cameron , linux-iio , Hans de Goede , "Shah, Nehal-bakulchandra" , Richard Neumann , Shyam-sundar.S-k@amd.com Subject: Re: [PATCH v5 0/4] SFH: Add Support for AMD Sensor Fusion Hub Message-ID: <20200728145833.xc53dpvwu7deqzjw@pengutronix.de> References: <1590759730-32494-1-git-send-email-Sandeep.Singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 16:53:55 up 256 days, 6:12, 240 users, load average: 0.19, 0.14, 0.06 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-iio@vger.kernel.org Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi, On 20-05-29 17:21, Andy Shevchenko wrote: > On Fri, May 29, 2020 at 4:42 PM Sandeep Singh wrote: > > > > From: Sandeep Singh > > > > AMD SFH(Sensor Fusion Hub) is HID based driver.SFH FW > > is part of MP2 processor (MP2 which is an ARMŽ Cortex-M4 > > core based co-processor to x86) and it runs on MP2 where > > in driver resides on X86.The driver functionalities are > > divided into three parts:- > > > > 1: amd-mp2-pcie:- This module will communicate with MP2 FW and > > provide that data into DRAM. > > 2: Client driver :- This part for driver will use dram data and > > convert that data into HID format based on > > HID reports. > > 3: Transport driver :- This part of driver will communicate with > > HID core. Communication between devices and > > HID core is mostly done via HID reports > > > > In terms of architecture it is much more reassembles like > > ISH(Intel Integrated Sensor Hub). However the major difference > > is all the hid reports are generated as part of kernel driver. > > AMD SFH driver taken reference from ISH in terms of > > design and functionalities at fewer location. > > > > AMD sensor fusion Hub is part of a SOC 17h family based platforms. > > The solution is working well on several OEM products. > > AMD SFH uses HID over PCIe bus. > > > > I can't believe this is fifth version. > Guys, you have to do much more work on these drivers. Is there any active development addressing Andy's comments? Else can we support you to bring these patches mainline? Regards, Marco