From: Maxim Kochetkov <fido_max@inbox.ru> To: unlisted-recipients:; (no To-header on input) Cc: Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Maxim Kochetkov <fido_max@inbox.ru>, linux-iio@vger.kernel.org, bigunclemax@gmail.com Subject: [PATCH v2] iio: adc: ti-ads1015: fix conversion when CONFIG_PM is not set Date: Wed, 29 Jul 2020 12:06:31 +0300 Message-ID: <20200729090631.12910-1-fido_max@inbox.ru> (raw) To stop conversion ads1015_set_power_state function call unimplemented function __pm_runtime_suspend from pm_runtime_put_autosuspend if CONFIG_PM is not set. In case of CONFIG_PM is not set: static inline int __pm_runtime_suspend(struct device *dev, int rpmflags) { return -ENOSYS; } so ads1015_read_raw failed at: ret = ads1015_set_power_state(data, false); if (ret < 0) goto release_direct; If CONFIG_PM is disabled, there is no need to start/stop conversion. Fix it by adding return 0 function variant if CONFIG_PM is not set. Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru> Tested-by: Maxim Kiselev <bigunclemax@gmail.com> --- drivers/iio/adc/ti-ads1015.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c index 5ea4f45d6bad..64fe3b2a6ec6 100644 --- a/drivers/iio/adc/ti-ads1015.c +++ b/drivers/iio/adc/ti-ads1015.c @@ -316,6 +316,7 @@ static const struct iio_chan_spec ads1115_channels[] = { IIO_CHAN_SOFT_TIMESTAMP(ADS1015_TIMESTAMP), }; +#ifdef CONFIG_PM static int ads1015_set_power_state(struct ads1015_data *data, bool on) { int ret; @@ -333,6 +334,15 @@ static int ads1015_set_power_state(struct ads1015_data *data, bool on) return ret < 0 ? ret : 0; } +#else /* !CONFIG_PM */ + +static int ads1015_set_power_state(struct ads1015_data *data, bool on) +{ + return 0; +} + +#endif /* !CONFIG_PM */ + static int ads1015_get_adc_result(struct ads1015_data *data, int chan, int *val) { -- 2.27.0
next reply index Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-29 9:06 Maxim Kochetkov [this message] 2020-07-29 10:19 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200729090631.12910-1-fido_max@inbox.ru \ --to=fido_max@inbox.ru \ --cc=andriy.shevchenko@linux.intel.com \ --cc=bigunclemax@gmail.com \ --cc=jic23@kernel.org \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-IIO Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \ linux-iio@vger.kernel.org public-inbox-index linux-iio Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio AGPL code for this site: git clone https://public-inbox.org/public-inbox.git