From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E3BC433DF for ; Sat, 1 Aug 2020 15:01:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84B23207FB for ; Sat, 1 Aug 2020 15:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596294097; bh=EPYZ0iW9XYWW4u3IIeCtf7nBGEINcN0i9JroAJkPJqw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ObKLBzzlmDU4xiTXd13cKHF1jvFgtsFuSKlE1Xm87y7rTsHU1o3U6v9m4jckpXwHA aZyMS19R5qg3E/WoyxeOvZGWKvXjgkH2c9MxBpWLRgbcTEF84ysajaqQddDg2+Vo5N vZz68pYMp/msgMTakR4e15JqSAECTCY1UwGfE2bA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726545AbgHAPBh (ORCPT ); Sat, 1 Aug 2020 11:01:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:57934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725804AbgHAPBg (ORCPT ); Sat, 1 Aug 2020 11:01:36 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 718E92071E; Sat, 1 Aug 2020 15:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596294096; bh=EPYZ0iW9XYWW4u3IIeCtf7nBGEINcN0i9JroAJkPJqw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=14NtLxV6Pf8Po3/PrklE7N44vxtfIJ94zmervvOVoND6+AwX56TUWfviMfys3Cagu XihOmaNlbOMikdptk6CRSEgjIcBo4w0MBu7t+XUoSckjW5RV/tZfAZ1zsUykvtaqBb xywHgV57Dsdi27WJBSbHXhXvg74JL5ZDqvuWWhvo= Date: Sat, 1 Aug 2020 16:01:31 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Daniel Campello , LKML , LKML , Stephen Boyd , Douglas Anderson , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio Subject: Re: [PATCH v3 15/15] iio: sx9310: Use irq trigger flags from firmware Message-ID: <20200801160131.0ed25e71@archlinux> In-Reply-To: References: <20200731164853.3020946-1-campello@chromium.org> <20200731104555.v3.15.I4c344a6793007001bbb3c1c08e96d3acf893b36b@changeid> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 31 Jul 2020 22:46:55 +0300 Andy Shevchenko wrote: > On Fri, Jul 31, 2020 at 7:49 PM Daniel Campello wrote: > > > > From: Stephen Boyd > > > > We shouldn't need to set default irq trigger flags here as the firmware > > should have properly indicated the trigger type, i.e. level low, in the > > DT or ACPI tables. > > Reviewed-by: Andy Shevchenko Other than the two patches I replied to the rest look good to me. Thanks, Jonathan > > > Signed-off-by: Stephen Boyd > > Signed-off-by: Daniel Campello > > --- > > > > Changes in v3: > > - Added irq trigger flags commit to the series. > > > > Changes in v2: None > > > > drivers/iio/proximity/sx9310.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c > > index a20cd6a4dad729..c41fa7f6558e3f 100644 > > --- a/drivers/iio/proximity/sx9310.c > > +++ b/drivers/iio/proximity/sx9310.c > > @@ -951,7 +951,7 @@ static int sx9310_probe(struct i2c_client *client) > > ret = devm_request_threaded_irq(dev, client->irq, > > sx9310_irq_handler, > > sx9310_irq_thread_handler, > > - IRQF_TRIGGER_LOW | IRQF_ONESHOT, > > + IRQF_ONESHOT, > > "sx9310_event", indio_dev); > > if (ret) > > return ret; > > -- > > 2.28.0.163.g6104cc2f0b6-goog > > > >