From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BEB7C433E0 for ; Sun, 9 Aug 2020 17:48:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B725206E9 for ; Sun, 9 Aug 2020 17:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596995281; bh=mXDBApGPwHvRpWoci5kU70zkmMHizKMJsB8PqF5H5fU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=F/8+mkhJm4TXqY4SQ4uNi0vNFX9lxa3UzBbFMRdeG3NtoMQ7SHyuH/+KS58T84Vn/ 4TWIzPjE1jZdjgYlrEHeCVTVilwXX5k9nU3IYJ2G54y74oN35y9lXNRWcF/kRZkokj RWaTt4wUSNDhI7flJNGjXFTPenmJE1t6R00xTfvU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726199AbgHIRsA (ORCPT ); Sun, 9 Aug 2020 13:48:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:34868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbgHIRsA (ORCPT ); Sun, 9 Aug 2020 13:48:00 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B55A206B5; Sun, 9 Aug 2020 17:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596995279; bh=mXDBApGPwHvRpWoci5kU70zkmMHizKMJsB8PqF5H5fU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=COzGeqZ3Tjurdv31u4Yp5TkPsnAte4hpDcQVAjNdDnCoHN2dIclapRlR8wWjmJMvO Zn5iAdluMAiadPeF81d/hNINFkqxcVsdSpZW/3O1c+ZkAtdYRReiQb7/oDKRIujg4q PQaqrVys0aM9Roqad211YnBguuGKembEbmSL+Fts= Date: Sun, 9 Aug 2020 18:47:55 +0100 From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Lars-Peter Clausen , Peter Meerwald , Jonathan Cameron Subject: Re: [PATCH v3 22/27] iio:adc:ti-adc084s021 Tidy up endian types Message-ID: <20200809184755.63d60ac6@archlinux> In-Reply-To: <20200722155103.979802-23-jic23@kernel.org> References: <20200722155103.979802-1-jic23@kernel.org> <20200722155103.979802-23-jic23@kernel.org> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 22 Jul 2020 16:50:58 +0100 Jonathan Cameron wrote: > From: Jonathan Cameron > > By adding a few local variables and avoiding a void * for > a parameter we can easily make all the endian types explicit and > get rid of the warnings from sparse: > > CHECK drivers/iio/adc/ti-adc084s021.c > drivers/iio/adc/ti-adc084s021.c:84:26: warning: incorrect type in assignment (different base types) > drivers/iio/adc/ti-adc084s021.c:84:26: expected unsigned short [usertype] > drivers/iio/adc/ti-adc084s021.c:84:26: got restricted __be16 > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16 > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16 > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16 > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16 > > Signed-off-by: Jonathan Cameron I'm a bit in 2 minds about this one. The exact warning will change as the result of the previous patch, but the problem is not introduced by that. Technically it's not a 'fix' so I'll hold this one for now. Jonathan > --- > drivers/iio/adc/ti-adc084s021.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/adc/ti-adc084s021.c b/drivers/iio/adc/ti-adc084s021.c > index dfba34834a57..fb14b92fa6e7 100644 > --- a/drivers/iio/adc/ti-adc084s021.c > +++ b/drivers/iio/adc/ti-adc084s021.c > @@ -70,11 +70,10 @@ static const struct iio_chan_spec adc084s021_channels[] = { > * @adc: The ADC SPI data. > * @data: Buffer for converted data. > */ > -static int adc084s021_adc_conversion(struct adc084s021 *adc, void *data) > +static int adc084s021_adc_conversion(struct adc084s021 *adc, __be16 *data) > { > int n_words = (adc->spi_trans.len >> 1) - 1; /* Discard first word */ > int ret, i = 0; > - u16 *p = data; > > /* Do the transfer */ > ret = spi_sync(adc->spi, &adc->message); > @@ -82,7 +81,7 @@ static int adc084s021_adc_conversion(struct adc084s021 *adc, void *data) > return ret; > > for (; i < n_words; i++) > - *(p + i) = adc->rx_buf[i + 1]; > + *(data + i) = adc->rx_buf[i + 1]; > > return ret; > } > @@ -93,6 +92,7 @@ static int adc084s021_read_raw(struct iio_dev *indio_dev, > { > struct adc084s021 *adc = iio_priv(indio_dev); > int ret; > + __be16 be_val; > > switch (mask) { > case IIO_CHAN_INFO_RAW: > @@ -107,13 +107,13 @@ static int adc084s021_read_raw(struct iio_dev *indio_dev, > } > > adc->tx_buf[0] = channel->channel << 3; > - ret = adc084s021_adc_conversion(adc, val); > + ret = adc084s021_adc_conversion(adc, &be_val); > iio_device_release_direct_mode(indio_dev); > regulator_disable(adc->reg); > if (ret < 0) > return ret; > > - *val = be16_to_cpu(*val); > + *val = be16_to_cpu(be_val); > *val = (*val >> channel->scan_type.shift) & 0xff; > > return IIO_VAL_INT;