From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4405DC433DF for ; Sun, 16 Aug 2020 09:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C804206DA for ; Sun, 16 Aug 2020 09:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597569532; bh=9a6w3KyO0awE4sodC5lUb5Pq0ywGpwzaZMqWwAtg0PA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=1P0w/XwVvUy3Tck0PMH6FCuEhCOx4uL32OI0fPrHtSgD8SpAihGIOycWoIZLGFNYE YWtN5b1qXETgpgBrS/WwsqpL2GZNRdRk2eR50UVYy1j6qb5KlTs2ei3bE0ld0b6iDO mpyzbONTA0qs3lOZDO3NcZMSnnHch1Wy1UVms2/Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726022AbgHPJSv (ORCPT ); Sun, 16 Aug 2020 05:18:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:39948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725943AbgHPJSt (ORCPT ); Sun, 16 Aug 2020 05:18:49 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8444B2067C; Sun, 16 Aug 2020 09:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597569529; bh=9a6w3KyO0awE4sodC5lUb5Pq0ywGpwzaZMqWwAtg0PA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J8mZ8zCx/oKLRz9or6KrIx/B6sE4g/z26lkb7+NRAR9Tig8NdjsQ/iJePiZA4xEu6 h7OwuZOC8L29o+776S/pCwlr/MlcUjbFZmp4tmOYZ0k/lhysVRuh4bu1yCwseg8CZJ JE2PCGnMjzvuk/dq/ruUI9fneF0eOohE+JjlcTb0= Date: Sun, 16 Aug 2020 10:18:44 +0100 From: Jonathan Cameron To: Christian Eggers Cc: Pavel Machek , Jonathan Cameron , Andy Shevchenko , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , , Subject: Re: [PATCH] iio: documentation: light: Add as73211 sysfs documentation Message-ID: <20200816101844.79e1c5c5@archlinux> In-Reply-To: <2320252.sbR73lAtI7@n95hx1g2> References: <20200808171443.114c8e05@archlinux> <4688751.agSyimv0uN@n95hx1g2> <20200810123540.sdzbtpgwkyqjg6ag@duo.ucw.cz> <2320252.sbR73lAtI7@n95hx1g2> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 10 Aug 2020 15:24:39 +0200 Christian Eggers wrote: > Hi Pavel, >=20 > On Monday, 10 August 2020, 14:35:40 CEST, Pavel Machek wrote: > > On Mon 2020-08-10 11:57:46, Christian Eggers wrote: =20 > > > On Monday, 10 August 2020, 11:00:54 CEST, Pavel Machek wrote: =20 > > > > Hi! > > > > =20 > > > > > The driver for the as73211 light sensor provides the following no= t yet > > > > > documented sysfs entries: > > > > > - in_intensity_(x|y|z)_raw > > > > > - in_intensity_(x|y|z)_scale > > > > > - in_intensity_sampling_frequency(_available) > > > > > - in_intensity_hardwaregain(_available) =20 > > > > > > > > Should that be hardware_gain ? =20 > > > > > > drivers/iio/industrialio-core.c: > > > [IIO_CHAN_INFO_HARDWAREGAIN] =3D "hardwaregain", =20 > > > > Yep. Fix that before people start to really use it. =20 > it's too late! IIO_CHAN_INFO_HARDWAREGAIN was introduced back in 2012. My > patch only adds "hardwaregain" in a new context (of "intensity"). Why do you think that is broken? It was a deliberate decision to try and stop putting _'s into new elements because it was making userspace parsing harder. hardwaregain is a single 'token' in that file name. We are stuck with some older forms that predate that decision and a few that are closely related to existing elements and hence had to maintain the 'spacing'. Those have to be special cased in tokenizing code. We don't want to introduced any more though. One or two may have snuck through when we weren't awake of course. Jonathan >=20 > > =20 > Pavel >=20 > regards > Christian >=20 >=20 >=20 >=20 > ________________________________ > [http://assets.arri.com/media/sign/2020-04-03-E-mail-signature-Stellar2_= V1.jpg] >=20 > Get all the latest information from www.arri.com, = Facebook, Twitter, Instagram and YouTube. >=20 > Arnold & Richter Cine Technik GmbH & Co. Betriebs KG > Sitz: M=C3=BCnchen - Registergericht: Amtsgericht M=C3=BCnchen - Handelsr= egisternummer: HRA 57918 > Pers=C3=B6nlich haftender Gesellschafter: Arnold & Richter Cine Technik G= mbH > Sitz: M=C3=BCnchen - Registergericht: Amtsgericht M=C3=BCnchen - Handelsr= egisternummer: HRB 54477 > Gesch=C3=A4ftsf=C3=BChrer: Dr. Michael Neuh=C3=A4user; Stephan Schenk; Wa= lter Trauninger; Markus Zeiler