From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EABFC433E1 for ; Sun, 16 Aug 2020 09:27:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0868C206DA for ; Sun, 16 Aug 2020 09:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597570063; bh=vyaYKZtn/gjNKMZCuB+6vm9tSNJKQL8DxOgcCxLRYoY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=WxdEwwZ1Kis5O7fW6o6TauYAt2RiiA0vMJ/jcwdsWY2vFH3fzyYhsmbE5l4nP2MJn JrElTscbGrFH+bYnOFmoinPIVtI4QP2PE92yQhk39eDCN9p+HPYyWErbCtv8erz+XP 0F87TbgWndn6sUv0aolVoUACb9Tcdaprv6LjH1RY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728985AbgHPJ1m (ORCPT ); Sun, 16 Aug 2020 05:27:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:44878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725986AbgHPJ1i (ORCPT ); Sun, 16 Aug 2020 05:27:38 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9754B2067C; Sun, 16 Aug 2020 09:27:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597570058; bh=vyaYKZtn/gjNKMZCuB+6vm9tSNJKQL8DxOgcCxLRYoY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GRq8hsCRXyHipm3CTTG25wEoq9JLSKszbcuJSJItwMRQ1B5ye2gQyBB0FJMyb8gIW V+09GvAeN4JHvlQEo3oChVBT/fgLuOyvXP+qzPfE91Zs089A+OtaBdHMQGVw6eD6RN xcg/PTGdOmVi6hz/76FFn9V2osCet0+Wl3aXFY6M= Date: Sun, 16 Aug 2020 10:27:33 +0100 From: Jonathan Cameron To: Chris Ruehl Cc: devicetree@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio/dac: convert ltc2632.txt to lltc,ltc2632.yaml Message-ID: <20200816102733.7fa1d3ce@archlinux> In-Reply-To: <20200810033806.15503-1-chris.ruehl@gtsys.com.hk> References: <20200810033806.15503-1-chris.ruehl@gtsys.com.hk> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 10 Aug 2020 11:37:52 +0800 Chris Ruehl wrote: Hi Chris, This will need a dt-binding maintainer review, but in the meantime... Look at the title for dt-bindings patches and match that format. One question for Rob inline. A quick grep suggests we are very inconsistent on whether we use the multiline block thing for description fields or not. Is it needed? > Conversion of the ltc2632 to yaml format and name the file to > 'lltc,ltc2632.yaml'. > > Signed-off-by: Chris Ruehl > --- > v6: > Remove tab and drop unused label > Related patches already in linux-next. > [PATCH v5 1/3] iio: documentation ltc2632_chip_info add num_channels > linux-next commit: 6f1c9e0da9aae51177457731357ae8a2c8af27cd > PATCH v5 2/3] iio: DAC extension for ltc2634-12/10/8 > linux-next commit: aefa5bc87c808dd08db2fc79ebdbf19ed4af7be2 > > .../bindings/iio/dac/lltc,ltc2632.yaml | 77 +++++++++++++++++++ > .../devicetree/bindings/iio/dac/ltc2632.txt | 49 ------------ > 2 files changed, 77 insertions(+), 49 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml > delete mode 100644 Documentation/devicetree/bindings/iio/dac/ltc2632.txt > > diff --git a/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml b/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml > new file mode 100644 > index 000000000000..edf804d0aca2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/iio/dac/lltc,ltc2632.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Linear Technology LTC263x 12-/10-/8-Bit Rail-to-Rail DAC > + > +maintainers: > + - Michael Hennerich > + > +description: | > + Bindings for the Linear Technology LTC2632/2634/2636 DAC > + Datasheet can be found here: https://www.analog.com/media/en/technical-documentation/data-sheets/LTC263[246].pdf > + > +properties: > + compatible: > + enum: > + - lltc,ltc2632-l12 > + - lltc,ltc2632-l10 > + - lltc,ltc2632-l8 > + - lltc,ltc2632-h12 > + - lltc,ltc2632-h10 > + - lltc,ltc2632-h8 > + - lltc,ltc2634-l12 > + - lltc,ltc2634-l10 > + - lltc,ltc2634-l8 > + - lltc,ltc2634-h12 > + - lltc,ltc2634-h10 > + - lltc,ltc2634-h8 > + - lltc,ltc2636-l12 > + - lltc,ltc2636-l10 > + - lltc,ltc2636-l8 > + - lltc,ltc2636-h12 > + - lltc,ltc2636-h10 > + - lltc,ltc2636-h8 > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 2000000 > + > + vref-supply: > + description: Does this need a | ? > + Phandle to the external reference voltage supply. This should > + only be set if there is an external reference voltage connected to the VREF > + pin. If the property is not set the internal reference is used. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + vref: regulator-vref { > + compatible = "regulator-fixed"; > + regulator-name = "vref-ltc2632"; > + regulator-min-microvolt = <1250000>; > + regulator-max-microvolt = <1250000>; > + regulator-always-on; > + }; > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + dac@0 { > + compatible = "lltc,ltc2632"; > + reg = <0>; /* CS0 */ > + spi-max-frequency = <1000000>; > + vref-supply = <&vref>; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt > deleted file mode 100644 > index 1ab9570cf219..000000000000 > --- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt > +++ /dev/null > @@ -1,49 +0,0 @@ > -Linear Technology LTC2632/2634/2636 DAC > - > -Required properties: > - - compatible: Has to contain one of the following: > - lltc,ltc2632-l12 > - lltc,ltc2632-l10 > - lltc,ltc2632-l8 > - lltc,ltc2632-h12 > - lltc,ltc2632-h10 > - lltc,ltc2632-h8 > - lltc,ltc2634-l12 > - lltc,ltc2634-l10 > - lltc,ltc2634-l8 > - lltc,ltc2634-h12 > - lltc,ltc2634-h10 > - lltc,ltc2634-h8 > - lltc,ltc2636-l12 > - lltc,ltc2636-l10 > - lltc,ltc2636-l8 > - lltc,ltc2636-h12 > - lltc,ltc2636-h10 > - lltc,ltc2636-h8 > - > -Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt > -apply. In particular, "reg" and "spi-max-frequency" properties must be given. > - > -Optional properties: > - - vref-supply: Phandle to the external reference voltage supply. This should > - only be set if there is an external reference voltage connected to the VREF > - pin. If the property is not set the internal reference is used. > - > -Example: > - > - vref: regulator-vref { > - compatible = "regulator-fixed"; > - regulator-name = "vref-ltc2632"; > - regulator-min-microvolt = <1250000>; > - regulator-max-microvolt = <1250000>; > - regulator-always-on; > - }; > - > - spi_master { > - dac: ltc2632@0 { > - compatible = "lltc,ltc2632-l12"; > - reg = <0>; /* CS0 */ > - spi-max-frequency = <1000000>; > - vref-supply = <&vref>; /* optional */ > - }; > - };