From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293A8C433DF for ; Thu, 20 Aug 2020 09:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C38720885 for ; Thu, 20 Aug 2020 09:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725916AbgHTJCg (ORCPT ); Thu, 20 Aug 2020 05:02:36 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2677 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725820AbgHTJCg (ORCPT ); Thu, 20 Aug 2020 05:02:36 -0400 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 6C4FC1758EF362B9B98E; Thu, 20 Aug 2020 10:02:32 +0100 (IST) Received: from localhost (10.52.123.156) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Thu, 20 Aug 2020 10:02:32 +0100 Date: Thu, 20 Aug 2020 10:01:00 +0100 From: Jonathan Cameron To: Denis CIOCCA CC: Jonathan Cameron , linux-iio , Andy Shevchenko , Daniel Palmer , Mario TESI , Subject: Re: [RFC PATCH 2/2] iio: st-accel: Add support for Silan SC7A20 and SC7A30E Message-ID: <20200820100100.00000d33@Huawei.com> In-Reply-To: References: <20200811134846.3981475-1-daniel@0x0f.com> <20200811134846.3981475-3-daniel@0x0f.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.123.156] X-ClientProxiedBy: lhreml743-chm.china.huawei.com (10.201.108.193) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org +CC: GregKH as this will pass through his tree. As a quick summary, it seems we have some cloned parts that appear to be compatible with certain ST micro parts, but have different whoami address values. Entirely reasonably, Denis is not happy to have them added to the ST maintained driver given the potential for future incompatibilities. I don't particularly mind a separate driver, though I would ask that we remove a lot of the abstractions from the ST driver as they won't be necessary given the much more restricted parts being supported, Greg, I'm guessing this is far from the first time this has happened. Any advise? Jonathan On Wed, 19 Aug 2020 18:19:21 +0000 Denis CIOCCA wrote: > Hi Jonathan, > > I strongly disagree that these parts will be supported by STMicroelectronics driver. > We DO NOT want to find out one day that we need to modify our structure in order to support competition. If they need to support this chip, please provide a new driver for that part leaving STMicroelectronics driver managing our parts. > > Thanks & Br, > Denis > > > > > -----Original Message----- > > From: linux-iio-owner@vger.kernel.org > > On Behalf Of Daniel Palmer > > Sent: Sunday, August 16, 2020 5:00 AM > > To: Andy Shevchenko > > Cc: linux-iio ; Jonathan Cameron > > > > Subject: Re: [RFC PATCH 2/2] iio: st-accel: Add support for Silan SC7A20 and > > SC7A30E > > > > Hi Andy, > > > > On Sun, 16 Aug 2020 at 18:55, Andy Shevchenko > > wrote: > > > No SoB tag?! Hint: `git commit -a -s --amend` would fix this if you > > > have properly configured Git. > > > > > > > Sorry I wasn't aware it was needed for an RFC. > > > > > On top of that, can you add Datasheet: tag with links to the actual > > > component datasheets? > > > > I will do that for the v1 of the patch series. All of the datasheets I've found so > > far are mostly Chinese but the register tables are in English. I've collected > > them together > > here: http://linux-chenxing.org/silan/index.html > > > > Cheers, > > > > Daniel