From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383C5C433DF for ; Sat, 22 Aug 2020 10:44:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D3D0207DA for ; Sat, 22 Aug 2020 10:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598093049; bh=meJmEjFRlB1QI1uBtV7Y0+W0GJYcPJyhfPeQ0hUUVIo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=tuAetQKTn//0Cuwz/Hb4Ru/64mLQLQpDtdykxYKDM4mdGsgR+Q2q3Hq4HNh4q+GOr 2IbHBcniSYLNauc12I3pKC93yMlrpnbs56O9WsK8JRvS6XN8R1zZU6C6B7AUYRpQKm VGc/i5aj0VAWt1D/70Jn/bv4CPn4rSO67q0+EgRY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727006AbgHVKoI (ORCPT ); Sat, 22 Aug 2020 06:44:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:50388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726222AbgHVKoH (ORCPT ); Sat, 22 Aug 2020 06:44:07 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B285E206BE; Sat, 22 Aug 2020 10:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598093047; bh=meJmEjFRlB1QI1uBtV7Y0+W0GJYcPJyhfPeQ0hUUVIo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XkCcDK3Bfv/h00ARERSsvgcU/QzqiGe2+JLT0Rax8ImT0VK20LhdYCZcj+N5oVymq 8gjY+kglB7EYsW/2vua2GLlY6HuE5Ycz+bbh7yZgptdYwcnqhXGfVv1T10rmgP1W27 Pd0Xaz74vnX2g/6+yZ589YW+Bs/A8vxk00Or02H8= Date: Sat, 22 Aug 2020 11:44:02 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Alexandru Ardelean , Tian Tao , Lars-Peter Clausen , "Hennerich, Michael" , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio , LKML , Alexandru Ardelean Subject: Re: [PATCH] iio: adc: adi-axi-adc: Use kobj_to_dev() instead of container_of() Message-ID: <20200822114402.5dd84fce@archlinux> In-Reply-To: References: <1597892486-3236-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 20 Aug 2020 16:07:04 +0300 Andy Shevchenko wrote: > On Thu, Aug 20, 2020 at 4:05 PM Andy Shevchenko > wrote: > > On Thu, Aug 20, 2020 at 12:10 PM Alexandru Ardelean > > wrote: > > > On Thu, Aug 20, 2020 at 6:04 AM Tian Tao wrote: > > > > > - struct device *dev = container_of(kobj, struct device, kobj); > > > > + struct device *dev = kobj_to_dev(kobj); > > > And now this can be one line since dev is not used separately. > > On the other hand perhaps one object per line is better to read. > Indeed, not clear one way or the others, so I'm going with the path of least resistance. Applied as is. Thanks, Jonathan