From: Krzysztof Kozlowski <krzk@kernel.org> To: Alexandru Ardelean <alexandru.ardelean@analog.com> Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, jic23@kernel.org, kgene@kernel.org, Sergiu Cuciurean <sergiu.cuciurean@analog.com> Subject: Re: [PATCH] iio: adc: exynos_adc: Replace indio_dev->mlock with own device lock Date: Thu, 27 Aug 2020 08:56:25 +0200 [thread overview] Message-ID: <20200827065625.GB17964@kozik-lap> (raw) In-Reply-To: <20200826132203.236748-1-alexandru.ardelean@analog.com> On Wed, Aug 26, 2020 at 04:22:03PM +0300, Alexandru Ardelean wrote: > From: Sergiu Cuciurean <sergiu.cuciurean@analog.com> > > As part of the general cleanup of indio_dev->mlock, this change replaces > it with a local lock, to protect potential concurrent access to the > completion callback during a conversion. I don't know the bigger picture (and no links here for general cleanup) but I assume it is part of wider work and that mlock is unwanted. In such case: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> If it is part of some bigger work, please put a link to lore.kernel.org under separators ---, so everyone can get the context. Best regards, Krzysztof > > Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > --- > drivers/iio/adc/exynos_adc.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) >
next prev parent reply other threads:[~2020-08-27 6:56 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-26 13:22 Alexandru Ardelean 2020-08-27 6:56 ` Krzysztof Kozlowski [this message] 2020-08-27 8:53 ` Alexandru Ardelean 2020-08-29 15:33 ` Jonathan Cameron 2020-08-29 15:35 ` Jonathan Cameron 2020-09-16 9:31 ` [PATCH v2] " Alexandru Ardelean 2020-09-19 15:19 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200827065625.GB17964@kozik-lap \ --to=krzk@kernel.org \ --cc=alexandru.ardelean@analog.com \ --cc=jic23@kernel.org \ --cc=kgene@kernel.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sergiu.cuciurean@analog.com \ --subject='Re: [PATCH] iio: adc: exynos_adc: Replace indio_dev->mlock with own device lock' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).