* [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER
@ 2020-08-28 17:42 Alexandru Elisei
2020-08-29 14:57 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Alexandru Elisei @ 2020-08-28 17:42 UTC (permalink / raw)
To: linux-kernel, linux-iio; +Cc: jic23, knaack.h, lars, pmeerw, xxm
Building the Rockchip saradc driver can trigger the following error if the
driver is compiled into the kernel, but the IIO triggered buffer is not:
aarch64-linux-gnu-ld: drivers/iio/adc/rockchip_saradc.o: in function `rockchip_saradc_probe':
/path/to/linux/drivers/iio/adc/rockchip_saradc.c:427: undefined reference to `devm_iio_triggered_buffer_setup'
This is because commit 4e130dc7b413 ("iio: adc: rockchip_saradc: Add
support iio buffers") added support for industrial I/O triggered buffers,
but didn't update Kconfig to build the required file. Fix that.
Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
---
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 66d9cc073157..baa36a07a9cf 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -865,6 +865,7 @@ config ROCKCHIP_SARADC
tristate "Rockchip SARADC driver"
depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
depends on RESET_CONTROLLER
+ select IIO_TRIGGERED_BUFFER
help
Say yes here to build support for the SARADC found in SoCs from
Rockchip.
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER
2020-08-28 17:42 [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER Alexandru Elisei
@ 2020-08-29 14:57 ` Jonathan Cameron
2020-08-30 9:26 ` Alexandru Elisei
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2020-08-29 14:57 UTC (permalink / raw)
To: Alexandru Elisei; +Cc: linux-kernel, linux-iio, knaack.h, lars, pmeerw, xxm
On Fri, 28 Aug 2020 18:42:42 +0100
Alexandru Elisei <alexandru.elisei@arm.com> wrote:
> Building the Rockchip saradc driver can trigger the following error if the
> driver is compiled into the kernel, but the IIO triggered buffer is not:
>
> aarch64-linux-gnu-ld: drivers/iio/adc/rockchip_saradc.o: in function `rockchip_saradc_probe':
> /path/to/linux/drivers/iio/adc/rockchip_saradc.c:427: undefined reference to `devm_iio_triggered_buffer_setup'
>
> This is because commit 4e130dc7b413 ("iio: adc: rockchip_saradc: Add
> support iio buffers") added support for industrial I/O triggered buffers,
> but didn't update Kconfig to build the required file. Fix that.
>
> Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
Sorry, I've had a patch queued to fix this for a while, but had a
vacation just after merge window occurred that delayed me sending it out.
Will send a pull sometime this weekend.
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 66d9cc073157..baa36a07a9cf 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -865,6 +865,7 @@ config ROCKCHIP_SARADC
> tristate "Rockchip SARADC driver"
> depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
> depends on RESET_CONTROLLER
> + select IIO_TRIGGERED_BUFFER
> help
> Say yes here to build support for the SARADC found in SoCs from
> Rockchip.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER
2020-08-29 14:57 ` Jonathan Cameron
@ 2020-08-30 9:26 ` Alexandru Elisei
0 siblings, 0 replies; 6+ messages in thread
From: Alexandru Elisei @ 2020-08-30 9:26 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-kernel, linux-iio, knaack.h, lars, pmeerw, xxm
Hi Jonathan,
On 8/29/20 3:57 PM, Jonathan Cameron wrote:
> On Fri, 28 Aug 2020 18:42:42 +0100
> Alexandru Elisei <alexandru.elisei@arm.com> wrote:
>
>> Building the Rockchip saradc driver can trigger the following error if the
>> driver is compiled into the kernel, but the IIO triggered buffer is not:
>>
>> aarch64-linux-gnu-ld: drivers/iio/adc/rockchip_saradc.o: in function `rockchip_saradc_probe':
>> /path/to/linux/drivers/iio/adc/rockchip_saradc.c:427: undefined reference to `devm_iio_triggered_buffer_setup'
>>
>> This is because commit 4e130dc7b413 ("iio: adc: rockchip_saradc: Add
>> support iio buffers") added support for industrial I/O triggered buffers,
>> but didn't update Kconfig to build the required file. Fix that.
>>
>> Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
>> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
> Sorry, I've had a patch queued to fix this for a while, but had a
> vacation just after merge window occurred that delayed me sending it out.
>
> Will send a pull sometime this weekend.
>
> Jonathan
That's great, thank you!
Thanks,
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER
2020-08-03 11:59 ` Heiko Stuebner
@ 2020-08-09 11:52 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2020-08-09 11:52 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Michael Walle, linux-iio, linux-kernel, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Simon Xue
On Mon, 03 Aug 2020 13:59:12 +0200
Heiko Stuebner <heiko.stuebner@theobroma-systems.com> wrote:
> Am Montag, 3. August 2020, 10:30:01 CEST schrieb Michael Walle:
> > The kernel fails to compile due to undefined reference to
> > devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not
> > enabled. The original patch [1] had this dependency. But somehow it
> > didn't make it into the kernel tree. Re-add it.
> >
> > [1] https://lore.kernel.org/lkml/20200623233011.2319035-3-heiko@sntech.de/
> >
> > Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
> > Signed-off-by: Michael Walle <michael@walle.cc>
>
> Reviewed-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
> > ---
> > drivers/iio/adc/Kconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index 66d9cc073157..d94dc800b842 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -865,6 +865,8 @@ config ROCKCHIP_SARADC
> > tristate "Rockchip SARADC driver"
> > depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
> > depends on RESET_CONTROLLER
> > + select IIO_BUFFER
> > + select IIO_TRIGGERED_BUFFER
> > help
> > Say yes here to build support for the SARADC found in SoCs from
> > Rockchip.
> >
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER
2020-08-03 8:30 [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER Michael Walle
@ 2020-08-03 11:59 ` Heiko Stuebner
2020-08-09 11:52 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2020-08-03 11:59 UTC (permalink / raw)
To: Michael Walle
Cc: linux-iio, linux-kernel, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Simon Xue
Am Montag, 3. August 2020, 10:30:01 CEST schrieb Michael Walle:
> The kernel fails to compile due to undefined reference to
> devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not
> enabled. The original patch [1] had this dependency. But somehow it
> didn't make it into the kernel tree. Re-add it.
>
> [1] https://lore.kernel.org/lkml/20200623233011.2319035-3-heiko@sntech.de/
>
> Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
> drivers/iio/adc/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 66d9cc073157..d94dc800b842 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -865,6 +865,8 @@ config ROCKCHIP_SARADC
> tristate "Rockchip SARADC driver"
> depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
> depends on RESET_CONTROLLER
> + select IIO_BUFFER
> + select IIO_TRIGGERED_BUFFER
> help
> Say yes here to build support for the SARADC found in SoCs from
> Rockchip.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER
@ 2020-08-03 8:30 Michael Walle
2020-08-03 11:59 ` Heiko Stuebner
0 siblings, 1 reply; 6+ messages in thread
From: Michael Walle @ 2020-08-03 8:30 UTC (permalink / raw)
To: linux-iio, linux-kernel
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Heiko Stuebner, Simon Xue, Michael Walle
The kernel fails to compile due to undefined reference to
devm_iio_triggered_buffer_setup() if IIO_TRIGGERED_BUFFER is not
enabled. The original patch [1] had this dependency. But somehow it
didn't make it into the kernel tree. Re-add it.
[1] https://lore.kernel.org/lkml/20200623233011.2319035-3-heiko@sntech.de/
Fixes: 4e130dc7b413 ("iio: adc: rockchip_saradc: Add support iio buffers")
Signed-off-by: Michael Walle <michael@walle.cc>
---
drivers/iio/adc/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 66d9cc073157..d94dc800b842 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -865,6 +865,8 @@ config ROCKCHIP_SARADC
tristate "Rockchip SARADC driver"
depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
depends on RESET_CONTROLLER
+ select IIO_BUFFER
+ select IIO_TRIGGERED_BUFFER
help
Say yes here to build support for the SARADC found in SoCs from
Rockchip.
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-30 9:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-28 17:42 [PATCH] iio: adc: rockchip_saradc: Select IIO_TRIGGERED_BUFFER Alexandru Elisei
2020-08-29 14:57 ` Jonathan Cameron
2020-08-30 9:26 ` Alexandru Elisei
-- strict thread matches above, loose matches on Subject: below --
2020-08-03 8:30 [PATCH] iio: adc: rockchip_saradc: select IIO_TRIGGERED_BUFFER Michael Walle
2020-08-03 11:59 ` Heiko Stuebner
2020-08-09 11:52 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).