From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C8AC433E2 for ; Sun, 6 Sep 2020 14:31:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6F9020714 for ; Sun, 6 Sep 2020 14:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599402683; bh=y8V2jSt6CHxIrgaBPb6382mI9eUqYemE/PcSqWP3Htw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=LiPxj/wCxbMR6CTfritwMChuZxeldFoYHzA3CMQUyl4Q59/3PEWeFlIpEWiJkMmRx WNuvL5MwBi0hVt4E35tovPhj7SAQymkDnOs7H5K3AIwMqOj+tKSb6Mqm5t53//c7sa hCx4aOWlltg4SRncRAZ+wKlVZXuXYipzq5PvN840= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728953AbgIFOX3 (ORCPT ); Sun, 6 Sep 2020 10:23:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:57888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728945AbgIFOXW (ORCPT ); Sun, 6 Sep 2020 10:23:22 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 384F6207BC; Sun, 6 Sep 2020 14:23:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599402201; bh=y8V2jSt6CHxIrgaBPb6382mI9eUqYemE/PcSqWP3Htw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oFjVqqd0fqkLqVozMTV3rNEAwf/TTMmfk5bebpDgAaj54u9wiZxt4e7M0qcX2xcqA Z+geGQYd8oEGwrBkJQMJShnQDVYS5yz1HAA0XBNxFCvj/oItZKvz3/KJrJFQb11p34 0fZIN86SjsSaRiQdmoaw6Ki3gIMhxkzXGvBs/ZoQ= Date: Sun, 6 Sep 2020 15:23:15 +0100 From: Jonathan Cameron To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Rob Herring , Zhang Rui , Daniel Lezcano , Amit Kucheria , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH v2 4/9] iio: adc: qcom-vadc-common: use fixp_linear_interpolate Message-ID: <20200906152315.53065c49@archlinux> In-Reply-To: <20200903132109.1914011-5-dmitry.baryshkov@linaro.org> References: <20200903132109.1914011-1-dmitry.baryshkov@linaro.org> <20200903132109.1914011-5-dmitry.baryshkov@linaro.org> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 3 Sep 2020 16:21:04 +0300 Dmitry Baryshkov wrote: > Use new function fixp_linear_interpolate() instead of hand-coding the > linar interpolation. linear Note I'm not sure who will pick these up hence I'm giving reviewed-by's. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Jonathan Cameron > --- > drivers/iio/adc/qcom-vadc-common.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c > index d11f3343ad52..40d77b3af1bb 100644 > --- a/drivers/iio/adc/qcom-vadc-common.c > +++ b/drivers/iio/adc/qcom-vadc-common.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -368,10 +369,9 @@ static int qcom_vadc_map_voltage_temp(const struct vadc_map_pt *pts, > } else { > /* result is between search_index and search_index-1 */ > /* interpolate linearly */ > - *output = (((s32)((pts[i].y - pts[i - 1].y) * > - (input - pts[i - 1].x)) / > - (pts[i].x - pts[i - 1].x)) + > - pts[i - 1].y); > + *output = fixp_linear_interpolate(pts[i - 1].x, pts[i - 1].y, > + pts[i].x, pts[i].y, > + input); > } > > return 0;