From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: linux-iio@vger.kernel.org
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v3 22/27] iio:adc:ti-adc084s021 Tidy up endian types
Date: Sun, 13 Sep 2020 13:06:04 +0100 [thread overview]
Message-ID: <20200913130604.622c1125@archlinux> (raw)
In-Reply-To: <20200913130146.46983bcc@archlinux>
On Sun, 13 Sep 2020 13:01:46 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Sun, 9 Aug 2020 18:47:55 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Wed, 22 Jul 2020 16:50:58 +0100
> > Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > >
> > > By adding a few local variables and avoiding a void * for
> > > a parameter we can easily make all the endian types explicit and
> > > get rid of the warnings from sparse:
> > >
> > > CHECK drivers/iio/adc/ti-adc084s021.c
> > > drivers/iio/adc/ti-adc084s021.c:84:26: warning: incorrect type in assignment (different base types)
> > > drivers/iio/adc/ti-adc084s021.c:84:26: expected unsigned short [usertype]
> > > drivers/iio/adc/ti-adc084s021.c:84:26: got restricted __be16
> > > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16
> > > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16
> > > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16
> > > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16
> > >
> > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > I'm a bit in 2 minds about this one. The exact warning will change as the
> > result of the previous patch, but the problem is not introduced by that.
> > Technically it's not a 'fix' so I'll hold this one for now.
>
> Applied this one to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to play with it.
And failed my local tests. Precursor not in my branch yet.
oops.
Dropped again for now.
>
> Thanks,
>
> Jonathan
>
> >
> > Jonathan
> >
> > > ---
> > > drivers/iio/adc/ti-adc084s021.c | 10 +++++-----
> > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/iio/adc/ti-adc084s021.c b/drivers/iio/adc/ti-adc084s021.c
> > > index dfba34834a57..fb14b92fa6e7 100644
> > > --- a/drivers/iio/adc/ti-adc084s021.c
> > > +++ b/drivers/iio/adc/ti-adc084s021.c
> > > @@ -70,11 +70,10 @@ static const struct iio_chan_spec adc084s021_channels[] = {
> > > * @adc: The ADC SPI data.
> > > * @data: Buffer for converted data.
> > > */
> > > -static int adc084s021_adc_conversion(struct adc084s021 *adc, void *data)
> > > +static int adc084s021_adc_conversion(struct adc084s021 *adc, __be16 *data)
> > > {
> > > int n_words = (adc->spi_trans.len >> 1) - 1; /* Discard first word */
> > > int ret, i = 0;
> > > - u16 *p = data;
> > >
> > > /* Do the transfer */
> > > ret = spi_sync(adc->spi, &adc->message);
> > > @@ -82,7 +81,7 @@ static int adc084s021_adc_conversion(struct adc084s021 *adc, void *data)
> > > return ret;
> > >
> > > for (; i < n_words; i++)
> > > - *(p + i) = adc->rx_buf[i + 1];
> > > + *(data + i) = adc->rx_buf[i + 1];
> > >
> > > return ret;
> > > }
> > > @@ -93,6 +92,7 @@ static int adc084s021_read_raw(struct iio_dev *indio_dev,
> > > {
> > > struct adc084s021 *adc = iio_priv(indio_dev);
> > > int ret;
> > > + __be16 be_val;
> > >
> > > switch (mask) {
> > > case IIO_CHAN_INFO_RAW:
> > > @@ -107,13 +107,13 @@ static int adc084s021_read_raw(struct iio_dev *indio_dev,
> > > }
> > >
> > > adc->tx_buf[0] = channel->channel << 3;
> > > - ret = adc084s021_adc_conversion(adc, val);
> > > + ret = adc084s021_adc_conversion(adc, &be_val);
> > > iio_device_release_direct_mode(indio_dev);
> > > regulator_disable(adc->reg);
> > > if (ret < 0)
> > > return ret;
> > >
> > > - *val = be16_to_cpu(*val);
> > > + *val = be16_to_cpu(be_val);
> > > *val = (*val >> channel->scan_type.shift) & 0xff;
> > >
> > > return IIO_VAL_INT;
> >
>
next prev parent reply other threads:[~2020-09-13 12:06 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 15:50 [PATCH v3 00/27] IIO: Fused set 1 and 2 of timestamp alignment fixes Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 01/27] iio: accel: kxsd9: Fix alignment of local buffer Jonathan Cameron
2020-08-09 17:07 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 02/27] iio:accel:mma8452: Fix timestamp alignment and prevent data leak Jonathan Cameron
2020-08-09 17:14 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 03/27] iio:accel:bmc150-accel: " Jonathan Cameron
2020-07-29 17:12 ` Srinivas Pandruvada
2020-08-09 17:18 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 04/27] iio:accel:mma7455: " Jonathan Cameron
2020-08-09 17:19 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 05/27] iio:gyro:itg3200: " Jonathan Cameron
2020-09-19 15:41 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 06/27] iio:proximity:mb1232: " Jonathan Cameron
2020-08-09 17:20 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 07/27] iio:chemical:ccs811: " Jonathan Cameron
2020-08-09 17:23 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 08/27] iio:light:si1145: " Jonathan Cameron
2020-07-22 19:43 ` Andy Shevchenko
2020-07-22 19:45 ` Andy Shevchenko
2020-07-23 11:25 ` Jonathan Cameron
2020-09-19 15:46 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 09/27] iio:light:max44000 " Jonathan Cameron
2020-08-09 17:24 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 10/27] iio:light:rpr0521 " Jonathan Cameron
2020-07-22 19:47 ` Andy Shevchenko
2020-07-23 11:29 ` Jonathan Cameron
2020-09-19 16:31 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 11/27] iio:light:st_uvis25 " Jonathan Cameron
2020-07-22 19:48 ` Andy Shevchenko
2020-07-22 15:50 ` [PATCH v3 12/27] iio:light:ltr501 Fix timestamp alignment issue Jonathan Cameron
2020-08-09 17:27 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 13/27] iio:magnetometer:ak8975 Fix alignment and data leak issues Jonathan Cameron
2020-08-09 17:30 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 14/27] iio:magnetometer:mag3110 " Jonathan Cameron
2020-07-23 12:13 ` Andy Shevchenko
2020-07-22 15:50 ` [PATCH v3 15/27] iio:imu:bmi160 " Jonathan Cameron
2020-09-19 15:58 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 16/27] iio:imu:st_lsm6dsx " Jonathan Cameron
2020-09-19 16:09 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 17/27] iio:imu:inv_mpu6050 Fix dma and ts " Jonathan Cameron
2020-07-24 8:27 ` Jean-Baptiste Maneyrol
2020-09-19 16:51 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 18/27] iio:imu:inv_mpu6050: Use regmap_noinc_read for fifo reads Jonathan Cameron
2020-07-23 12:15 ` Andy Shevchenko
2020-07-23 12:28 ` Jonathan Cameron
2020-07-24 8:29 ` Jean-Baptiste Maneyrol
2020-09-19 16:55 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 19/27] iio:pressure:mpl3115 Force alignment of buffer Jonathan Cameron
2020-07-23 12:17 ` Andy Shevchenko
2020-07-23 12:31 ` Jonathan Cameron
2020-09-19 17:02 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 20/27] iio:adc:ti-adc081c Fix alignment and data leak issues Jonathan Cameron
2020-08-09 17:34 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 21/27] iio:adc:ti-adc084s021 " Jonathan Cameron
2020-08-09 17:36 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 22/27] iio:adc:ti-adc084s021 Tidy up endian types Jonathan Cameron
2020-08-09 17:47 ` Jonathan Cameron
2020-09-13 12:01 ` Jonathan Cameron
2020-09-13 12:06 ` Jonathan Cameron [this message]
2020-11-29 13:28 ` Jonathan Cameron
2020-07-22 15:50 ` [PATCH v3 23/27] iio:adc:ti-ads124s08 Fix alignment and data leak issues Jonathan Cameron
2020-07-22 20:54 ` Andy Shevchenko
2020-07-23 11:23 ` Jonathan Cameron
2020-07-22 15:51 ` [PATCH v3 24/27] iio:adc:ti-adc0832 Fix alignment issue with timestamp Jonathan Cameron
2020-09-19 16:18 ` Jonathan Cameron
2020-07-22 15:51 ` [PATCH v3 25/27] iio:adc:ti-adc12138 " Jonathan Cameron
2020-09-19 16:21 ` Jonathan Cameron
2020-07-22 15:51 ` [PATCH v3 26/27] iio:adc:ina2xx Fix timestamp alignment issue Jonathan Cameron
2020-08-09 17:38 ` Jonathan Cameron
2020-07-22 15:51 ` [PATCH v3 27/27] iio:adc:max1118 Fix alignment of timestamp and data leak issues Jonathan Cameron
2020-08-09 17:39 ` Jonathan Cameron
2020-07-23 12:23 ` [PATCH v3 00/27] IIO: Fused set 1 and 2 of timestamp alignment fixes Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200913130604.622c1125@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).