From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E69AAC43461 for ; Sun, 13 Sep 2020 12:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8EC1217BA for ; Sun, 13 Sep 2020 12:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725919AbgIMMG1 (ORCPT ); Sun, 13 Sep 2020 08:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgIMMG0 (ORCPT ); Sun, 13 Sep 2020 08:06:26 -0400 Received: from saturn.retrosnub.co.uk (saturn.retrosnub.co.uk [IPv6:2a00:1098:86::1:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF4E8C061573 for ; Sun, 13 Sep 2020 05:06:22 -0700 (PDT) Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id 45BDF9E004A; Sun, 13 Sep 2020 13:06:06 +0100 (BST) Date: Sun, 13 Sep 2020 13:06:04 +0100 From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Andy Shevchenko , Lars-Peter Clausen , Peter Meerwald , Jonathan Cameron Subject: Re: [PATCH v3 22/27] iio:adc:ti-adc084s021 Tidy up endian types Message-ID: <20200913130604.622c1125@archlinux> In-Reply-To: <20200913130146.46983bcc@archlinux> References: <20200722155103.979802-1-jic23@kernel.org> <20200722155103.979802-23-jic23@kernel.org> <20200809184755.63d60ac6@archlinux> <20200913130146.46983bcc@archlinux> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 13 Sep 2020 13:01:46 +0100 Jonathan Cameron wrote: > On Sun, 9 Aug 2020 18:47:55 +0100 > Jonathan Cameron wrote: > > > On Wed, 22 Jul 2020 16:50:58 +0100 > > Jonathan Cameron wrote: > > > > > From: Jonathan Cameron > > > > > > By adding a few local variables and avoiding a void * for > > > a parameter we can easily make all the endian types explicit and > > > get rid of the warnings from sparse: > > > > > > CHECK drivers/iio/adc/ti-adc084s021.c > > > drivers/iio/adc/ti-adc084s021.c:84:26: warning: incorrect type in assignment (different base types) > > > drivers/iio/adc/ti-adc084s021.c:84:26: expected unsigned short [usertype] > > > drivers/iio/adc/ti-adc084s021.c:84:26: got restricted __be16 > > > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16 > > > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16 > > > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16 > > > drivers/iio/adc/ti-adc084s021.c:115:24: warning: cast to restricted __be16 > > > > > > Signed-off-by: Jonathan Cameron > > > > I'm a bit in 2 minds about this one. The exact warning will change as the > > result of the previous patch, but the problem is not introduced by that. > > Technically it's not a 'fix' so I'll hold this one for now. > > Applied this one to the togreg branch of iio.git and pushed out as testing for > the autobuilders to play with it. And failed my local tests. Precursor not in my branch yet. oops. Dropped again for now. > > Thanks, > > Jonathan > > > > > Jonathan > > > > > --- > > > drivers/iio/adc/ti-adc084s021.c | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/iio/adc/ti-adc084s021.c b/drivers/iio/adc/ti-adc084s021.c > > > index dfba34834a57..fb14b92fa6e7 100644 > > > --- a/drivers/iio/adc/ti-adc084s021.c > > > +++ b/drivers/iio/adc/ti-adc084s021.c > > > @@ -70,11 +70,10 @@ static const struct iio_chan_spec adc084s021_channels[] = { > > > * @adc: The ADC SPI data. > > > * @data: Buffer for converted data. > > > */ > > > -static int adc084s021_adc_conversion(struct adc084s021 *adc, void *data) > > > +static int adc084s021_adc_conversion(struct adc084s021 *adc, __be16 *data) > > > { > > > int n_words = (adc->spi_trans.len >> 1) - 1; /* Discard first word */ > > > int ret, i = 0; > > > - u16 *p = data; > > > > > > /* Do the transfer */ > > > ret = spi_sync(adc->spi, &adc->message); > > > @@ -82,7 +81,7 @@ static int adc084s021_adc_conversion(struct adc084s021 *adc, void *data) > > > return ret; > > > > > > for (; i < n_words; i++) > > > - *(p + i) = adc->rx_buf[i + 1]; > > > + *(data + i) = adc->rx_buf[i + 1]; > > > > > > return ret; > > > } > > > @@ -93,6 +92,7 @@ static int adc084s021_read_raw(struct iio_dev *indio_dev, > > > { > > > struct adc084s021 *adc = iio_priv(indio_dev); > > > int ret; > > > + __be16 be_val; > > > > > > switch (mask) { > > > case IIO_CHAN_INFO_RAW: > > > @@ -107,13 +107,13 @@ static int adc084s021_read_raw(struct iio_dev *indio_dev, > > > } > > > > > > adc->tx_buf[0] = channel->channel << 3; > > > - ret = adc084s021_adc_conversion(adc, val); > > > + ret = adc084s021_adc_conversion(adc, &be_val); > > > iio_device_release_direct_mode(indio_dev); > > > regulator_disable(adc->reg); > > > if (ret < 0) > > > return ret; > > > > > > - *val = be16_to_cpu(*val); > > > + *val = be16_to_cpu(be_val); > > > *val = (*val >> channel->scan_type.shift) & 0xff; > > > > > > return IIO_VAL_INT; > > >